Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Storefront: fixed account authorization check

Damian Legawiec52d1dc867449
diff --git a/storefront/app/controllers/spree/account/base_controller.rb b/storefront/app/controllers/spree/account/base_controller.rb
index 7db5998f10..9226bd5d29 100644
--- a/storefront/app/controllers/spree/account/base_controller.rb
+++ b/storefront/app/controllers/spree/account/base_controller.rb
@@ -1,6 +1,8 @@
module Spree
module Account
class BaseController < Spree::StoreController
+ before_action :require_user
+
protected
def accurate_title
diff --git a/storefront/app/controllers/spree/account/newsletter_controller.rb b/storefront/app/controllers/spree/account/newsletter_controller.rb
index 144525eb0c..467fb83a97 100644
--- a/storefront/app/controllers/spree/account/newsletter_controller.rb
+++ b/storefront/app/controllers/spree/account/newsletter_controller.rb
@@ -4,7 +4,7 @@ module Spree
def edit; end
def update
- @user.update(newsletter_params)
+ try_spree_current_user.update(newsletter_params)
end
private
diff --git a/storefront/app/controllers/spree/account/orders_controller.rb b/storefront/app/controllers/spree/account/orders_controller.rb
index 3d39d2ecfa..49aca89572 100644
--- a/storefront/app/controllers/spree/account/orders_controller.rb
+++ b/storefront/app/controllers/spree/account/orders_controller.rb
@@ -21,7 +21,7 @@ module Spree
end
def orders_scope
- @user.completed_orders.for_store(current_store).order(completed_at: :desc)
+ try_spree_current_user.completed_orders.for_store(current_store).order(completed_at: :desc)
end
end
end
diff --git a/storefront/app/controllers/spree/account/profile_controller.rb b/storefront/app/controllers/spree/account/profile_controller.rb
index 7ff460552a..ec058ee61e 100644
--- a/storefront/app/controllers/spree/account/profile_controller.rb
+++ b/storefront/app/controllers/spree/account/profile_controller.rb
@@ -4,7 +4,7 @@ module Spree
def edit; end
def update
- if @user.update(user_params)
+ if try_spree_current_user.update(user_params)
redirect_to spree.edit_account_profile_path, notice: Spree.t(:account_updated)
else
render :edit, status: :unprocessable_entity
diff --git a/storefront/app/controllers/spree/account/store_credits_controller.rb b/storefront/app/controllers/spree/account/store_credits_controller.rb
index d3fe9a38b0..5f996aa640 100644
--- a/storefront/app/controllers/spree/account/store_credits_controller.rb
+++ b/storefront/app/controllers/spree/account/store_credits_controller.rb
@@ -2,7 +2,7 @@ module Spree
module Account
class StoreCreditsController < BaseController
def index
- user_store_credits = @user.store_credits.without_gift_card
+ user_store_credits = try_spree_current_user.store_credits.without_gift_card
@store_credit_events = Spree::StoreCreditEvent.where(store_credit: user_store_credits).
exposed_events.
reverse_chronological.