Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Always initialize `LineItem#quantity` with value `1` if not specified… (#12142)
Damian Legawiec543fe9dd9a0e
diff --git a/core/app/models/spree/line_item.rb b/core/app/models/spree/line_item.rbindex 358fb00104..aedf2ba106 100644--- a/core/app/models/spree/line_item.rb+++ b/core/app/models/spree/line_item.rb@@ -5,6 +5,8 @@ module Spreeinclude Spree::Webhooks::HasWebhooksend+ attribute :quantity, :integer, default: 1+before_validation :ensure_valid_quantitywith_options inverse_of: :line_items do@@ -27,7 +29,7 @@ module Spree# numericality: :less_than_or_equal_to validation is due to the restriction at the database level# https://github.com/spree/spree/issues/2695#issuecomment-143314161validates :quantity, numericality: {- less_than_or_equal_to: DatabaseTypeUtilities.maximum_value_for(:integer),+ in: 0..DatabaseTypeUtilities.maximum_value_for(:integer),only_integer: true, message: Spree.t('validation.must_be_int')}diff --git a/core/spec/models/spree/line_item_spec.rb b/core/spec/models/spree/line_item_spec.rbindex 31904a5228..4c78917743 100644--- a/core/spec/models/spree/line_item_spec.rb+++ b/core/spec/models/spree/line_item_spec.rb@@ -25,6 +25,18 @@ describe Spree::LineItem, type: :model doendend+ describe '#quantity' do+ it 'has a default quantity of 1' do+ line_item = build(:line_item)+ expect(line_item.quantity).to eq(1)+ end++ it 'allows to set different value for quantity' do+ line_item = build(:line_item, quantity: 5)+ expect(line_item.quantity).to eq(5)+ end+ end+describe '#ensure_valid_quantity' docontext 'quantity.nil?' dobefore do