Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Destroy Page Links when Linkable object is destroyed (#13101)
Damian Legawiec55570bdc4bdf
diff --git a/core/app/models/concerns/spree/linkable.rb b/core/app/models/concerns/spree/linkable.rbnew file mode 100644index 0000000000..0f2f1d9d30--- /dev/null+++ b/core/app/models/concerns/spree/linkable.rb@@ -0,0 +1,9 @@+module Spree+ module Linkable+ extend ActiveSupport::Concern++ included do+ has_many :page_links, as: :linkable, class_name: 'Spree::PageLink', dependent: :destroy+ end+ end+enddiff --git a/core/app/models/spree/page.rb b/core/app/models/spree/page.rbindex 44fc4c306e..9a7b07358c 100644--- a/core/app/models/spree/page.rb+++ b/core/app/models/spree/page.rb@@ -1,6 +1,7 @@module Spreeclass Page < Spree.base_classinclude Spree::Previewable+ include Spree::Linkable## Magic methodsdiff --git a/core/app/models/spree/policy.rb b/core/app/models/spree/policy.rbindex 7b11da24e8..c021db3f72 100644--- a/core/app/models/spree/policy.rb+++ b/core/app/models/spree/policy.rb@@ -2,6 +2,7 @@ module Spreeclass Policy < Spree.base_classextend FriendlyIdinclude Spree::TranslatableResource+ include Spree::LinkableUNIQUENESS_SCOPE = %i[owner_id owner_type].freezediff --git a/core/app/models/spree/post.rb b/core/app/models/spree/post.rbindex 3e1a294e61..e39b9e1896 100644--- a/core/app/models/spree/post.rb+++ b/core/app/models/spree/post.rb@@ -1,6 +1,7 @@module Spreeclass Post < Spree.base_classinclude Spree::SingleStoreResource+ include Spree::Linkableextend FriendlyIdfriendly_id :slug_candidates, use: %i[slugged scoped history], scope: %i[store_id deleted?]diff --git a/core/app/models/spree/product.rb b/core/app/models/spree/product.rbindex e7c83816a7..f69683a216 100644--- a/core/app/models/spree/product.rb+++ b/core/app/models/spree/product.rb@@ -29,6 +29,7 @@ module Spreeinclude Spree::TranslatableResourceinclude Spree::MemoizedDatainclude Spree::Metadata+ include Spree::Linkableinclude Spree::Product::Webhooksinclude Spree::Product::Slugsif defined?(Spree::VendorConcern)diff --git a/core/app/models/spree/taxon.rb b/core/app/models/spree/taxon.rbindex 3ae6b1a0e0..5114210ab1 100644--- a/core/app/models/spree/taxon.rb+++ b/core/app/models/spree/taxon.rb@@ -18,6 +18,7 @@ module Spreeinclude Spree::TranslatableResourceSluginclude Spree::Metadatainclude Spree::MemoizedData+ include Spree::Linkableif defined?(Spree::Webhooks::HasWebhooks)include Spree::Webhooks::HasWebhooksenddiff --git a/core/spec/models/spree/policy_spec.rb b/core/spec/models/spree/policy_spec.rbindex 77941e75d0..cecb406ca4 100644--- a/core/spec/models/spree/policy_spec.rb+++ b/core/spec/models/spree/policy_spec.rb@@ -4,7 +4,7 @@ RSpec.describe Spree::Policy, type: :model dolet(:store) { Spree::Store.default }let(:policy) { create(:policy, owner: store) }- describe 'validations' do+ describe 'Validations' docontext 'slug uniqueness' dobefore { policy }@@ -23,6 +23,18 @@ RSpec.describe Spree::Policy, type: :model doendend+ describe 'Callbacks' do+ context 'after destroy destroys links in which policy is linked to' do+ let!(:page_link) { create(:page_link, linkable: policy, parent: store) }++ it 'destroys links' do+ expect(store.links).to include(page_link)+ expect { policy.destroy }.to change(Spree::PageLink, :count).by(-1)+ expect(store.links).not_to include(page_link)+ end+ end+ end+describe 'friendly_id' doit 'generates friendly URLs from slug' dopolicy = create(:policy, slug: 'my-policy')@@ -38,7 +50,7 @@ RSpec.describe Spree::Policy, type: :model doendend- describe 'translations' do+ describe 'Translations' doit 'has translatable name field' doexpect(described_class::TRANSLATABLE_FIELDS).to include(:name)end@@ -60,7 +72,7 @@ RSpec.describe Spree::Policy, type: :model doendend- describe 'scopes' do+ describe 'Scopes' dodescribe '.for_store' dolet(:other_store) { create(:store) }let!(:store1_policy) { create(:policy, owner: store) }