Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Fix: nullify posts after destroying post category (#13277)
Damian Legawiec57470682b078
diff --git a/core/app/models/spree/post.rb b/core/app/models/spree/post.rbindex cdab0c3014..ba740e79f6 100644--- a/core/app/models/spree/post.rb+++ b/core/app/models/spree/post.rb@@ -39,8 +39,8 @@ module Spree# Associations#belongs_to :author, class_name: Spree.admin_user_class.to_s, optional: true- belongs_to :store, class_name: 'Spree::Store'- belongs_to :post_category, class_name: 'Spree::PostCategory', optional: true+ belongs_to :store, class_name: 'Spree::Store', inverse_of: :posts+ belongs_to :post_category, class_name: 'Spree::PostCategory', optional: true, touch: true, inverse_of: :postsalias category post_category#diff --git a/core/app/models/spree/post_category.rb b/core/app/models/spree/post_category.rbindex e08ccf314e..a7c8a7a8a4 100644--- a/core/app/models/spree/post_category.rb+++ b/core/app/models/spree/post_category.rb@@ -9,8 +9,8 @@ module Spree## Associations#- belongs_to :store, class_name: 'Spree::Store'- has_many :posts, class_name: 'Spree::Post'+ belongs_to :store, class_name: 'Spree::Store', inverse_of: :post_categories+ has_many :posts, class_name: 'Spree::Post', dependent: :nullify, inverse_of: :post_category## Validations@@ -18,8 +18,16 @@ module Spreevalidates :title, :store, presence: truevalidates :slug, presence: true, uniqueness: { scope: :store_id }+ #+ # ActionText+ #has_rich_text :description+ #+ # Ransack+ #+ self.whitelisted_ransackable_attributes = %w[title slug]+def should_generate_new_friendly_id?slug.blank? || title_changed?enddiff --git a/core/app/models/spree/store.rb b/core/app/models/spree/store.rbindex 229b2d3c1b..97b435ca9a 100644--- a/core/app/models/spree/store.rb+++ b/core/app/models/spree/store.rb@@ -106,8 +106,8 @@ module Spreehas_many :custom_domains, class_name: 'Spree::CustomDomain', dependent: :destroyhas_one :default_custom_domain, -> { where(default: true) }, class_name: 'Spree::CustomDomain'- has_many :posts, class_name: 'Spree::Post'- has_many :post_categories, class_name: 'Spree::PostCategory'+ has_many :posts, class_name: 'Spree::Post', dependent: :destroy, inverse_of: :store+ has_many :post_categories, class_name: 'Spree::PostCategory', dependent: :destroy, inverse_of: :storehas_many :integrations, class_name: 'Spree::Integration'diff --git a/core/spec/models/spree/post_category_spec.rb b/core/spec/models/spree/post_category_spec.rbnew file mode 100644index 0000000000..53bdca3c90--- /dev/null+++ b/core/spec/models/spree/post_category_spec.rb@@ -0,0 +1,57 @@+require 'spec_helper'++RSpec.describe Spree::PostCategory, type: :model do+ let(:post_category) { build(:post_category) }++ context 'Associations' do+ describe 'posts' do+ it 'has many posts' do+ post1 = create(:post, post_category: post_category)+ post2 = create(:post, post_category: post_category)++ expect(post_category.posts).to include(post1, post2)+ end++ it 'nullifies posts when destroyed' do+ post = create(:post, post_category: post_category)++ post_category.destroy+ post.reload++ expect(post.post_category).to be_nil+ end+ end+ end++ describe 'FriendlyId' do+ before do+ post_category.save!+ end++ describe '#should_generate_new_friendly_id?' do+ it 'returns true when slug is blank' do+ post_category.slug = nil+ expect(post_category.should_generate_new_friendly_id?).to be true+ end++ it 'returns true when title has changed' do+ post_category.title = 'New Title'+ expect(post_category.should_generate_new_friendly_id?).to be true+ end++ it 'returns false when slug is present and title unchanged' do+ expect(post_category.should_generate_new_friendly_id?).to be false+ end+ end++ describe '#slug_candidates' do+ it 'returns correct slug candidates' do+ expected_candidates = [+ :title,+ [:title, :id]+ ]+ expect(post_category.slug_candidates).to eq(expected_candidates)+ end+ end+ end+end