Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Ensure that the Order number is uppercase
Damian Legawiec5aa0abe93830
diff --git a/core/app/models/spree/order.rb b/core/app/models/spree/order.rbindex b802db7231..c81cfe1457 100644--- a/core/app/models/spree/order.rb+++ b/core/app/models/spree/order.rb@@ -121,6 +121,8 @@ module Spree# Needs to happen before save_permalink is calledbefore_validation :ensure_store_presencebefore_validation :ensure_currency_presence+ before_validation :uppercase_number+before_validation :clone_billing_address, if: :use_billing?attr_accessor :use_billing@@ -129,6 +131,8 @@ module Spreebefore_update :homogenize_line_item_currencies, if: :currency_changed?with_options presence: true do+ # we want to have this case_sentive: true as changing it to false causes all SQL to use LOWER(slug)+ # which is very costly and slow on large set of recordsvalidates :number, length: { maximum: 32, allow_blank: true }, uniqueness: { allow_blank: true, case_sensitive: true }validates :email, length: { maximum: 254, allow_blank: true }, email: { allow_blank: true }, if: :require_emailvalidates :item_count, numericality: { greater_than_or_equal_to: 0, less_than: 2**31, only_integer: true, allow_blank: true }@@ -739,5 +743,9 @@ module SpreeOrderMailer.store_owner_notification_email(id).deliver_laterupdate_column(:store_owner_notification_delivered, true)end++ def uppercase_number+ number&.upcase!+ endendenddiff --git a/core/spec/models/spree/order_spec.rb b/core/spec/models/spree/order_spec.rbindex f7fe8d30b0..062a1febb5 100644--- a/core/spec/models/spree/order_spec.rb+++ b/core/spec/models/spree/order_spec.rb@@ -1415,4 +1415,10 @@ describe Spree::Order, type: :model doit { is_expected.to be false }endend++ describe '#uppercase_number' do+ let(:order) { build(:order, number: 'r1234') }++ it { expect { order.valid? }.to change(order, :number).to('R1234') }+ endend