Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Bring back page links counter cache, add it to Store as well (#13102)

Damian Legawiec5dbabbce0938
diff --git a/api/spec/serializers/spree/api/v2/platform/store_serializer_spec.rb b/api/spec/serializers/spree/api/v2/platform/store_serializer_spec.rb
index cfb7263751..dcb7263569 100644
--- a/api/spec/serializers/spree/api/v2/platform/store_serializer_spec.rb
+++ b/api/spec/serializers/spree/api/v2/platform/store_serializer_spec.rb
@@ -50,7 +50,8 @@ describe Spree::Api::V2::Platform::StoreSerializer do
favicon_path: nil,
storefront_custom_code_body_end: nil,
storefront_custom_code_body_start: nil,
- storefront_custom_code_head: nil
+ storefront_custom_code_head: nil,
+ page_links_count: store.page_links_count
},
relationships: {
default_country: {
diff --git a/core/app/models/spree/page.rb b/core/app/models/spree/page.rb
index 9a7b07358c..c840afdad9 100644
--- a/core/app/models/spree/page.rb
+++ b/core/app/models/spree/page.rb
@@ -15,7 +15,6 @@ module Spree
#
belongs_to :pageable, polymorphic: true # this can be either Store or Theme
has_many :sections, -> { order(position: :asc) }, class_name: 'Spree::PageSection', dependent: :destroy_async, as: :pageable
- has_many :page_links, as: :linkable, class_name: 'Spree::PageLink', dependent: :destroy
alias page_sections sections
#
diff --git a/core/app/models/spree/page_link.rb b/core/app/models/spree/page_link.rb
index f8bf214932..ceba49e20e 100644
--- a/core/app/models/spree/page_link.rb
+++ b/core/app/models/spree/page_link.rb
@@ -8,7 +8,7 @@ module Spree
#
# Associations
#
- belongs_to :parent, polymorphic: true, touch: true # Block or Section
+ belongs_to :parent, polymorphic: true, touch: true, counter_cache: true # Block or Section
belongs_to :linkable, polymorphic: true, optional: true # Page, Product, etc.
has_one :theme, through: :parent
diff --git a/core/app/models/spree/product.rb b/core/app/models/spree/product.rb
index f69683a216..117250aac3 100644
--- a/core/app/models/spree/product.rb
+++ b/core/app/models/spree/product.rb
@@ -119,8 +119,6 @@ module Spree
has_many :stores, through: :store_products, class_name: 'Spree::Store'
has_many :digitals, through: :variants_including_master
- has_many :page_links, as: :linkable, class_name: 'Spree::PageLink', dependent: :destroy
-
after_initialize :ensure_master
after_initialize :assign_default_tax_category
diff --git a/core/app/models/spree/taxon.rb b/core/app/models/spree/taxon.rb
index 5114210ab1..f97cf4409f 100644
--- a/core/app/models/spree/taxon.rb
+++ b/core/app/models/spree/taxon.rb
@@ -47,8 +47,6 @@ module Spree
has_many :promotion_rule_taxons, class_name: 'Spree::PromotionRuleTaxon', dependent: :destroy
has_many :promotion_rules, through: :promotion_rule_taxons, class_name: 'Spree::PromotionRule'
- has_many :page_links, as: :linkable, class_name: 'Spree::PageLink', dependent: :destroy
-
#
# Attachments
#
diff --git a/core/db/migrate/20250913130044_add_page_links_counter_cache_to_spree_stores.rb b/core/db/migrate/20250913130044_add_page_links_counter_cache_to_spree_stores.rb
new file mode 100644
index 0000000000..5422206784
--- /dev/null
+++ b/core/db/migrate/20250913130044_add_page_links_counter_cache_to_spree_stores.rb
@@ -0,0 +1,10 @@
+class AddPageLinksCounterCacheToSpreeStores < ActiveRecord::Migration[7.2]
+ def change
+ add_column :spree_stores, :page_links_count, :integer, default: 0, null: false
+
+ Spree::Store.reset_column_information
+ Spree::Store.find_each do |store|
+ Spree::Store.reset_counters(store.id, :page_links)
+ end
+ end
+end