Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Fix bulk product status dialog showing raw status value in trigger (#14275)
Damian Legawiec5dd5515c33fe
diff --git a/packages/dashboard/e2e/products-bulk.spec.ts b/packages/dashboard/e2e/products-bulk.spec.tsindex 502f201060..13e849a1c0 100644--- a/packages/dashboard/e2e/products-bulk.spec.ts+++ b/packages/dashboard/e2e/products-bulk.spec.ts@@ -65,6 +65,12 @@ test.describe('products bulk operations', () => {await page.getByRole('combobox').click()await page.getByRole('option', { name: /^archived$/i }).click()++ // Regression guard: the trigger must render the translated label ("Archived"),+ // not the raw status value ("archived"). Base UI's <SelectValue> only resolves+ // the label when the <Select> is given an `items` array.+ await expect(page.getByRole('combobox')).toHaveText('Archived')+await page.getByRole('dialog').getByRole('button', { name: /^apply$/i })diff --git a/packages/dashboard/src/routes/_authenticated/$storeId/products/index.tsx b/packages/dashboard/src/routes/_authenticated/$storeId/products/index.tsxindex efdaaf4a1c..9cb55c9f3d 100644--- a/packages/dashboard/src/routes/_authenticated/$storeId/products/index.tsx+++ b/packages/dashboard/src/routes/_authenticated/$storeId/products/index.tsx@@ -342,10 +342,17 @@ function ProductRowActions({ product, storeId }: { product: Product; storeId: st)}+const PRODUCT_STATUSES: ProductStatus[] = ['draft', 'active', 'archived']+function StatusPickerSheet({ onSubmit, onCancel }: BulkActionFormProps<StatusFormValues>) {const { t } = useTranslation()const [status, setStatus] = useState<ProductStatus>('active')+ const statusItems = PRODUCT_STATUSES.map((value) => ({+ value,+ label: t(`admin.pages.products.status_options.${value}`),+ }))+return (<BulkDialogtitle={t('admin.pages.products.bulk.status_sheet_title')}@@ -356,16 +363,20 @@ function StatusPickerSheet({ onSubmit, onCancel }: BulkActionFormProps<StatusFor><Field><FieldLabel>{t('admin.fields.status.label')}</FieldLabel>- <Select value={status} onValueChange={(v) => setStatus(v as ProductStatus)}>+ <Select+ items={statusItems}+ value={status}+ onValueChange={(v) => setStatus(v as ProductStatus)}+ ><SelectTrigger><SelectValue /></SelectTrigger><SelectContent>- <SelectItem value="draft">{t('admin.pages.products.status_options.draft')}</SelectItem>- <SelectItem value="active">{t('admin.fields.active.label')}</SelectItem>- <SelectItem value="archived">- {t('admin.pages.products.status_options.archived')}- </SelectItem>+ {statusItems.map((item) => (+ <SelectItem key={item.value} value={item.value}>+ {item.label}+ </SelectItem>+ ))}</SelectContent></Select></Field>