Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

cache single Option Type filters

Łukasz Adamczyk5f23695e3a81
diff --git a/frontend/app/helpers/spree/frontend_helper.rb b/frontend/app/helpers/spree/frontend_helper.rb
index fe044dbb6f..5fc322b090 100644
--- a/frontend/app/helpers/spree/frontend_helper.rb
+++ b/frontend/app/helpers/spree/frontend_helper.rb
@@ -294,6 +294,16 @@ module Spree
end
end
+ def option_type_cache_key(ot_filter_param)
+ filtered_params = params[ot_filter_param]
+
+ [
+ available_option_types_cache_key,
+ ot_filter_param,
+ filtered_params
+ ]
+ end
+
def available_option_types_cache_key
@available_option_types_cache_key ||= [
Spree::OptionType.filterable.maximum(:updated_at).to_f,
diff --git a/frontend/app/views/spree/products/_filters_desktop.html.erb b/frontend/app/views/spree/products/_filters_desktop.html.erb
index 013498df91..a4ba6786c9 100644
--- a/frontend/app/views/spree/products/_filters_desktop.html.erb
+++ b/frontend/app/views/spree/products/_filters_desktop.html.erb
@@ -5,9 +5,9 @@
<div class="plp-filters-scroller">
<% available_option_types.each do |option_type| %>
<div class="w-100 card plp-filters-card">
- <% ot_downcase_name = option_type.filter_param %>
- <% option_type_name = ot_downcase_name.titleize %>
- <% collapsed = params[ot_downcase_name].blank? %>
+ <% ot_filter_param = option_type.filter_param %>
+ <% option_type_name = ot_filter_param.titleize %>
+ <% collapsed = params[ot_filter_param].blank? %>
<button class="card-header <%= 'collapsed' if collapsed %> px-1 plp-filters-card-header" id="filters<%= option_type_name %>" data-toggle="collapse" data-target="#collapseFilter<%= option_type_name %>" aria-expanded="<%= !collapsed %>" aria-controls="collapseFilter<%= option_type_name %>" role="heading" aria-level="2">
<%= option_type.presentation %>
@@ -23,10 +23,8 @@
<div id="collapseFilter<%= option_type_name %>" class="collapse <%= 'show' unless collapsed %>" aria-labelledby="filters<%= option_type_name %>">
<div class="card-body px-0 pt-1">
<%= render 'spree/shared/option_values',
- params_ot_downcase_name: params[ot_downcase_name],
option_type: option_type,
- permitted_params: permitted_params,
- ot_downcase_name: ot_downcase_name %>
+ permitted_params: permitted_params %>
</div>
</div>
</div>
diff --git a/frontend/app/views/spree/shared/_option_values.html.erb b/frontend/app/views/spree/shared/_option_values.html.erb
index 1dbb532a2b..a86eedc8a5 100644
--- a/frontend/app/views/spree/shared/_option_values.html.erb
+++ b/frontend/app/views/spree/shared/_option_values.html.erb
@@ -1,3 +1,5 @@
-<% option_type.option_values.each do |option_value| %>
- <%= option_value_filter_link(option_value, permitted_params) %>
+<% cache option_type_cache_key(option_type.filter_param) do %>
+ <% option_type.option_values.each do |option_value| %>
+ <%= option_value_filter_link(option_value, permitted_params) %>
+ <% end %>
<% end %>