Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Admin: Remove `responders` from dependencies (#12444)

Damian Legawiec600d98eee418
diff --git a/admin/app/controllers/spree/admin/reports_controller.rb b/admin/app/controllers/spree/admin/reports_controller.rb
index 5eb46e73e5..d06abc94f1 100644
--- a/admin/app/controllers/spree/admin/reports_controller.rb
+++ b/admin/app/controllers/spree/admin/reports_controller.rb
@@ -3,8 +3,6 @@ module Spree
class ReportsController < ResourceController
include ActiveStorage::SetCurrent
- respond_to :html, :csv
-
before_action :set_user, only: [:new, :create]
def show
diff --git a/admin/app/controllers/spree/admin/resource_controller.rb b/admin/app/controllers/spree/admin/resource_controller.rb
index 53d2973588..d96959d162 100644
--- a/admin/app/controllers/spree/admin/resource_controller.rb
+++ b/admin/app/controllers/spree/admin/resource_controller.rb
@@ -8,8 +8,6 @@ class Spree::Admin::ResourceController < Spree::Admin::BaseController
rescue_from ActiveRecord::RecordNotFound, with: :resource_not_found
- respond_to :html
-
def new
invoke_callbacks(:new_action, :before)
end
@@ -25,7 +23,7 @@ class Spree::Admin::ResourceController < Spree::Admin::BaseController
remove_assets(%w[asset image square_image])
invoke_callbacks(:update, :after)
- respond_with(@object) do |format|
+ respond_to do |format|
if update_turbo_stream_enabled?
format.turbo_stream do
flash.now[:success] = message_after_update
@@ -38,7 +36,7 @@ class Spree::Admin::ResourceController < Spree::Admin::BaseController
end
else
invoke_callbacks(:update, :fails)
- respond_with(@object) do |format|
+ respond_to do |format|
if update_turbo_stream_enabled?
format.turbo_stream do
flash.now[:error] = @object.errors.full_messages.join(', ')
@@ -54,7 +52,7 @@ class Spree::Admin::ResourceController < Spree::Admin::BaseController
@object.attributes = permitted_resource_params
if @object.save
invoke_callbacks(:create, :after)
- respond_with(@object) do |format|
+ respond_to do |format|
if create_turbo_stream_enabled?
format.turbo_stream do
flash.now[:success] = message_after_create
@@ -67,7 +65,7 @@ class Spree::Admin::ResourceController < Spree::Admin::BaseController
end
else
invoke_callbacks(:create, :fails)
- respond_with(@object) do |format|
+ respond_to do |format|
if create_turbo_stream_enabled?
format.turbo_stream do
flash.now[:error] = @object.errors.full_messages.join(', ')
diff --git a/admin/lib/spree/admin.rb b/admin/lib/spree/admin.rb
index 4bf78912b7..de6a3e82db 100644
--- a/admin/lib/spree/admin.rb
+++ b/admin/lib/spree/admin.rb
@@ -18,7 +18,6 @@ require 'inline_svg'
require 'local_time'
require 'payment_icons'
require 'dartsass-rails'
-require 'responders'
require 'tinymce-rails'
require 'oembed'
diff --git a/admin/spree_admin.gemspec b/admin/spree_admin.gemspec
index 7a7d997d06..60429a06fd 100644
--- a/admin/spree_admin.gemspec
+++ b/admin/spree_admin.gemspec
@@ -44,7 +44,6 @@ Gem::Specification.new do |s|
s.add_dependency 'payment_icons'
s.add_dependency 'turbo-rails'
s.add_dependency 'stimulus-rails'
- s.add_dependency 'responders'
s.add_dependency 'sprockets', '>= 4.0'
s.add_dependency 'tinymce-rails', '~> 7.0'
s.add_dependency 'ruby-oembed', '~> 0.18'