Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Fix flaky by_best_selling scope test with tied products (#13548)
Damian Legawiec61e2c5a6a374
diff --git a/core/spec/models/spree/product/scopes_spec.rb b/core/spec/models/spree/product/scopes_spec.rbindex a6ea17230a..1108e2de71 100644--- a/core/spec/models/spree/product/scopes_spec.rb+++ b/core/spec/models/spree/product/scopes_spec.rb@@ -548,8 +548,9 @@ describe 'Product scopes', type: :model doproducts = Spree::Product.where(id: test_product_ids).by_best_selling# Product 1: 2 units sold (first)# Product 3: 1 unit sold (second)- # Product 2 & 4: 0 units sold (last, but Product 2 still included despite having pending orders)- expect(products.map(&:name)).to eq(['Product 1', 'Product 3', 'Product 2', 'Product 4'])+ # Product 2 & 4: 0 units sold (last, order between them is non-deterministic)+ expect(products.first(2).map(&:name)).to eq(['Product 1', 'Product 3'])+ expect(products.last(2).map(&:name)).to contain_exactly('Product 2', 'Product 4')endendend