Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Stop the order name search comparing an unordered result by position

Damian Legawiec625848aed1b2
diff --git a/spree/core/spec/models/spree/order_spec.rb b/spree/core/spec/models/spree/order_spec.rb
index 3808815704..58e4b372da 100644
--- a/spree/core/spec/models/spree/order_spec.rb
+++ b/spree/core/spec/models/spree/order_spec.rb
@@ -99,7 +99,10 @@ describe Spree::Order, type: :model do
expect(described_class.search('don ro')).to eq([order_1])
expect(described_class.search('ane gon')).to eq([order_2])
expect(described_class.search('mary moe')).to eq([order_3])
- expect(described_class.search('jane moe')).to eq([order_2, order_3])
+ # `match_array`, not `eq`: the scope carries no ORDER BY, so PostgreSQL
+ # is free to return these two rows either way round and an ordered
+ # comparison fails intermittently on the same records transposed.
+ expect(described_class.search('jane moe')).to match_array([order_2, order_3])
expect(described_class.search('greg smith')).to eq([])
end
end