Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Added FIXME's for future developments

Damian Legawiec631caaa9ac47
diff --git a/core/app/models/concerns/spree/user_address.rb b/core/app/models/concerns/spree/user_address.rb
index 3630e3826f..7078115ea6 100644
--- a/core/app/models/concerns/spree/user_address.rb
+++ b/core/app/models/concerns/spree/user_address.rb
@@ -19,6 +19,9 @@ module Spree
validate :address_not_associated_with_other_user, :address_not_deprecated_in_completed_order
def persist_order_address(order)
+ # FIXME: we should check if the User's address is associated with country accepted by Store
+ # if not we should try to find an address with valid country in User's address book
+ # or we should call `build_bill_address`
b_address = bill_address || build_bill_address
b_address.attributes = order.bill_address.value_attributes
b_address.save
diff --git a/core/app/models/spree/order/address_book.rb b/core/app/models/spree/order/address_book.rb
index 78334c8375..6d7d6dc15e 100644
--- a/core/app/models/spree/order/address_book.rb
+++ b/core/app/models/spree/order/address_book.rb
@@ -2,7 +2,7 @@
module Spree
class Order < Spree::Base
module AddressBook
- extend ActiveSupport::Concern
+ extend ActiveSupport::Concern # FIXME: this module is not required to be a concern
def clone_shipping_address
if ship_address
diff --git a/core/app/models/spree/order/currency_updater.rb b/core/app/models/spree/order/currency_updater.rb
index 789a5329d1..5b39e92037 100644
--- a/core/app/models/spree/order/currency_updater.rb
+++ b/core/app/models/spree/order/currency_updater.rb
@@ -1,7 +1,7 @@
module Spree
class Order < Spree::Base
module CurrencyUpdater
- extend ActiveSupport::Concern
+ extend ActiveSupport::Concern # FIXME: this module is not required to be a concern
included do
def homogenize_line_item_currencies
diff --git a/core/app/models/spree/order/payments.rb b/core/app/models/spree/order/payments.rb
index 2420af9bd1..0ffe3cef10 100644
--- a/core/app/models/spree/order/payments.rb
+++ b/core/app/models/spree/order/payments.rb
@@ -1,7 +1,7 @@
module Spree
class Order < Spree::Base
module Payments
- extend ActiveSupport::Concern
+ extend ActiveSupport::Concern # FIXME: this module is not required to be a concern
included do
# processes any pending payments and must return a boolean as it's
# return value is used by the checkout state_machine to determine