Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Remove `inline_svg` dependency (#12581)

Damian Legawiec636df96273f2
diff --git a/admin/lib/spree/admin.rb b/admin/lib/spree/admin.rb
index 757cc868b4..51ae985d52 100644
--- a/admin/lib/spree/admin.rb
+++ b/admin/lib/spree/admin.rb
@@ -14,7 +14,6 @@ require 'mapkick-rb'
require 'bootstrap'
require 'turbo-rails'
require 'stimulus-rails'
-require 'inline_svg'
require 'local_time'
require 'payment_icons'
require 'dartsass-rails'
diff --git a/admin/spree_admin.gemspec b/admin/spree_admin.gemspec
index a9cd6c3c0c..b9957b49ab 100644
--- a/admin/spree_admin.gemspec
+++ b/admin/spree_admin.gemspec
@@ -38,7 +38,6 @@ Gem::Specification.new do |s|
s.add_dependency 'groupdate', '~> 6.2'
s.add_dependency 'hightop', '~> 0.3'
s.add_dependency 'importmap-rails'
- s.add_dependency 'inline_svg', '~> 1.5'
s.add_dependency 'local_time', '~> 3.0'
s.add_dependency 'mapkick-rb', '~> 0.1'
s.add_dependency 'payment_icons'
diff --git a/core/app/helpers/spree/base_helper.rb b/core/app/helpers/spree/base_helper.rb
index f7e47b9f24..03b31afc0f 100644
--- a/core/app/helpers/spree/base_helper.rb
+++ b/core/app/helpers/spree/base_helper.rb
@@ -264,7 +264,9 @@ module Spree
img = if image_path.present?
create_product_image_tag image_path, product, options, style
else
- inline_svg_tag 'noimage/backend-missing-image.svg', class: 'noimage', size: '60%*60%'
+ width = style.to_s.split('x').first.to_i
+ height = style.to_s.split('x').last.to_i
+ content_tag(:div, width: width, height: height, style: "background-color: #f0f0f0;")
end
content_tag(:div, img, class: "admin-product-image-container #{style}-img")
diff --git a/core/spec/helpers/base_helper_spec.rb b/core/spec/helpers/base_helper_spec.rb
index f9f4d41493..166dcffc35 100644
--- a/core/spec/helpers/base_helper_spec.rb
+++ b/core/spec/helpers/base_helper_spec.rb
@@ -136,8 +136,6 @@ describe Spree::BaseHelper, type: :helper do
end
Spree::Image.prepend(ImageDecorator)
-
- allow_any_instance_of(described_class).to receive(:inline_svg_tag).and_return('<svg></svg>')
end
it 'does not raise errors when style exists' do
diff --git a/storefront/lib/spree/storefront.rb b/storefront/lib/spree/storefront.rb
index 010d96ea50..18ca6a60e5 100644
--- a/storefront/lib/spree/storefront.rb
+++ b/storefront/lib/spree/storefront.rb
@@ -6,7 +6,6 @@ require 'active_link_to'
require 'canonical-rails'
require 'heroicon'
require 'importmap-rails'
-require 'inline_svg'
require 'local_time'
require 'mail_form'
require 'payment_icons'
diff --git a/storefront/spree_storefront.gemspec b/storefront/spree_storefront.gemspec
index 5b51160c19..37b69a353b 100644
--- a/storefront/spree_storefront.gemspec
+++ b/storefront/spree_storefront.gemspec
@@ -30,7 +30,6 @@ Gem::Specification.new do |s|
s.add_dependency 'canonical-rails', '~> 0.2.14'
s.add_dependency 'heroicon'
s.add_dependency 'importmap-rails'
- s.add_dependency 'inline_svg', '~> 1.5'
s.add_dependency 'local_time', '~> 3.0'
s.add_dependency 'mail_form'
s.add_dependency 'payment_icons'