Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Use native rails `dependent: :destroy` for Line Items inventory units… (#13108)

Damian Legawiec63b00b282701
diff --git a/core/app/models/spree/line_item.rb b/core/app/models/spree/line_item.rb
index bd161655c6..98e089f2cd 100644
--- a/core/app/models/spree/line_item.rb
+++ b/core/app/models/spree/line_item.rb
@@ -18,7 +18,7 @@ module Spree
has_one :product, -> { with_deleted }, class_name: 'Spree::Product', through: :variant
has_many :adjustments, as: :adjustable, dependent: :destroy
- has_many :inventory_units, inverse_of: :line_item
+ has_many :inventory_units, class_name: 'Spree::InventoryUnit', inverse_of: :line_item, dependent: :destroy
has_many :shipments, through: :inventory_units, source: :shipment
has_many :digital_links, dependent: :destroy
@@ -41,8 +41,6 @@ module Spree
before_destroy :verify_order_inventory_before_destroy, if: -> { order.has_checkout_step?('delivery') }
- before_destroy :destroy_inventory_units
-
after_save :update_inventory
after_save :update_adjustments
@@ -226,10 +224,6 @@ module Spree
Spree::OrderInventory.new(order, self).verify(target_shipment)
end
- def destroy_inventory_units
- throw(:abort) unless inventory_units.destroy_all
- end
-
def update_adjustments
if saved_change_to_quantity?
recalculate_adjustments