Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Update specs

Łukasz Adamczyk6406f2cb3370
diff --git a/admin/spec/controllers/spree/admin/orders_controller_spec.rb b/admin/spec/controllers/spree/admin/orders_controller_spec.rb
index c7d16c0048..d0d17abbb9 100644
--- a/admin/spec/controllers/spree/admin/orders_controller_spec.rb
+++ b/admin/spec/controllers/spree/admin/orders_controller_spec.rb
@@ -24,12 +24,12 @@ RSpec.describe Spree::Admin::OrdersController, type: :controller do
end
describe '#index' do
- let!(:shipped_order) { create(:shipped_order) }
- let!(:order) { create(:completed_order_with_totals, line_items_count: 2) }
+ let!(:shipped_order) { create(:shipped_order, with_payment: false, total: 100) }
+ let!(:order) { create(:completed_order_with_totals, line_items_count: 2, total: 100) }
let(:line_item) { order.line_items.first }
- let!(:cancelled_order) { create(:completed_order_with_totals, state: 'canceled') }
+ let!(:cancelled_order) { create(:completed_order_with_totals, state: 'canceled', total: 100) }
let!(:payment) { create(:payment, state: 'completed', amount: shipped_order.total, order: shipped_order) }
- let!(:cancelled_order_payment) { create(:payment, state: 'completed', amount: shipped_order.total, order: cancelled_order) }
+ let!(:cancelled_order_payment) { create(:payment, state: 'completed', amount: cancelled_order.total, order: cancelled_order) }
let!(:refund) { create(:refund, payment: payment, amount: payment.amount) }
let!(:payment_one) { create(:payment, state: 'completed', amount: order.total, order: order) }
let!(:partial_refund) { create(:refund, payment: payment_one, amount: (payment_one.amount - 10)) }
diff --git a/admin/spec/controllers/spree/admin/refunds_controller_spec.rb b/admin/spec/controllers/spree/admin/refunds_controller_spec.rb
index aea0ceff71..41502d83be 100644
--- a/admin/spec/controllers/spree/admin/refunds_controller_spec.rb
+++ b/admin/spec/controllers/spree/admin/refunds_controller_spec.rb
@@ -23,7 +23,7 @@ describe Spree::Admin::RefundsController, type: :controller do
let!(:refund_reason) { create(:refund_reason) }
let(:payment) { create(:payment, amount: payment_amount, order: create(:completed_order_with_totals)) }
let(:payment_amount) { amount * 2 }
- let(:amount) { 100.0 }
+ let(:amount) { 10.0 }
let(:amount_in_cents) { amount * 100 }
let(:authorization) { generate(:refund_transaction_id) }
diff --git a/api/spec/integration/api/v2/platform/payments_spec.rb b/api/spec/integration/api/v2/platform/payments_spec.rb
index 5f294a73f3..c3ccf6194b 100644
--- a/api/spec/integration/api/v2/platform/payments_spec.rb
+++ b/api/spec/integration/api/v2/platform/payments_spec.rb
@@ -11,7 +11,7 @@ describe 'Payments API', swagger: true do
}
let(:id) { create(:payment, payment_method: payment_method, order: order).id }
- let(:order) { create(:order, store: store) }
+ let(:order) { create(:order, store: store, total: 200) }
let(:payment_method) { create(:credit_card_payment_method, stores: [store]) }
let(:records_list) { create_list(:payment, 2, order: order, payment_method: payment_method) }
let(:valid_create_param_value) { build(:payment, payment_method: payment_method, order: order) }
diff --git a/api/spec/requests/spree/api/v2/platform/number_resources_spec.rb b/api/spec/requests/spree/api/v2/platform/number_resources_spec.rb
index 794c18e641..de61d11927 100644
--- a/api/spec/requests/spree/api/v2/platform/number_resources_spec.rb
+++ b/api/spec/requests/spree/api/v2/platform/number_resources_spec.rb
@@ -5,7 +5,7 @@ describe 'API V2 Number Resources Spec' do
let(:bearer_token) { { 'Authorization' => valid_authorization } }
- let(:order) { create(:order, store: store) }
+ let(:order) { create(:order, store: store, total: 100) }
describe 'orders#show' do
context 'can fetch order by the number' do
diff --git a/core/lib/spree/testing_support/factories/order_factory.rb b/core/lib/spree/testing_support/factories/order_factory.rb
index c63dd0633f..7cb803d908 100644
--- a/core/lib/spree/testing_support/factories/order_factory.rb
+++ b/core/lib/spree/testing_support/factories/order_factory.rb
@@ -95,8 +95,13 @@ FactoryBot.define do
payment_state { 'paid' }
shipment_state { 'ready' }
- after(:create) do |order|
- create(:payment, amount: order.total, order: order, state: 'completed')
+ transient do
+ with_payment { true }
+ end
+
+ after(:create) do |order, evaluator|
+ create(:payment, amount: order.total, order: order, state: 'completed') if evaluator.with_payment
+
order.shipments.each do |shipment|
shipment.inventory_units.update_all state: 'on_hand'
shipment.update_column('state', 'ready')
diff --git a/core/lib/spree/testing_support/factories/payment_factory.rb b/core/lib/spree/testing_support/factories/payment_factory.rb
index b1ad1ef7bb..baed9bcdac 100644
--- a/core/lib/spree/testing_support/factories/payment_factory.rb
+++ b/core/lib/spree/testing_support/factories/payment_factory.rb
@@ -1,6 +1,6 @@
FactoryBot.define do
factory :payment, class: Spree::Payment do
- order { create(:order, total: 45.75) }
+ order { create(:order, total: amount) }
amount { 45.75 }
state { 'checkout' }
response_code { '12345' }
diff --git a/core/spec/lib/spree/core/importer/order_spec.rb b/core/spec/lib/spree/core/importer/order_spec.rb
index 31cef18f8e..ff50d6205d 100644
--- a/core/spec/lib/spree/core/importer/order_spec.rb
+++ b/core/spec/lib/spree/core/importer/order_spec.rb
@@ -488,6 +488,12 @@ module Spree
it 'builds a payment using state' do
params = {
+ line_items_attributes: [
+ {
+ variant_id: variant.id,
+ quantity: 5
+ }
+ ],
payments_attributes: [
{
amount: '4.99',
@@ -502,6 +508,12 @@ module Spree
it 'builds a payment using status as fallback' do
params = {
+ line_items_attributes: [
+ {
+ variant_id: variant.id,
+ quantity: 5
+ }
+ ],
payments_attributes: [
{
amount: '4.99',
@@ -528,6 +540,12 @@ module Spree
it 'build a source payment using years and month' do
params = {
+ line_items_attributes: [
+ {
+ variant_id: variant.id,
+ quantity: 5
+ }
+ ],
payments_attributes: [
{
amount: '4.99',
@@ -571,6 +589,12 @@ module Spree
it 'builds a payment with an optional created_at' do
created_at = 2.days.ago
params = {
+ line_items_attributes: [
+ {
+ variant_id: variant.id,
+ quantity: 5
+ }
+ ],
payments_attributes: [
{
amount: '4.99',
diff --git a/core/spec/models/spree/credit_card_spec.rb b/core/spec/models/spree/credit_card_spec.rb
index b25953fa5c..643e2efa3a 100644
--- a/core/spec/models/spree/credit_card_spec.rb
+++ b/core/spec/models/spree/credit_card_spec.rb
@@ -12,7 +12,7 @@ describe Spree::CreditCard, type: :model do
name: 'Spree Commerce'
}
end
- let(:order) { create(:order) }
+ let(:order) { create(:order, total: 100) }
let(:payment) { create(:payment, amount: 100, order: order) }
let(:payment_method) { create(:payment_method) }
diff --git a/core/spec/models/spree/gateway_spec.rb b/core/spec/models/spree/gateway_spec.rb
index f25dd06e23..b0b3d83a31 100644
--- a/core/spec/models/spree/gateway_spec.rb
+++ b/core/spec/models/spree/gateway_spec.rb
@@ -45,7 +45,7 @@ describe Spree::Gateway, type: :model do
context 'fetching payment sources' do
let(:store) { Spree::Store.default }
- let(:order) { store.orders.create(user_id: 1) }
+ let(:order) { store.orders.create(user_id: 1, total: 100) }
let(:has_card) { create(:credit_card_payment_method, stores: [store]) }
let(:no_card) { create(:credit_card_payment_method, stores: [store]) }
diff --git a/core/spec/models/spree/order/state_machine_spec.rb b/core/spec/models/spree/order/state_machine_spec.rb
index 6b5b030970..57ff5ea0e8 100644
--- a/core/spec/models/spree/order/state_machine_spec.rb
+++ b/core/spec/models/spree/order/state_machine_spec.rb
@@ -14,6 +14,7 @@ describe Spree::Order, type: :model do
context 'when current state is confirm' do
before do
order.state = 'confirm'
+ order.total = 100
order.run_callbacks(:create)
allow(order).to receive_messages payment_required?: true
allow(order).to receive_messages process_payments!: true
diff --git a/core/spec/models/spree/order_contents_spec.rb b/core/spec/models/spree/order_contents_spec.rb
index c40791a1f8..f329022dcb 100644
--- a/core/spec/models/spree/order_contents_spec.rb
+++ b/core/spec/models/spree/order_contents_spec.rb
@@ -59,6 +59,7 @@ describe Spree::OrderContents, type: :model do
end
context 'when store_credits payment' do
+ let(:order) { create(:order, user: user, store: store, total: 100) }
let!(:payment) { create(:store_credit_payment, order: order) }
it { expect { subject.add(variant, 1) }.to change { order.payments.store_credits.count }.by(-1) }
@@ -172,7 +173,8 @@ describe Spree::OrderContents, type: :model do
end
context 'when store_credits payment' do
- let(:payment) { create(:store_credit_payment, order: order) }
+ let(:order) { create(:order, user: user, store: store, total: 100) }
+ let(:payment) { create(:store_credit_payment, amount: 10, order: order) }
before do
subject.add(variant, 1)
@@ -225,7 +227,8 @@ describe Spree::OrderContents, type: :model do
end
context 'when store_credits payment' do
- let(:payment) { create(:store_credit_payment, order: order) }
+ let(:order) { create(:order, user: user, store: store, total: 100) }
+ let(:payment) { create(:store_credit_payment, amount: 10, order: order) }
before do
@line_item = subject.add(variant, 1)
@@ -278,7 +281,8 @@ describe Spree::OrderContents, type: :model do
end
context 'when store_credits payment' do
- let!(:payment) { create(:store_credit_payment, order: order) }
+ let(:order) { create(:order, user: user, store: store, total: 100) }
+ let!(:payment) { create(:store_credit_payment, amount: 10, order: order) }
it { expect { subject.update_cart params }.to change { order.payments.store_credits.count }.by(-1) }
end
diff --git a/core/spec/models/spree/order_updater_spec.rb b/core/spec/models/spree/order_updater_spec.rb
index 862e03e930..66ba5380ec 100644
--- a/core/spec/models/spree/order_updater_spec.rb
+++ b/core/spec/models/spree/order_updater_spec.rb
@@ -9,12 +9,13 @@ module Spree
context 'order totals' do
before do
create_list(:line_item, 2, order: order, price: 10)
+ order.update_with_updater!
end
it 'updates payment totals' do
- create(:payment_with_refund, order: order)
+ create(:payment_with_refund, amount: 20, order: order)
Spree::OrderUpdater.new(order).update_payment_total
- expect(order.payment_total).to eq(40.75)
+ expect(order.payment_total).to eq(15)
end
it 'update item total' do
diff --git a/core/spec/models/spree/payment/store_credit_spec.rb b/core/spec/models/spree/payment/store_credit_spec.rb
index 534f11bfc7..d76ead5353 100644
--- a/core/spec/models/spree/payment/store_credit_spec.rb
+++ b/core/spec/models/spree/payment/store_credit_spec.rb
@@ -10,7 +10,7 @@ describe 'Payment' do
let(:store_credit) { create(:store_credit, amount_used: captured_amount, store: store) }
let(:auth_code) { '1-SC-20141111111111' }
let(:captured_amount) { 10.0 }
- let(:order) { create(:order, store: store) }
+ let(:order) { create(:order, store: store, total: 100) }
let(:payment) { create(:store_credit_payment, response_code: auth_code, order: order) }
let!(:capture_event) do
diff --git a/core/spec/models/spree/payment_method/store_credit_spec.rb b/core/spec/models/spree/payment_method/store_credit_spec.rb
index 90b1cb496d..c904c2c579 100644
--- a/core/spec/models/spree/payment_method/store_credit_spec.rb
+++ b/core/spec/models/spree/payment_method/store_credit_spec.rb
@@ -2,7 +2,7 @@ require 'spec_helper'
describe Spree::PaymentMethod::StoreCredit do
let(:store) { Spree::Store.default }
- let(:order) { create(:order, store: store) }
+ let(:order) { create(:order, store: store, total: 100) }
let(:payment) { create(:payment, order: order) }
let(:gateway_options) { payment.gateway_options }
diff --git a/core/spec/models/spree/store_credit_event_spec.rb b/core/spec/models/spree/store_credit_event_spec.rb
index 39aa9f037e..906eccb365 100644
--- a/core/spec/models/spree/store_credit_event_spec.rb
+++ b/core/spec/models/spree/store_credit_event_spec.rb
@@ -94,7 +94,7 @@ describe 'StoreCreditEvent' do
end
let(:authorization_code) { '1-SC-TEST' }
- let(:order) { create(:order, store: store) }
+ let(:order) { create(:order, store: store, total: 100) }
let!(:payment) { create(:store_credit_payment, order: order, response_code: authorization_code) }
it 'returns the order associated with the payment' do
diff --git a/core/spec/models/spree/store_spec.rb b/core/spec/models/spree/store_spec.rb
index b1c0533a40..05445037ed 100644
--- a/core/spec/models/spree/store_spec.rb
+++ b/core/spec/models/spree/store_spec.rb
@@ -46,8 +46,8 @@ describe Spree::Store, type: :model do
end
describe '#orders' do
- let!(:order) { create(:order, store: subject) }
- let!(:order_2) { create(:order, store: create(:store)) }
+ let!(:order) { create(:order, store: subject, total: 100) }
+ let!(:order_2) { create(:order, store: create(:store), total: 100) }
it { expect(subject.orders).to eq([order]) }
diff --git a/core/spec/services/spree/cart/add_item_spec.rb b/core/spec/services/spree/cart/add_item_spec.rb
index ceb4114fb8..77fb590340 100644
--- a/core/spec/services/spree/cart/add_item_spec.rb
+++ b/core/spec/services/spree/cart/add_item_spec.rb
@@ -4,7 +4,7 @@ module Spree
describe Cart::AddItem do
subject { described_class }
- let(:order) { create :order }
+ let(:order) { create :order, total: 100 }
let(:variant) { create :variant, price: 20 }
let(:qty) { 1 }
let(:execute) { subject.call(order: order, variant: variant, quantity: qty) }
@@ -54,7 +54,9 @@ module Spree
end
context 'with store_credits payment' do
+ let!(:order) { create(:order, total: 100) }
let!(:payment) { create(:store_credit_payment, order: order) }
+
let(:execute) { subject.call(order: order, variant: variant, quantity: 1) }
it do
diff --git a/core/spec/services/spree/cart/remove_item_spec.rb b/core/spec/services/spree/cart/remove_item_spec.rb
index c7c4394b2a..3e0fc8678a 100644
--- a/core/spec/services/spree/cart/remove_item_spec.rb
+++ b/core/spec/services/spree/cart/remove_item_spec.rb
@@ -65,6 +65,7 @@ module Spree
end
context 'when store_credits payment' do
+ let(:order) { create(:order, line_items: [line_item], total: 100) }
let!(:payment) { create(:store_credit_payment, order: order) }
let(:execute) { subject.call order: order, variant: variant }
diff --git a/core/spec/services/spree/checkout/advance_spec.rb b/core/spec/services/spree/checkout/advance_spec.rb
index 95622a3a59..931d6413e7 100644
--- a/core/spec/services/spree/checkout/advance_spec.rb
+++ b/core/spec/services/spree/checkout/advance_spec.rb
@@ -8,9 +8,10 @@ RSpec.describe Spree::Checkout::Advance do
describe '#call' do
context 'with no specific target state' do
before do
- order.payments.last.update(amount: 19.99)
- order.update(payment_total: 19.99, completed_at: nil)
+ order.update!(total: 19.99, payment_total: 0, shipment_total: 5, item_total: 14.99, completed_at: nil)
+ order.payments.last.update!(amount: 19.99)
order.reload
+
Spree::StockItem.where(variant: order.variants).update_all(count_on_hand: 10, backorderable: false)
end