Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Remove legacy product-level price requirement

Łukasz Adamczyk75dfb58e7a4c
diff --git a/spree/core/app/models/spree/product.rb b/spree/core/app/models/spree/product.rb
index 5e4fa7747f..2b38498ddd 100644
--- a/spree/core/app/models/spree/product.rb
+++ b/spree/core/app/models/spree/product.rb
@@ -133,7 +133,6 @@ module Spree
with_options presence: true do
validates :name
validates :shipping_category, if: :requires_shipping_category?
- validates :price, if: :requires_price?
end
# Every persisted product must keep a default variant. It's assigned on
@@ -889,10 +888,6 @@ module Spree
end
end
- def requires_price?
- Spree::Config[:require_default_variant_price]
- end
-
def requires_shipping_category?
true
end
diff --git a/spree/core/config/locales/en.yml b/spree/core/config/locales/en.yml
index 97211301df..19712af72b 100644
--- a/spree/core/config/locales/en.yml
+++ b/spree/core/config/locales/en.yml
@@ -380,7 +380,6 @@ en:
attributes:
base:
cannot_destroy_if_attached_to_line_items: Cannot delete Variants that are added to placed Orders. In such cases, please discontinue them.
- must_supply_price_for_variant_or_master: Must supply price for variant or master price for product.
no_default_variant_found_to_infer_price: No default variant found to infer price
spree/webhook_endpoint:
attributes:
diff --git a/spree/core/lib/spree/core/configuration.rb b/spree/core/lib/spree/core/configuration.rb
index 4bfb556599..bdb9972a1b 100644
--- a/spree/core/lib/spree/core/configuration.rb
+++ b/spree/core/lib/spree/core/configuration.rb
@@ -89,8 +89,6 @@ module Spree
preference :max_level_in_taxons_menu, :integer, deprecated: true
preference :non_expiring_credit_types, :array, default: []
preference :products_per_page, :integer, default: 12
- preference :require_default_variant_price, :boolean, default: false
- preference :require_master_price, :boolean, default: false, deprecated: 'Use require_default_variant_price instead' # renamed in 6.0 with the master variant removal; removed in 6.1
preference :restock_inventory, :boolean, default: true # Determines if a return item is restocked automatically once it has been received
preference :return_eligibility_number_of_days, :integer, default: 365
preference :reserve_stock_on, :string, default: 'checkout' # 'checkout' (default) or 'cart' — landing in 6.0 alongside Cart/Order split