Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fix legacy_webhooks CI build

Damian Legawiec768a28cb882c
diff --git a/core/lib/spree/testing_support/common_rake.rb b/core/lib/spree/testing_support/common_rake.rb
index 9e9cde0f83..80e6c11cff 100644
--- a/core/lib/spree/testing_support/common_rake.rb
+++ b/core/lib/spree/testing_support/common_rake.rb
@@ -20,7 +20,7 @@ namespace :common do
Rails.env = 'test'
api_only = ['spree/api', 'spree/core', 'spree/sample'].include?(ENV['LIB_NAME'])
- skip_javascript = api_only || ENV['LIB_NAME'] == 'spree/emails'
+ skip_javascript = api_only || ['spree/emails', 'spree/legacy_webhooks'].include?(ENV['LIB_NAME'])
dummy_app_args = [
"--lib_name=#{ENV['LIB_NAME']}"
diff --git a/legacy_webhooks/Gemfile b/legacy_webhooks/Gemfile
index 616bef81be..b7f573a03c 100644
--- a/legacy_webhooks/Gemfile
+++ b/legacy_webhooks/Gemfile
@@ -4,4 +4,6 @@ gem 'spree_core', path: '../core'
gem 'spree_api', path: '../api'
gem 'spree_admin', path: '../admin'
+gem 'sprockets-rails', '>= 3.5.2'
+
gemspec
diff --git a/legacy_webhooks/lib/spree/legacy_webhooks/engine.rb b/legacy_webhooks/lib/spree/legacy_webhooks/engine.rb
index 50460bf60a..7ff8333b64 100644
--- a/legacy_webhooks/lib/spree/legacy_webhooks/engine.rb
+++ b/legacy_webhooks/lib/spree/legacy_webhooks/engine.rb
@@ -10,10 +10,6 @@ module Spree
config.autoload_paths << "#{config.root}/app/models/concerns"
- initializer 'spree.legacy_webhooks.checking_migrations' do
- Migrations.new(config, engine_name).check unless Rails.env.test?
- end
-
# Include HasWebhooks concern in configured models
config.after_initialize do
# Models that should have legacy webhooks
diff --git a/legacy_webhooks/spec/controllers/spree/admin/webhooks_subscribers_controller_spec.rb b/legacy_webhooks/spec/controllers/spree/admin/webhooks_subscribers_controller_spec.rb
index 1e8bf4f499..244efc28b4 100644
--- a/legacy_webhooks/spec/controllers/spree/admin/webhooks_subscribers_controller_spec.rb
+++ b/legacy_webhooks/spec/controllers/spree/admin/webhooks_subscribers_controller_spec.rb
@@ -3,8 +3,6 @@ require 'spec_helper'
describe Spree::Admin::WebhooksSubscribersController, type: :controller do
stub_authorization!
- render_views
-
describe '#index' do
let!(:webhook_subscriber) { create(:webhook_subscriber) }