Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Fix payment unique index migration to deduplicate first (#13939)
Damian Legawiec7f07341f7ed2
diff --git a/spree/core/db/migrate/20260424000001_add_unique_index_to_spree_payments_response_code.rb b/spree/core/db/migrate/20260424000001_add_unique_index_to_spree_payments_response_code.rbindex 0f8830f3c9..5d1f82f474 100644--- a/spree/core/db/migrate/20260424000001_add_unique_index_to_spree_payments_response_code.rb+++ b/spree/core/db/migrate/20260424000001_add_unique_index_to_spree_payments_response_code.rb@@ -1,5 +1,36 @@class AddUniqueIndexToSpreePaymentsResponseCode < ActiveRecord::Migration[7.2]- def change+ def up+ # Remove duplicate payments per (order, payment_method, response_code),+ # preferring to keep completed payments over incomplete ones.+ # Among same-state duplicates, keeps the most recent (highest id).+ # Uses derived table for MySQL compatibility.+ execute <<~SQL+ DELETE FROM spree_payments+ WHERE response_code IS NOT NULL+ AND id NOT IN (+ SELECT keeper_id FROM (+ SELECT (+ SELECT id FROM spree_payments p2+ WHERE p2.order_id = p1.order_id+ AND p2.payment_method_id = p1.payment_method_id+ AND p2.response_code = p1.response_code+ ORDER BY+ CASE p2.state+ WHEN 'completed' THEN 0+ WHEN 'pending' THEN 1+ WHEN 'processing' THEN 2+ ELSE 3+ END,+ p2.id DESC+ LIMIT 1+ ) AS keeper_id+ FROM spree_payments p1+ WHERE p1.response_code IS NOT NULL+ GROUP BY p1.order_id, p1.payment_method_id, p1.response_code+ ) AS keeper_ids+ )+ SQL+if ActiveRecord::Base.connection.adapter_name == 'Mysql2'# MySQL doesn't support partial indexes, but treats NULL as distinct# in unique indexes so multiple payments with NULL response_code are allowed@@ -13,4 +44,8 @@ class AddUniqueIndexToSpreePaymentsResponseCode < ActiveRecord::Migration[7.2]name: 'idx_payments_order_method_response_code'endend++ def down+ remove_index :spree_payments, name: 'idx_payments_order_method_response_code'+ endend