Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Add API tests for cms_section#reposition & cms_page#toggle_visibility

Matthew Kennedy85d14cd8ea8d
diff --git a/api/app/controllers/spree/api/v2/platform/cms_pages_controller.rb b/api/app/controllers/spree/api/v2/platform/cms_pages_controller.rb
index 7891c98805..e0b7d74491 100644
--- a/api/app/controllers/spree/api/v2/platform/cms_pages_controller.rb
+++ b/api/app/controllers/spree/api/v2/platform/cms_pages_controller.rb
@@ -8,7 +8,7 @@ module Spree
def toggle_visibility
spree_authorize! :update, @toggle_page if spree_current_user.present?
- @toggle_page = scope.find(params[:page_id])
+ @toggle_page = scope.find(params[:id])
if @toggle_page
@toggle_page.toggle!(:visible)
diff --git a/api/spec/requests/spree/api/v2/platform/cms_page_spec.rb b/api/spec/requests/spree/api/v2/platform/cms_page_spec.rb
new file mode 100644
index 0000000000..e74339f415
--- /dev/null
+++ b/api/spec/requests/spree/api/v2/platform/cms_page_spec.rb
@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe 'Platform API v2 CmsPage', type: :request do
+ include_context 'API v2 tokens'
+ include_context 'Platform API v2'
+
+ let!(:store) { create(:store, default: true) }
+ let!(:page) { create(:cms_homepage, store: store) }
+ let(:bearer_token) { { 'Authorization' => valid_authorization } }
+
+ describe 'cms_page#toggle_visibility' do
+ context 'with no params' do
+ let(:params) { {id: nil} }
+
+ before do
+ patch '/api/v2/platform/cms_pages/toggle_visibility', headers: bearer_token, params: params
+ end
+
+ it_behaves_like 'returns 404 HTTP status'
+ end
+
+ context 'with correct params' do
+ before do
+ patch "/api/v2/platform/cms_pages/#{page.id}/toggle_visibility", headers: bearer_token
+ end
+
+ it_behaves_like 'returns 204 HTTP status'
+
+ it 'sets page.visible from true to false' do
+ page.reload
+ expect(page.visible).to be false
+ end
+ end
+ end
+end
diff --git a/api/spec/requests/spree/api/v2/platform/cms_section_spec.rb b/api/spec/requests/spree/api/v2/platform/cms_section_spec.rb
new file mode 100644
index 0000000000..75a22b27ac
--- /dev/null
+++ b/api/spec/requests/spree/api/v2/platform/cms_section_spec.rb
@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe 'Platform API v2 CmsSection', type: :request do
+ include_context 'API v2 tokens'
+ include_context 'Platform API v2'
+
+ let!(:store) { create(:store, default: true) }
+ let!(:page) { create(:cms_homepage, store: store) }
+ let!(:section_a) { create(:cms_section, cms_page: page) }
+ let!(:section_b) { create(:cms_section, cms_page: page) }
+ let!(:section_c) { create(:cms_section, cms_page: page) }
+ let!(:section_d) { create(:cms_section, cms_page: page) }
+ let(:bearer_token) { { 'Authorization' => valid_authorization } }
+
+ describe 'cms_section#reposition' do
+ context 'with no params' do
+ let(:params) { nil }
+
+ before do
+ patch '/api/v2/platform/cms_sections/reposition', headers: bearer_token, params: params
+ end
+
+ it_behaves_like 'returns 404 HTTP status'
+ end
+
+ context 'with correct params' do
+ let(:params) { { section_id: section_d.id, new_position_idx: 0 } }
+
+ before do
+ patch '/api/v2/platform/cms_sections/reposition', headers: bearer_token, params: params
+ end
+
+ it_behaves_like 'returns 204 HTTP status'
+
+ it 'repositions section from position 4 to position 1' do
+ # acts_as_list is not zero indexed so moving to
+ # position 0 results in a seved postiton at 1.
+ section_d.reload
+ expect(section_d.position).to eq(1)
+ end
+ end
+
+ context 'with correct params' do
+ let(:params) { { section_id: section_a.id, new_position_idx: 3 } }
+
+ before do
+ patch '/api/v2/platform/cms_sections/reposition', headers: bearer_token, params: params
+ end
+
+ it_behaves_like 'returns 204 HTTP status'
+
+ it 'moves item from position 1 to position 4' do
+ # acts_as_list is not zero indexed so moving to
+ # position 3 results in a seved postiton at 4.
+ section_a.reload
+ expect(section_a.position).to eq(4)
+ end
+ end
+ end
+end
diff --git a/api/spec/requests/spree/api/v2/platform/menu_item_spec.rb b/api/spec/requests/spree/api/v2/platform/menu_item_spec.rb
index d4001b8d27..c506017778 100644
--- a/api/spec/requests/spree/api/v2/platform/menu_item_spec.rb
+++ b/api/spec/requests/spree/api/v2/platform/menu_item_spec.rb
@@ -1,6 +1,6 @@
require 'spec_helper'
-describe 'Platform API v2 Menu Items spec', type: :request do
+describe 'Platform API v2 MenuItem', type: :request do
include_context 'API v2 tokens'
include_context 'Platform API v2'
diff --git a/backend/app/assets/javascripts/spree/backend/cms/page.es6 b/backend/app/assets/javascripts/spree/backend/cms/page.es6
index c15224c1f2..acccd603a3 100644
--- a/backend/app/assets/javascripts/spree/backend/cms/page.es6
+++ b/backend/app/assets/javascripts/spree/backend/cms/page.es6
@@ -30,15 +30,13 @@ document.addEventListener('DOMContentLoaded', function() {
function handleTogglePageVisibility(obj) {
const pageId = parseInt(obj.dataset.cmsPageId, 10)
- const data = { page_id: pageId }
fetch(Spree.routes.pages_api_v2 + `/${pageId}/toggle_visibility`, {
method: 'PATCH',
headers: {
Authorization: 'Bearer ' + OAUTH_TOKEN,
'Content-Type': 'application/json'
- },
- body: JSON.stringify(data)
+ }
})
.then(response => {
if (response.ok) {
diff --git a/backend/spec/features/admin/cms_pages/edit_homepage_spec.rb b/backend/spec/features/admin/cms_pages/edit_homepage_spec.rb
index 1c247b5722..0c9a072e43 100644
--- a/backend/spec/features/admin/cms_pages/edit_homepage_spec.rb
+++ b/backend/spec/features/admin/cms_pages/edit_homepage_spec.rb
@@ -4,7 +4,7 @@ describe 'Edit Homepage', type: :feature do
stub_authorization!
context 'when a user creates a Homepage' do
- let!(:store_1) { create(:store) }
+ let!(:store_1) { create(:store, name: 'Super Store', default: true, supported_locales: 'en,fr') }
before do
I18n.backend.store_translations(:fr,