Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Fix: money and rate fields refused amounts with more than two decimals
Damian Legawiec861e63fb8a01
diff --git a/packages/dashboard-core/src/locales/ar.json b/packages/dashboard-core/src/locales/ar.jsonindex 386823da9b..a483398f23 100644--- a/packages/dashboard-core/src/locales/ar.json+++ b/packages/dashboard-core/src/locales/ar.json@@ -1463,6 +1463,7 @@"seeded_report_read_only": "هذا تقرير مدمج ولا يمكن تغييره. احفظ نسخة بدلاً من ذلك.","taken": "مستخدم بالفعل","too_long": "طويل جدًا (الحد الأقصى {{count}} حرفًا)",+ "too_many_decimals": "يحتوي على أكثر من {{count}} منازل عشرية","too_short": "قصير جدًا (الحد الأدنى {{count}} حرفًا)","wrong_length": "الطول غير صحيح (يجب أن يكون {{count}} حرفًا)"},@@ -1479,7 +1480,8 @@"passwords_dont_match": "كلمتا المرور غير متطابقتين","positive_number": "يجب أن يكون {{field}} أكبر من 0","required": "{{field}} مطلوب",- "store_name_required": "اسم المتجر مطلوب"+ "store_name_required": "اسم المتجر مطلوب",+ "too_many_decimals": "يمكن أن يحتوي {{field}} على {{count}} منازل عشرية كحد أقصى"},"products": {"autocomplete": {diff --git a/packages/dashboard-core/src/locales/de.json b/packages/dashboard-core/src/locales/de.jsonindex 5c57e9b103..883218c903 100644--- a/packages/dashboard-core/src/locales/de.json+++ b/packages/dashboard-core/src/locales/de.json@@ -1463,6 +1463,7 @@"seeded_report_read_only": "Dies ist ein integrierter Bericht und kann nicht geändert werden. Speichern Sie stattdessen eine Kopie.","taken": "ist bereits vergeben","too_long": "ist zu lang (maximal {{count}} Zeichen)",+ "too_many_decimals": "hat mehr als {{count}} Nachkommastellen","too_short": "ist zu kurz (mindestens {{count}} Zeichen)","wrong_length": "hat die falsche Länge (sollte {{count}} Zeichen haben)"},@@ -1479,7 +1480,8 @@"passwords_dont_match": "Die Passwörter stimmen nicht überein","positive_number": "{{field}} muss größer als 0 sein","required": "{{field}} ist erforderlich",- "store_name_required": "Shopname ist erforderlich"+ "store_name_required": "Shopname ist erforderlich",+ "too_many_decimals": "{{field}} darf höchstens {{count}} Nachkommastellen haben"},"products": {"autocomplete": {diff --git a/packages/dashboard-core/src/locales/en.json b/packages/dashboard-core/src/locales/en.jsonindex f31f93f11d..c1e4f56de1 100644--- a/packages/dashboard-core/src/locales/en.json+++ b/packages/dashboard-core/src/locales/en.json@@ -1465,6 +1465,7 @@"seeded_report_read_only": "This is a built-in report and cannot be changed. Save a copy instead.","taken": "has already been taken","too_long": "is too long (maximum is {{count}} characters)",+ "too_many_decimals": "has more than {{count}} decimal places","too_short": "is too short (minimum is {{count}} characters)","wrong_length": "is the wrong length (should be {{count}} characters)"},@@ -1481,7 +1482,8 @@"passwords_dont_match": "Passwords do not match","positive_number": "{{field}} must be greater than 0","required": "{{field}} is required",- "store_name_required": "Store name is required"+ "store_name_required": "Store name is required",+ "too_many_decimals": "{{field}} can have at most {{count}} decimal places"},"products": {"autocomplete": {diff --git a/packages/dashboard-core/src/locales/es.json b/packages/dashboard-core/src/locales/es.jsonindex da1c985dc7..2a8c1c3956 100644--- a/packages/dashboard-core/src/locales/es.json+++ b/packages/dashboard-core/src/locales/es.json@@ -1608,6 +1608,7 @@"seeded_report_read_only": "Este es un reporte incorporado y no se puede modificar. Guardá una copia.","taken": "ya está en uso","too_long": "es demasiado largo (máximo {{count}} caracteres)",+ "too_many_decimals": "tiene más de {{count}} decimales","too_short": "es demasiado corto (mínimo {{count}} caracteres)","wrong_length": "tiene un largo incorrecto (debería ser {{count}} caracteres)"},@@ -1624,7 +1625,8 @@"passwords_dont_match": "Las contraseñas no coinciden","positive_number": "{{field}} debe ser mayor que 0","required": "{{field}} es obligatorio",- "store_name_required": "El nombre de la tienda es obligatorio"+ "store_name_required": "El nombre de la tienda es obligatorio",+ "too_many_decimals": "{{field}} puede tener como máximo {{count}} decimales"},"common": {"active": "Activo",diff --git a/packages/dashboard-core/src/locales/fr.json b/packages/dashboard-core/src/locales/fr.jsonindex d5f65308c5..900f4371e9 100644--- a/packages/dashboard-core/src/locales/fr.json+++ b/packages/dashboard-core/src/locales/fr.json@@ -1463,6 +1463,7 @@"seeded_report_read_only": "Ce rapport est intégré et ne peut pas être modifié. Enregistrez plutôt une copie.","taken": "est déjà utilisé","too_long": "est trop long ({{count}} caractères maximum)",+ "too_many_decimals": "a plus de {{count}} décimales","too_short": "est trop court ({{count}} caractères minimum)","wrong_length": "n'a pas la bonne longueur ({{count}} caractères attendus)"},@@ -1479,7 +1480,8 @@"passwords_dont_match": "Les mots de passe ne correspondent pas","positive_number": "{{field}} doit être supérieur à 0","required": "{{field}} est obligatoire",- "store_name_required": "Le nom de la boutique est requis"+ "store_name_required": "Le nom de la boutique est requis",+ "too_many_decimals": "{{field}} peut avoir au plus {{count}} décimales"},"products": {"autocomplete": {diff --git a/packages/dashboard-core/src/locales/pl.json b/packages/dashboard-core/src/locales/pl.jsonindex 51e7518c32..053686b433 100644--- a/packages/dashboard-core/src/locales/pl.json+++ b/packages/dashboard-core/src/locales/pl.json@@ -1480,6 +1480,7 @@"seeded_report_read_only": "To raport wbudowany i nie można go zmienić. Zapisz zamiast tego kopię.","taken": "jest już zajęte","too_long": "jest za długie (maksymalnie {{count}} znaków)",+ "too_many_decimals": "ma więcej niż {{count}} miejsca po przecinku","too_short": "jest za krótkie (minimalnie {{count}} znaków)","wrong_length": "ma nieprawidłową długość (powinno mieć {{count}} znaków)"},@@ -1496,7 +1497,8 @@"passwords_dont_match": "Hasła nie są zgodne","positive_number": "Pole {{field}} musi być większe niż 0","required": "Pole {{field}} jest wymagane",- "store_name_required": "Nazwa sklepu jest wymagana"+ "store_name_required": "Nazwa sklepu jest wymagana",+ "too_many_decimals": "{{field}} może mieć najwyżej {{count}} miejsca po przecinku"},"products": {"autocomplete": {diff --git a/packages/dashboard-core/src/locales/zh-CN.json b/packages/dashboard-core/src/locales/zh-CN.jsonindex 0559eb4494..10aafcb204 100644--- a/packages/dashboard-core/src/locales/zh-CN.json+++ b/packages/dashboard-core/src/locales/zh-CN.json@@ -1463,6 +1463,7 @@"seeded_report_read_only": "这是内置报表,无法修改。请改为保存副本。","taken": "已被占用","too_long": "太长(最多 {{count}} 个字符)",+ "too_many_decimals": "超过 {{count}} 位小数","too_short": "太短(最少 {{count}} 个字符)","wrong_length": "长度不正确(应为 {{count}} 个字符)"},@@ -1479,7 +1480,8 @@"passwords_dont_match": "两次输入的密码不一致","positive_number": "{{field}} 必须大于 0","required": "{{field}} 为必填项",- "store_name_required": "商店名称为必填项"+ "store_name_required": "商店名称为必填项",+ "too_many_decimals": "{{field}}最多只能有 {{count}} 位小数"},"products": {"autocomplete": {diff --git a/packages/dashboard-ui/src/index.ts b/packages/dashboard-ui/src/index.tsindex 1883c914ca..c4408dada7 100644--- a/packages/dashboard-ui/src/index.ts+++ b/packages/dashboard-ui/src/index.ts@@ -26,7 +26,7 @@ export {} from './lib/date-range-presets'export { sameRichText, shouldEmitRichTextChange } from './lib/same-rich-text'export { cn } from './lib/utils'-export { requiredMessage } from './lib/validation-messages'+export { decimalPlacesMessage, requiredMessage } from './lib/validation-messages'// ---------------------------------------------------------------------------// Spree composed components — headless, accept data via props// ---------------------------------------------------------------------------diff --git a/packages/dashboard-ui/src/lib/validation-messages.ts b/packages/dashboard-ui/src/lib/validation-messages.tsindex 20fa4babe0..fd002ddc54 100644--- a/packages/dashboard-ui/src/lib/validation-messages.ts+++ b/packages/dashboard-ui/src/lib/validation-messages.ts@@ -17,3 +17,15 @@ import i18n from 'i18next'export function requiredMessage(field: string): () => string {return () => i18n.t('admin.validation.required', { field: i18n.t(`admin.fields.${field}.label`) })}++/**+ * Lazy "<Field> can have at most <count> decimal places" message, for amounts+ * and rates the server keeps to a fixed number of decimals.+ */+export function decimalPlacesMessage(field: string, count: number): () => string {+ return () =>+ i18n.t('admin.validation.too_many_decimals', {+ field: i18n.t(`admin.fields.${field}.label`),+ count,+ })+}diff --git a/packages/dashboard-ui/src/spree/claim-resolve-dialog.tsx b/packages/dashboard-ui/src/spree/claim-resolve-dialog.tsxindex 71849415a3..37a3c7f52c 100644--- a/packages/dashboard-ui/src/spree/claim-resolve-dialog.tsx+++ b/packages/dashboard-ui/src/spree/claim-resolve-dialog.tsx@@ -141,7 +141,7 @@ export function ClaimResolveDialog({<InputGroupInputid="claim-resolve-amount"type="number"- step="0.01"+ step="any"min="0"value={amount}onChange={(event) => setAmount(event.target.value)}diff --git a/packages/dashboard-ui/src/spree/label-upload-dialog.tsx b/packages/dashboard-ui/src/spree/label-upload-dialog.tsxindex 4146f231fd..bc64baf04e 100644--- a/packages/dashboard-ui/src/spree/label-upload-dialog.tsx+++ b/packages/dashboard-ui/src/spree/label-upload-dialog.tsx@@ -127,7 +127,7 @@ export function LabelUploadDialog({<InputGroupInputid="label-cost"type="number"- step="0.01"+ step="any"min="0"{...form.register('cost')}/>diff --git a/packages/dashboard-ui/src/spree/post-sale-create-dialogs.tsx b/packages/dashboard-ui/src/spree/post-sale-create-dialogs.tsxindex c29086ad00..94a06b410b 100644--- a/packages/dashboard-ui/src/spree/post-sale-create-dialogs.tsx+++ b/packages/dashboard-ui/src/spree/post-sale-create-dialogs.tsx@@ -200,7 +200,7 @@ export function CreateClaimDialog({<InputGroupInputid={`claim-amount-${line.id}`}type="number"- step="0.01"+ step="any"min="0"value={amounts[line.id] ?? ''}onChange={(event) => {diff --git a/packages/dashboard-ui/src/spree/quantity-tier-editor.tsx b/packages/dashboard-ui/src/spree/quantity-tier-editor.tsxindex 26c4af5519..0fc0332f7f 100644--- a/packages/dashboard-ui/src/spree/quantity-tier-editor.tsx+++ b/packages/dashboard-ui/src/spree/quantity-tier-editor.tsx@@ -106,7 +106,7 @@ export function QuantityTierEditor({)}<InputGroupInputtype="number"- step="0.01"+ step="any"value={row.value}disabled={disabled}aria-label={labels.value}diff --git a/packages/dashboard-ui/src/spree/return-dialogs.tsx b/packages/dashboard-ui/src/spree/return-dialogs.tsxindex 3c9e26718a..dd29d0e2e8 100644--- a/packages/dashboard-ui/src/spree/return-dialogs.tsx+++ b/packages/dashboard-ui/src/spree/return-dialogs.tsx@@ -209,7 +209,7 @@ export function ReturnRefundDialog({<InputGroupInputid="refund-amount"type="number"- step="0.01"+ step="any"min="0"value={amount}onChange={(event) => setAmount(event.target.value)}diff --git a/packages/dashboard/e2e/tax-rates.spec.ts b/packages/dashboard/e2e/tax-rates.spec.tsindex 588b88150c..c24709152e 100644--- a/packages/dashboard/e2e/tax-rates.spec.ts+++ b/packages/dashboard/e2e/tax-rates.spec.ts@@ -6,13 +6,13 @@ const CTA = /add tax rate/iasync function createTaxRate(page: Page,- attrs: { name: string; amount: string; country?: string },+ attrs: { name: string; ratePercent: string; country?: string },) {await page.getByRole('button', { name: CTA }).click()await expect(page.getByRole('heading', { name: /new tax rate/i })).toBeVisible()await page.locator('#name').fill(attrs.name)- await page.locator('#rate_percent').fill(attrs.amount)+ await page.locator('#rate_percent').fill(attrs.ratePercent)// The seeded store always carries a `Default` tax category.await page.locator('#tax_category_id').click()await page.getByRole('option', { name: /^default$/i }).click()@@ -43,7 +43,7 @@ test.describe('tax rates', () => {await gotoIndex(page, TAX_RATES_PATH(creds.store_id), CTA)const name = `E2E VAT ${Date.now()}`- await createTaxRate(page, { name, amount: '21', country: 'Spain' })+ await createTaxRate(page, { name, ratePercent: '21', country: 'Spain' })const row = page.getByRole('row').filter({ has: rowButton(page, name) })await expect(row).toBeVisible({ timeout: 15_000 })@@ -56,7 +56,7 @@ test.describe('tax rates', () => {await gotoIndex(page, TAX_RATES_PATH(creds.store_id), CTA)const name = `E2E Edit Rate ${Date.now()}`- await createTaxRate(page, { name, amount: '10' })+ await createTaxRate(page, { name, ratePercent: '10' })await expect(rowButton(page, name)).toBeVisible({ timeout: 15_000 })await rowButton(page, name).click()@@ -68,12 +68,47 @@ test.describe('tax rates', () => {await expect(row.getByText('12.5%')).toBeVisible({ timeout: 15_000 })})+ // The API stores the fraction (0.07125); the form must read back exactly+ // what the merchant typed, not a rounded 7.13.+ test('keeps a rate with three decimals exactly', async ({ page }) => {+ const creds = await login(page)+ await gotoIndex(page, TAX_RATES_PATH(creds.store_id), CTA)++ const name = `E2E Precise Rate ${Date.now()}`+ await createTaxRate(page, { name, ratePercent: '7.125' })++ const row = page.getByRole('row').filter({ has: rowButton(page, name) })+ await expect(row.getByText('7.125%')).toBeVisible({ timeout: 15_000 })++ await rowButton(page, name).click()+ await expect(page.locator('#rate_percent')).toHaveValue('7.125', { timeout: 15_000 })+ })++ test('refuses a fourth decimal and a blank rate without saving', async ({ page }) => {+ const creds = await login(page)+ await gotoIndex(page, TAX_RATES_PATH(creds.store_id), CTA)++ const name = `E2E Overprecise Rate ${Date.now()}`+ await createTaxRate(page, { name, ratePercent: '7.1255' })++ const rateField = page.locator('#rate_percent')+ await expect(rateField).toHaveAttribute('aria-invalid', 'true')+ await expect(page.getByText(/at most 3 decimal places/i)).toBeVisible()++ await rateField.fill('')+ await page.getByRole('button', { name: /create tax rate/i }).click()+ await expect(rateField).toHaveAttribute('aria-invalid', 'true')++ await page.keyboard.press('Escape')+ await expect(rowButton(page, name)).toHaveCount(0)+ })+test('deletes a rate after confirming', async ({ page }) => {const creds = await login(page)await gotoIndex(page, TAX_RATES_PATH(creds.store_id), CTA)const name = `E2E Delete Rate ${Date.now()}`- await createTaxRate(page, { name, amount: '5' })+ await createTaxRate(page, { name, ratePercent: '5' })await expect(rowButton(page, name)).toBeVisible({ timeout: 15_000 })await openRowMenu(page, name)diff --git a/packages/dashboard/src/components/spree/catalog-terms-card.tsx b/packages/dashboard/src/components/spree/catalog-terms-card.tsxindex fe5b9c62e5..385aa67d79 100644--- a/packages/dashboard/src/components/spree/catalog-terms-card.tsx+++ b/packages/dashboard/src/components/spree/catalog-terms-card.tsx@@ -213,7 +213,7 @@ function OrderMinimums({<Inputtype="number"min="0"- step="0.01"+ step="any"disabled={!canEdit}aria-invalid={!amountValid || duplicate}aria-label={t('admin.catalogs.terms.minimum_amount_label')}diff --git a/packages/dashboard/src/components/spree/orders/order-adjustments-cards.tsx b/packages/dashboard/src/components/spree/orders/order-adjustments-cards.tsxindex 0ed2c06ee8..d435b9650f 100644--- a/packages/dashboard/src/components/spree/orders/order-adjustments-cards.tsx+++ b/packages/dashboard/src/components/spree/orders/order-adjustments-cards.tsx@@ -488,7 +488,7 @@ function AddDiscountDialog({id="discount-value"name="value"type="number"- step="0.01"+ step="any"min="0.01"value={value}onChange={(e) => setValue(e.target.value)}@@ -643,7 +643,7 @@ function AddFeeDialog({id="fee-amount"name="amount"type="number"- step="0.01"+ step="any"min="0"required/>diff --git a/packages/dashboard/src/components/spree/orders/order-payments-card.tsx b/packages/dashboard/src/components/spree/orders/order-payments-card.tsxindex ded531ec52..bc61b7cc9a 100644--- a/packages/dashboard/src/components/spree/orders/order-payments-card.tsx+++ b/packages/dashboard/src/components/spree/orders/order-payments-card.tsx@@ -413,7 +413,7 @@ function AddPaymentDialog({<InputGroupInputid="pay-amount"type="number"- step="0.01"+ step="any"placeholder={order.amount_due ?? '0.00'}value={amount}onChange={(e) => setAmount(e.target.value)}diff --git a/packages/dashboard/src/components/spree/sellers/seller-edit-settlement-sheet.tsx b/packages/dashboard/src/components/spree/sellers/seller-edit-settlement-sheet.tsxindex 6a5e8ab16f..0bf10865b9 100644--- a/packages/dashboard/src/components/spree/sellers/seller-edit-settlement-sheet.tsx+++ b/packages/dashboard/src/components/spree/sellers/seller-edit-settlement-sheet.tsx@@ -201,7 +201,7 @@ export function SellerEditSettlementSheet({<InputGroupInputid="minimum_payout_amount"type="number"- step="0.01"+ step="any"min="0"inputMode="decimal"aria-invalid={!!errors.minimum_payout_amount || undefined}diff --git a/packages/dashboard/src/components/spree/shipping/delivery-method-form.tsx b/packages/dashboard/src/components/spree/shipping/delivery-method-form.tsxindex dc9961c93b..34afc31cca 100644--- a/packages/dashboard/src/components/spree/shipping/delivery-method-form.tsx+++ b/packages/dashboard/src/components/spree/shipping/delivery-method-form.tsx@@ -894,7 +894,7 @@ function ServiceOverridesSheet({<InputGroupInputid={`service-markup-flat-${index}`}type="number"- step="0.01"+ step="any"min="0"placeholder="0"{...form.register(`services.${index}.markup_flat`)}@@ -909,7 +909,7 @@ function ServiceOverridesSheet({<InputGroupInputid={`service-markup-percent-${index}`}type="number"- step="0.01"+ step="any"min="0"placeholder="0"{...form.register(`services.${index}.markup_percent`)}@@ -1111,7 +1111,7 @@ function PricingCard({ form }: { form: UseFormReturn<DeliveryMethodFormValues> }<InputGroupInputid="markup_percent"type="number"- step="0.01"+ step="any"min="0"placeholder="0"{...form.register('markup_percent')}@@ -1132,7 +1132,7 @@ function PricingCard({ form }: { form: UseFormReturn<DeliveryMethodFormValues> }<InputGroupInputid="markup_flat"type="number"- step="0.01"+ step="any"min="0"placeholder="0"{...form.register('markup_flat')}diff --git a/packages/dashboard/src/components/spree/variant-line-editor.tsx b/packages/dashboard/src/components/spree/variant-line-editor.tsxindex d03144bae8..1ae932cb20 100644--- a/packages/dashboard/src/components/spree/variant-line-editor.tsx+++ b/packages/dashboard/src/components/spree/variant-line-editor.tsx@@ -235,7 +235,7 @@ export function VariantLineEditor({<InputGroupInputtype="number"min={0}- step="0.01"+ step="any"value={unitCost ?? ''}onChange={(event) => update(variant.id, { unitCost: event.target.value })}className="text-right tabular-nums"diff --git a/packages/dashboard/src/routes/_authenticated/$storeId/loyalty/gift-cards.tsx b/packages/dashboard/src/routes/_authenticated/$storeId/loyalty/gift-cards.tsxindex 8abbcd7ae8..4f3059e95a 100644--- a/packages/dashboard/src/routes/_authenticated/$storeId/loyalty/gift-cards.tsx+++ b/packages/dashboard/src/routes/_authenticated/$storeId/loyalty/gift-cards.tsx@@ -440,7 +440,7 @@ function AmountCurrencyRow<T extends GiftCardCreateFormValues | GiftCardEditForm<InputGroupInputid="amount"type="number"- step="0.01"+ step="any"min={0}disabled={readOnly}aria-invalid={!!errors.amount || undefined}diff --git a/packages/dashboard/src/routes/_authenticated/$storeId/sellers/commission-rates.tsx b/packages/dashboard/src/routes/_authenticated/$storeId/sellers/commission-rates.tsxindex 989b4209a4..4f40e2d7a5 100644--- a/packages/dashboard/src/routes/_authenticated/$storeId/sellers/commission-rates.tsx+++ b/packages/dashboard/src/routes/_authenticated/$storeId/sellers/commission-rates.tsx@@ -407,7 +407,7 @@ function CommissionRateFormFields({ form }: { form: UseFormReturn<CommissionRate<InputGroupInputid="value"type="number"- step="0.01"+ step="any"min="0"max="100"aria-invalid={!!errors.value || undefined}@@ -441,7 +441,7 @@ function CommissionRateFormFields({ form }: { form: UseFormReturn<CommissionRate<InputGroupInputid="commission_tax_rate"type="number"- step="0.01"+ step="any"min="0"placeholder={t('admin.fields.commission_rate.commission_tax_rate.placeholder')}{...form.register('commission_tax_rate')}@@ -557,7 +557,7 @@ function FlatFeeAmountsField({ form }: { form: UseFormReturn<CommissionRateFormVrender={({ field }) => (<Inputtype="number"- step="0.01"+ step="any"min="0"aria-label={currency}value={(field.value?.[currency] as string) ?? ''}@@ -611,7 +611,7 @@ function FlatFeeCapField({ form }: { form: UseFormReturn<CommissionRateFormValuereturn (<Inputtype="number"- step="0.01"+ step="any"min="0"aria-label={`${currency} ${t('admin.fields.commission_rate.max_amount.label')}`}placeholder={t('admin.fields.commission_rate.max_amount.label')}@@ -671,7 +671,7 @@ function PercentageBoundsField({ form }: { form: UseFormReturn<CommissionRateFor<><Inputtype="number"- step="0.01"+ step="any"min="0"aria-label={`${currency} ${t('admin.fields.commission_rate.min_amount.label')}`}placeholder={t('admin.fields.commission_rate.min_amount.label')}@@ -681,7 +681,7 @@ function PercentageBoundsField({ form }: { form: UseFormReturn<CommissionRateFor<span className="text-sm text-muted-foreground">–</span><Inputtype="number"- step="0.01"+ step="any"min="0"aria-label={`${currency} ${t('admin.fields.commission_rate.max_amount.label')}`}placeholder={t('admin.fields.commission_rate.max_amount.label')}diff --git a/packages/dashboard/src/routes/_authenticated/$storeId/settings/marketplace.tsx b/packages/dashboard/src/routes/_authenticated/$storeId/settings/marketplace.tsxindex e8c5b18cf3..bfe9f41039 100644--- a/packages/dashboard/src/routes/_authenticated/$storeId/settings/marketplace.tsx+++ b/packages/dashboard/src/routes/_authenticated/$storeId/settings/marketplace.tsx@@ -311,7 +311,7 @@ function MarketplaceSettingsPage({ store }: { store: Store }) {id="payout-minimum"type="number"min={0}- step="0.01"+ step="any"inputMode="decimal"aria-invalid={!!errors.preferred_default_minimum_payout_amount || undefined@@ -390,7 +390,7 @@ function MarketplaceSettingsPage({ store }: { store: Store }) {type="number"min={0}max={100}- step="0.01"+ step="any"aria-invalid={!!errors.commission_tax_rate_percentage || undefined}{...form.register('commission_tax_rate_percentage')}/>diff --git a/packages/dashboard/src/routes/_authenticated/$storeId/settings/tax-rates.tsx b/packages/dashboard/src/routes/_authenticated/$storeId/settings/tax-rates.tsxindex f9ea120049..f816375788 100644--- a/packages/dashboard/src/routes/_authenticated/$storeId/settings/tax-rates.tsx+++ b/packages/dashboard/src/routes/_authenticated/$storeId/settings/tax-rates.tsx@@ -324,7 +324,7 @@ function TaxRateFormFields({ form }: { form: UseFormReturn<TaxRateFormValues> })<InputGroupInputid="rate_percent"type="number"- step="0.01"+ step="any"min="0"max="100"inputMode="decimal"diff --git a/packages/dashboard/src/schemas/tax-rate.test.ts b/packages/dashboard/src/schemas/tax-rate.test.tsnew file mode 100644index 0000000000..c1490e14dd--- /dev/null+++ b/packages/dashboard/src/schemas/tax-rate.test.ts@@ -0,0 +1,32 @@+import { describe, expect, it } from 'vitest'+import { TAX_RATE_DEFAULTS, taxRateFormSchema } from './tax-rate'++const valid = { ...TAX_RATE_DEFAULTS, name: 'VAT', tax_category_id: 'tc_1' }++function rateErrors(ratePercent: string) {+ const result = taxRateFormSchema.safeParse({ ...valid, rate_percent: ratePercent })+ return result.success+ ? []+ : result.error.issues.filter((issue) => issue.path[0] === 'rate_percent')+}++describe('taxRateFormSchema rate_percent', () => {+ it('takes a percentage with up to three decimals', () => {+ expect(rateErrors('7.125')).toEqual([])+ expect(rateErrors('100')).toEqual([])+ })++ it('refuses a fourth decimal, which the server could not keep', () => {+ expect(rateErrors('7.1255')).toHaveLength(1)+ })++ it('refuses a rate above 100', () => {+ expect(rateErrors('100.5')).toHaveLength(1)+ })++ // The later checks used to compare a blank value and throw, crashing the form.+ it('reports a blank or malformed rate instead of throwing', () => {+ expect(rateErrors('').length).toBeGreaterThan(0)+ expect(rateErrors('.5').length).toBeGreaterThan(0)+ })+})diff --git a/packages/dashboard/src/schemas/tax-rate.ts b/packages/dashboard/src/schemas/tax-rate.tsindex 8eb48a998b..2af9ce86cf 100644--- a/packages/dashboard/src/schemas/tax-rate.ts+++ b/packages/dashboard/src/schemas/tax-rate.ts@@ -1,6 +1,6 @@import { compareMoney, isDecimalString, type TaxRateParams } from '@spree/admin-sdk'import { blankToNull } from '@spree/dashboard-core'-import { requiredMessage } from '@spree/dashboard-ui'+import { decimalPlacesMessage, requiredMessage } from '@spree/dashboard-ui'import { z } from 'zod/v4'export const taxRateFormSchema = z.object({@@ -9,6 +9,10 @@ export const taxRateFormSchema = z.object({rate_percent: z.string().regex(/^\d+(\.\d+)?$/, { error: requiredMessage('tax_rate.amount') })+ // Stored as a fraction to five decimals, so a percentage keeps three.+ .refine((value) => (value.split('.')[1] ?? '').length <= 3, {+ error: decimalPlacesMessage('tax_rate.amount', 3),+ }).refine((value) => !isDecimalString(value) || compareMoney(value, '100') <= 0, {error: requiredMessage('tax_rate.amount'),}),