Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fix: Fixed newsletter subscribers migration task for renamed customer column (#14792)

Damian Legawiec865bd408e9c5
diff --git a/spree/core/lib/tasks/core.rake b/spree/core/lib/tasks/core.rake
index 195827a8a8..bdd0815380 100644
--- a/spree/core/lib/tasks/core.rake
+++ b/spree/core/lib/tasks/core.rake
@@ -26,14 +26,16 @@ namespace :core do
desc 'Migrate newsletter subscribers'
task migrate_newsletter_subscribers: :environment do |_t, _args|
- Spree.customer_class.where(accepts_email_marketing: true).in_batches(of: 500) do |user_batch|
- subscriber_attributes = user_batch.pluck(:id, :email, :updated_at).map do |id, email, updated_at|
+ store_id = Spree::Store.default&.id
+
+ Spree.customer_class.where(accepts_email_marketing: true).in_batches(of: 500) do |customer_batch|
+ subscriber_attributes = customer_batch.pluck(:id, :email, :updated_at).map do |id, email, updated_at|
{
email: Spree::NewsletterSubscriber.new(email: email).email, # normalized email
- user_id: id,
+ customer_id: id,
verified_at: updated_at,
verification_token: nil,
- store_id: Spree::Store.default&.id,
+ store_id: store_id,
updated_at: DateTime.current,
created_at: DateTime.current
}
diff --git a/spree/core/spec/lib/tasks/core_spec.rb b/spree/core/spec/lib/tasks/core_spec.rb
index 9e2bc9a6e1..12c2257871 100644
--- a/spree/core/spec/lib/tasks/core_spec.rb
+++ b/spree/core/spec/lib/tasks/core_spec.rb
@@ -55,12 +55,20 @@ describe 'core:migrate_newsletter_subscribers' do
expect(Spree::NewsletterSubscriber.verified.count).to eq(7)
expect(Spree::NewsletterSubscriber.find_by(customer: user).attributes).to include(
'email' => user.email,
+ 'customer_id' => user.id,
'verified_at' => user.updated_at,
'verification_token' => nil,
'updated_at' => kind_of(ActiveSupport::TimeWithZone),
'created_at' => kind_of(ActiveSupport::TimeWithZone)
)
end
+
+ it 'does not duplicate subscribers when run again' do
+ subject.invoke
+ subject.reenable
+
+ expect { subject.invoke }.not_to change(Spree::NewsletterSubscriber, :count)
+ end
end
describe 'core:archive_products' do