Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fix addresses controller scope

Szymon Iwacz88ea8735839c
diff --git a/api/app/controllers/spree/api/v2/storefront/account/addresses_controller.rb b/api/app/controllers/spree/api/v2/storefront/account/addresses_controller.rb
index 07bb1eaa14..90a890f0ac 100644
--- a/api/app/controllers/spree/api/v2/storefront/account/addresses_controller.rb
+++ b/api/app/controllers/spree/api/v2/storefront/account/addresses_controller.rb
@@ -37,7 +37,7 @@ module Spree
end
def scope
- model_class.not_deleted
+ super.not_deleted
end
def model_class
diff --git a/api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb b/api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb
index bfe6abc976..1cf8151050 100644
--- a/api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb
+++ b/api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb
@@ -63,6 +63,19 @@ describe 'Storefront API v2 Addresses spec', type: :request do
expect(json_response['data'].size).to eq(addresses.count)
end
end
+
+ context 'when address without user exists' do
+ let!(:address) { create(:address, user_id: nil) }
+
+ before do
+ get '/api/v2/storefront/account/addresses', headers: headers_bearer
+ end
+
+ it 'should not return address without user id' do
+ expect(json_response['data'][0]).to have_type('address')
+ expect(json_response['data'].size).to eq(addresses.count)
+ end
+ end
end
describe 'addresses#create' do