Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed slug uniqueness in CmsPage (#11670)

Damian Legawiec8ad7d0b6acf9
diff --git a/core/db/migrate/20220329113557_fix_cms_pages_unique_indexes.rb b/core/db/migrate/20220329113557_fix_cms_pages_unique_indexes.rb
new file mode 100644
index 0000000000..86607fbece
--- /dev/null
+++ b/core/db/migrate/20220329113557_fix_cms_pages_unique_indexes.rb
@@ -0,0 +1,8 @@
+class FixCmsPagesUniqueIndexes < ActiveRecord::Migration[5.2]
+ def change
+ remove_index :spree_cms_pages, [:slug, :store_id, :deleted_at]
+ remove_index :spree_cms_pages, [:slug, :store_id], unique: true
+
+ add_index :spree_cms_pages, [:slug, :store_id, :deleted_at], unique: true
+ end
+end
diff --git a/core/spec/models/spree/cms_page_spec.rb b/core/spec/models/spree/cms_page_spec.rb
index e8b04dc3f7..d8466869cf 100644
--- a/core/spec/models/spree/cms_page_spec.rb
+++ b/core/spec/models/spree/cms_page_spec.rb
@@ -24,6 +24,29 @@ describe Spree::CmsPage, type: :model do
end
end
+ describe 'validates uniqueness of slug' do
+ context 'valid' do
+ let!(:page) { create(:cms_standard_page, store: store_a, slug: 'got-name', locale: 'en') }
+
+ it 'valid' do
+ expect(described_class.new(title: 'Another Name', store: store_a, locale: 'en', type: 'Spree::Cms::Pages::StandardPage')).to be_valid
+ end
+
+ it 'omits previously deleted page' do
+ expect { page.destroy }.to change(page, :deleted_at).from(nil).to(Time)
+ expect(described_class.new(title: 'Got Name', store: store_a, slug: 'got-name', locale: 'en', type: 'Spree::Cms::Pages::StandardPage')).to be_valid
+ end
+ end
+
+ context 'invalid' do
+ let!(:page) { create(:cms_standard_page, store: store_a, slug: 'got-name', locale: 'en') }
+
+ it 'invalid' do
+ expect(described_class.new(title: 'Got Name', store: store_a, slug: 'got-name', locale: 'en', type: 'Spree::Cms::Pages::StandardPage')).not_to be_valid
+ end
+ end
+ end
+
describe 'Spree::Cms::Pages::Homepage' do
let(:homepage) { create(:cms_homepage, store: store_a, locale: 'en') }