Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Add create/index/show webhooks subscribers.

Sebastian Palma8e9aa37ee539
diff --git a/api/app/controllers/spree/api/v2/platform/webhooks/subscribers_controller.rb b/api/app/controllers/spree/api/v2/platform/webhooks/subscribers_controller.rb
index 63dd521b0c..c3e1801acf 100644
--- a/api/app/controllers/spree/api/v2/platform/webhooks/subscribers_controller.rb
+++ b/api/app/controllers/spree/api/v2/platform/webhooks/subscribers_controller.rb
@@ -7,7 +7,7 @@ module Spree
private
def model_class
- Spree::Webhooks::Endpoint
+ Spree::Webhooks::Subscriber
end
def permitted_resource_params
diff --git a/api/app/serializers/spree/api/v2/platform/webhooks/endpoint_serializer.rb b/api/app/serializers/spree/api/v2/platform/webhooks/endpoint_serializer.rb
deleted file mode 100644
index f5455d2854..0000000000
--- a/api/app/serializers/spree/api/v2/platform/webhooks/endpoint_serializer.rb
+++ /dev/null
@@ -1,15 +0,0 @@
-module Spree
- module Api
- module V2
- module Platform
- module Webhooks
- class EndpointSerializer < BaseSerializer
- set_type :webhooks_endpoint
-
- attributes :enabled, :url, :subscriptions
- end
- end
- end
- end
- end
-end
diff --git a/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb b/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb
index adada8bcc9..ffdb64abfb 100644
--- a/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb
+++ b/api/spec/integration/api/v2/platform/webhooks/subscribers_spec.rb
@@ -3,9 +3,9 @@ require 'spec_helper'
# [TODO]: move
FactoryBot.define do
- factory :webhook_subscriber, aliases: [:subscriber], class: Spree::Webhooks::Endpoint do
- trait :enabled do
- enabled { true }
+ factory :webhook_subscriber, aliases: [:subscriber], class: Spree::Webhooks::Subscriber do
+ trait :active do
+ active { true }
sequence(:url) { |n| "https://www.url#{n}.com/" }
end
end
@@ -20,8 +20,8 @@ describe 'WebhooksSubscribers API', swagger: true do
let(:id) { subscriber.tap(&:save).id }
let(:invalid_param_value) { { url: '' } }
- let(:records_list) { create_list(:subscriber, 2, :enabled, subscriptions: ['*']) }
- let(:subscriber) { build(:subscriber, :enabled, subscriptions: ['*']) }
+ let(:records_list) { create_list(:subscriber, 2, :active, subscriptions: ['*']) }
+ let(:subscriber) { build(:subscriber, :active, subscriptions: ['*']) }
let(:valid_create_param_value) { subscriber.attributes }
path '/api/v2/platform/webhooks/subscribers' do
diff --git a/api/spec/requests/spree/api/v2/platform/webhooks/subscribers_spec.rb b/api/spec/requests/spree/api/v2/platform/webhooks/subscribers_spec.rb
index 0a90cef5f4..e9a9814064 100644
--- a/api/spec/requests/spree/api/v2/platform/webhooks/subscribers_spec.rb
+++ b/api/spec/requests/spree/api/v2/platform/webhooks/subscribers_spec.rb
@@ -7,7 +7,7 @@ describe 'Platform API v2 Webhooks Subscribers spec', type: :request do
include_context 'Platform API v2'
let(:bearer_token) { { 'Authorization' => valid_authorization } }
- let(:params) { { subscriber: { enabled: true, url: 'https://www.url.com/', subscriptions: ['*'] } } }
+ let(:params) { { subscriber: { active: true, url: 'https://www.url.com/', subscriptions: ['*'] } } }
context 'valid request' do
it 'returns status created' do
@@ -16,7 +16,7 @@ describe 'Platform API v2 Webhooks Subscribers spec', type: :request do
end
it 'creates a subscriber ' do
- expect { subject }.to change { Spree::Webhooks::Endpoint.count }.from(0).to(1)
+ expect { subject }.to change { Spree::Webhooks::Subscriber.count }.from(0).to(1)
end
end
end