Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Improve JavaScript and SCSS for SortableJS menu boilerplate.

Matthew Kennedy944a0690d78b
diff --git a/backend/app/assets/javascripts/spree/backend/navigation/menu.es6 b/backend/app/assets/javascripts/spree/backend/navigation/menu.es6
index 1a3c18b779..f4a7b394db 100644
--- a/backend/app/assets/javascripts/spree/backend/navigation/menu.es6
+++ b/backend/app/assets/javascripts/spree/backend/navigation/menu.es6
@@ -1,15 +1,17 @@
/* eslint-disable no-new */
+
document.addEventListener('DOMContentLoaded', function() {
const menuItemSortable = {
group: {
- name: 'sortable-list-2',
+ name: 'sortable-menu-sub',
pull: true,
put: true
},
handle: '.move-handle',
+ dragClass: 'menu-item-dragged',
draggable: '.dragable',
- animation: 250,
- forceFallback: true
+ animation: 350,
+ forceFallback: false
};
let containers = null;
diff --git a/backend/app/assets/stylesheets/spree/backend/shared/_sortable_js_tree.scss b/backend/app/assets/stylesheets/spree/backend/shared/_sortable_js_tree.scss
index a6f74d5003..9ab75f2b58 100644
--- a/backend/app/assets/stylesheets/spree/backend/shared/_sortable_js_tree.scss
+++ b/backend/app/assets/stylesheets/spree/backend/shared/_sortable_js_tree.scss
@@ -1,4 +1,5 @@
$item-padding: 14px;
+
#menuArea {
.menu-item {
background-color: white;
@@ -36,7 +37,16 @@ $item-padding: 14px;
}
}
- #primaryMenuContainer > div.menu-container-item {
- padding-left: 0;
+ #primaryMenuContainer > div.menu-item {
+ border-left: 1px solid transparent;
+ }
+
+ #primaryMenuContainer > div.menu-item:first-child {
+ border-top: 1px solid transparent;
+ border-left: 1px solid transparent;
+ }
+
+ .menu-item.menu-item-dragged {
+ border: 1px solid $border-color;
}
}
diff --git a/backend/app/views/spree/admin/menus/edit.html.erb b/backend/app/views/spree/admin/menus/edit.html.erb
index d11301121e..1f40df7285 100644
--- a/backend/app/views/spree/admin/menus/edit.html.erb
+++ b/backend/app/views/spree/admin/menus/edit.html.erb
@@ -29,7 +29,7 @@
<div id="menuArea">
<div class="row mt-5">
<div class="col-12">
- <div class="card mb-3" style="overflow: hidden;">
+ <div class="card mb-3" >
<div class="card-header">
<div class="row pb-0">
<div class="col d-flex">
@@ -82,8 +82,6 @@
</div>
</div>
</div>
-
-
</div>
</div>