Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Removed unused Ruby dependencies (#15021)

Damian Legawiec94baf2dad326
diff --git a/spree/api/spec/requests/spree/api/v3/admin/oauth_access_spec.rb b/spree/api/spec/requests/spree/api/v3/admin/oauth_access_spec.rb
index d84bfac6c6..d235953ea3 100644
--- a/spree/api/spec/requests/spree/api/v3/admin/oauth_access_spec.rb
+++ b/spree/api/spec/requests/spree/api/v3/admin/oauth_access_spec.rb
@@ -244,7 +244,7 @@ RSpec.describe 'Admin API OAuth access', type: :request do
'X-Spree-Store-Id' => other.prefixed_id }
expect(response).to have_http_status(:ok)
- expect(assigns(:current_store) || controller.send(:current_store)).to eq(store)
+ expect(controller.send(:current_store)).to eq(store)
end
end
end
diff --git a/spree/common_spree_dependencies.rb b/spree/common_spree_dependencies.rb
index 2fca243e38..496d3c32af 100644
--- a/spree/common_spree_dependencies.rb
+++ b/spree/common_spree_dependencies.rb
@@ -38,7 +38,6 @@ group :test do
gem 'simplecov-cobertura'
gem 'webmock'
gem 'timecop'
- gem 'rails-controller-testing'
# N+1 tripwire for API requests (see Spree::Api::V3::BaseController).
# pg_query is Prosopite's SQL fingerprinter for every adapter but MySQL.
# It has a C extension and no JRuby build, so it is scoped like the
@@ -50,7 +49,6 @@ group :test do
end
group :test, :development do
- gem 'awesome_print'
gem 'brakeman'
gem 'bundler-audit'
gem 'gem-release'
@@ -61,9 +59,6 @@ group :test, :development do
gem 'pry-byebug'
gem 'puma'
gem 'ffaker'
-
- # Ruby 3.4+ removed observer from stdlib
- gem 'observer'
end
group :development do
diff --git a/spree/core/lib/spree/core.rb b/spree/core/lib/spree/core.rb
index cb15f917f3..1b951e393e 100644
--- a/spree/core/lib/spree/core.rb
+++ b/spree/core/lib/spree/core.rb
@@ -39,8 +39,6 @@ require 'ransack'
require 'active_storage_validations'
require 'wannabe_bool'
require 'geocoder'
-
-require 'safely_block'
require 'ar_lazy_preload'
require 'sqids'
diff --git a/spree/core/spree_core.gemspec b/spree/core/spree_core.gemspec
index 94990dbc8d..fb825e3aa7 100644
--- a/spree/core/spree_core.gemspec
+++ b/spree/core/spree_core.gemspec
@@ -37,7 +37,6 @@ Gem::Specification.new do |s|
s.add_dependency 'alba', '~> 3.0'
s.add_dependency 'acts-as-taggable-on'
s.add_dependency 'awesome_nested_set', '~> 3.3', '>= 3.3.1'
- s.add_dependency 'benchmark' # needed for ruby 4.0 and benchmark gem
s.add_dependency 'cancancan', '~> 3.2'
s.add_dependency 'countries'
# OAuth 2.1 authorization server. Pinned to a release candidate because it
@@ -69,7 +68,6 @@ Gem::Specification.new do |s|
s.add_dependency 'rails-i18n', '~> 8.0'
s.add_dependency 'ransack', '>= 4.1'
s.add_dependency 'request_store', '~> 1.5'
- s.add_dependency 'rexml'
s.add_dependency 'stringex'
s.add_dependency 'tracking_number'
@@ -81,7 +79,6 @@ Gem::Specification.new do |s|
s.add_dependency 'mobility-ransack', '~> 1.2'
s.add_dependency 'friendly_id-mobility', '~> 1.0'
s.add_dependency 'wannabe_bool'
- s.add_dependency 'safely_block', '>= 0.4', '< 2.0'
s.add_dependency 'phonelib', '~> 0.10'
s.add_dependency 'ar_lazy_preload', '~> 2.1'
s.add_dependency 'bcrypt', '~> 3.1'
diff --git a/spree/mcp/spec/requests/spree/api/v3/admin/mcp_spec.rb b/spree/mcp/spec/requests/spree/api/v3/admin/mcp_spec.rb
index 949c37b6d8..55732a1d07 100644
--- a/spree/mcp/spec/requests/spree/api/v3/admin/mcp_spec.rb
+++ b/spree/mcp/spec/requests/spree/api/v3/admin/mcp_spec.rb
@@ -1,5 +1,4 @@
require 'spec_helper'
-require 'benchmark'
# The endpoint, from the header down. A request spec rather than a controller
# spec because the unit under test is the whole request: the credential, the
@@ -99,9 +98,9 @@ RSpec.describe 'Admin MCP endpoint', type: :request do
# Parsing the bearer header must not backtrack: this header arrives
# unauthenticated, so a pathological value is free to send.
it 'parses a bearer header of many spaces without stalling' do
- elapsed = Benchmark.realtime do
- post_rpc('tools/list', headers: { 'Authorization' => "Bearer #{' ' * 50_000}x" })
- end
+ started = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+ post_rpc('tools/list', headers: { 'Authorization' => "Bearer #{' ' * 50_000}x" })
+ elapsed = Process.clock_gettime(Process::CLOCK_MONOTONIC) - started
expect(response).to have_http_status(:unauthorized)
expect(elapsed).to be < 1.0