Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Fix: a create workflow ran without a create permission check
Damian Legawiec9bf62598424e
diff --git a/spree/api/spec/lib/spree/agent_tools/authorization_spec.rb b/spree/api/spec/lib/spree/agent_tools/authorization_spec.rbindex 8be73eb591..8ee8d5d476 100644--- a/spree/api/spec/lib/spree/agent_tools/authorization_spec.rb+++ b/spree/api/spec/lib/spree/agent_tools/authorization_spec.rb@@ -116,6 +116,36 @@ RSpec.describe 'assistant authorization' doendend+ # A create workflow builds its own record, so there is nothing to check+ # when the tool runs — the Admin API checks `:create` on a built record+ # before calling the workflow, and the tool has no equivalent unless it+ # authorizes against the class.+ context 'when the admin may edit products but not create one' do+ let(:ability) do+ Class.new do+ include CanCan::Ability++ def initialize(*)+ can :read, Spree::Product+ can :update, Spree::Product+ end++ def permission_keys+ Spree.permissions.catalog_keys+ end+ end.new+ end++ it 'refuses the create workflow' do+ create_tool = Spree.agent_tools.available_for(context).+ find { |candidate| candidate.tool_name == 'products_create' }+ result = create_tool.call(attributes: { 'name' => 'Should Not Exist' })++ expect(result[:error]).to be_present+ expect(Spree::Product.for_store(store).where(name: 'Should Not Exist')).not_to exist+ end+ end+# The stock catalog grants writes as `:manage`, which covers deletion —# but an ability can be replaced, and a host app that grants `:update`# without `:destroy` means it. A deletion checked as an update would godiff --git a/spree/core/lib/spree/agent_tools/workflow_tool.rb b/spree/core/lib/spree/agent_tools/workflow_tool.rbindex 757cdbfc28..f72fb35a98 100644--- a/spree/core/lib/spree/agent_tools/workflow_tool.rb+++ b/spree/core/lib/spree/agent_tools/workflow_tool.rb@@ -169,7 +169,7 @@ module Spreeresolved = resolve_arguments(arguments)return resolved if resolved.is_a?(Hash) && resolved[:error]- refusal = unauthorized_record(resolved)+ refusal = unauthorized_create || unauthorized_record(resolved)return refusal if refusalkeywords = resolved.merge(principal_arguments).merge(context_arguments)@@ -202,7 +202,10 @@ module Spree# subject, since a cancellation reason from another seller is as much a# leak as the order itself.def unauthorized_record(arguments)- action = ability_action+ # A create's own action is checked against the class above; the records+ # it was handed are collaborators (a supplier, a stock location), so+ # they are checked for the read-and-use they actually get.+ action = ability_action == :create ? :show : ability_actionrecords(arguments).each do |record|refusal = unauthorized(action, record)@@ -212,6 +215,28 @@ module Spreenilend+ # A create workflow has no record to check yet — the workflow builds it+ # — so the Admin API's `authorize_resource!(@resource, :create)` has no+ # counterpart here. Authorize against the class instead, which is what a+ # record-level rule on a create would be evaluated against anyway.+ #+ # @return [Hash, nil]+ def unauthorized_create+ return unless ability_action == :create+ return if context.can?(:create, created_model)++ { error: "You do not have permission to create this #{created_model.model_name.human.downcase}." }+ end++ # What the workflow creates, named by its own key: `products.create`+ # creates a product. A key whose model cannot be resolved falls back to+ # the subject check alone rather than guessing.+ #+ # @return [Class, nil]+ def created_model+ @created_model ||= "Spree::#{workflow_class.workflow_key.split('.').first.classify}".safe_constantize+ end+# Which CanCanCan action this workflow amounts to. The stock catalog# grants writes as `:manage`, which covers everything — but an ability# may be replaced, and a host app that grants `:update` without@@ -219,7 +244,11 @@ module Spree## @return [Symbol]def ability_action- workflow_class.workflow_key.split('.').last == 'destroy' ? :destroy : :update+ case workflow_class.workflow_key.split('.').last+ when 'destroy' then :destroy+ when 'create' then :create+ else :update+ endend# Only what the caller named. The store and the principal are injected