Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Stop skipping inventory verification for digital orders

Damian Legawiec9e4de2b2ba9c
diff --git a/spree/core/app/models/spree/line_item.rb b/spree/core/app/models/spree/line_item.rb
index d0be211ae8..6b622c9c64 100644
--- a/spree/core/app/models/spree/line_item.rb
+++ b/spree/core/app/models/spree/line_item.rb
@@ -51,7 +51,11 @@ module Spree
validates_with Spree::Stock::AvailabilityValidator, if: -> { variant.present? }
validate :ensure_proper_currency, if: -> { owner.present? }
- before_destroy :verify_order_inventory_before_destroy, if: -> { order&.delivery_required? }
+ # Order-side only: a cart's fulfillment items are built by the Stock
+ # Coordinator and copied at completion, so `owner` would be wrong here.
+ # Removing an item from a placed order must drain its units and restock —
+ # `removing: true` keeps verify from re-adding units mid-destroy.
+ before_destroy :verify_order_inventory_before_destroy, if: -> { order.present? }
after_save :update_inventory
after_save :update_adjustments
@@ -335,8 +339,15 @@ module Spree
end
end
+ # Order-side only (see before_destroy above); OrderInventory#verify
+ # itself returns early unless the order is completed.
+ #
+ # No digitality gate: digital items get fulfillment items too (the
+ # Digital provider issues one link per unit), and stock-limited digitals
+ # — licences, seats, tickets — must decrement like anything else.
+ # Tracking is decided per variant by should_track_inventory?.
def update_inventory
- if (saved_changes? || target_fulfillment.present?) && order&.delivery_required?
+ if (saved_changes? || target_fulfillment.present?) && order.present?
verify_order_inventory
end
end
diff --git a/spree/core/spec/models/spree/line_item_spec.rb b/spree/core/spec/models/spree/line_item_spec.rb
index 1f94d99c6a..84b63b56f8 100644
--- a/spree/core/spec/models/spree/line_item_spec.rb
+++ b/spree/core/spec/models/spree/line_item_spec.rb
@@ -124,6 +124,56 @@ describe Spree::LineItem, type: :model do
end
end
+ # Inventory verification is NOT gated on digitality: a digital variant can
+ # be stock-limited (licences, seats, tickets), and the Digital provider
+ # issues one link per fulfillment unit. Tracking is decided per variant by
+ # should_track_inventory?, never by the order being all-digital.
+ describe 'inventory verification on a digital order' do
+ let(:digital_type) { create(:product_type, name: 'Licence', fulfillment_types: ['digital'], store: store) }
+ let(:licence_product) { create(:product, product_type: digital_type, store: store) }
+ let(:licence_variant) do
+ licence_product.default_variant.tap do |variant|
+ variant.update!(track_inventory: true)
+ variant.digitals << create(:digital, variant: variant)
+ end
+ end
+ let(:order) { create(:completed_order_with_totals, store: store) }
+
+ # The order must ALREADY be all-digital when the item saves — that is the
+ # state in which an order-level digitality gate suppresses verification
+ # (on the first digital item the order's line_items cache is still empty,
+ # so `digital?` is false and any such gate passes by accident).
+ before do
+ order.line_items.destroy_all
+ create(:line_item, order: order, variant: licence_variant, quantity: 1)
+ order.reload
+ end
+
+ it 'is an all-digital order' do
+ expect(order).to be_digital
+ end
+
+ it 'builds fulfillment items for a stock-limited digital variant' do
+ second_licence = create(:product, product_type: digital_type, store: store).default_variant
+ second_licence.update!(track_inventory: true)
+
+ line_item = create(:line_item, order: order, variant: second_licence, quantity: 2)
+
+ expect(line_item.reload.inventory_units.sum(&:quantity)).to eq(2)
+ end
+
+ it 'decrements stock for a tracked digital variant' do
+ second_licence = create(:product, product_type: digital_type, store: store).default_variant
+ second_licence.update!(track_inventory: true)
+ stock_item = second_licence.stock_items.first
+ stock_item.set_count_on_hand(5)
+
+ expect {
+ create(:line_item, order: order, variant: second_licence, quantity: 2)
+ }.to change { stock_item.reload.count_on_hand }.from(5).to(3)
+ end
+ end
+
context '#destroy' do
let!(:line_item) { order.line_items.first }