Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Add request ID to every API response headers (#13730)

Damian Legawieca127f6481e89
diff --git a/spree/api/app/controllers/concerns/spree/api/v3/security_headers.rb b/spree/api/app/controllers/concerns/spree/api/v3/security_headers.rb
index c54ec0fe46..3f882cc4f8 100644
--- a/spree/api/app/controllers/concerns/spree/api/v3/security_headers.rb
+++ b/spree/api/app/controllers/concerns/spree/api/v3/security_headers.rb
@@ -13,6 +13,7 @@ module Spree
def set_security_headers
response.headers['X-Content-Type-Options'] = 'nosniff'
response.headers['X-Frame-Options'] = 'DENY'
+ response.headers['X-Request-Id'] = request.request_id
response.headers.delete('X-Powered-By')
response.headers.delete('Server')
end
diff --git a/spree/api/spec/controllers/concerns/spree/api/v3/security_headers_spec.rb b/spree/api/spec/controllers/concerns/spree/api/v3/security_headers_spec.rb
index 65f21f6568..32c1460b56 100644
--- a/spree/api/spec/controllers/concerns/spree/api/v3/security_headers_spec.rb
+++ b/spree/api/spec/controllers/concerns/spree/api/v3/security_headers_spec.rb
@@ -22,6 +22,14 @@ RSpec.describe Spree::Api::V3::Store::StoresController, type: :controller do
expect(response.headers['X-Frame-Options']).to eq('DENY')
end
+ it 'sets X-Request-Id header' do
+ allow_any_instance_of(ActionDispatch::Request).to receive(:request_id).and_return('test-request-id-123')
+
+ get :show
+
+ expect(response.headers['X-Request-Id']).to eq('test-request-id-123')
+ end
+
it 'removes X-Powered-By header' do
get :show