Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Assert the catalog product row on its variant ladder
Damian Legawieca3c0f91f17fa
diff --git a/spree/api/spec/serializers/spree/api/v3/admin/catalog_product_serializer_spec.rb b/spree/api/spec/serializers/spree/api/v3/admin/catalog_product_serializer_spec.rbindex 8f700b3ef3..fc6d999640 100644--- a/spree/api/spec/serializers/spree/api/v3/admin/catalog_product_serializer_spec.rb+++ b/spree/api/spec/serializers/spree/api/v3/admin/catalog_product_serializer_spec.rb@@ -6,10 +6,10 @@ RSpec.describe Spree::Api::V3::Admin::CatalogProductSerializer do# A product can have nothing to price — its only variant soft-deleted, say.# That row still has to render; one degenerate product must not take the# whole assortment listing down with it.- it 'renders no catalog price for a product with no variant' do+ it 'renders an empty ladder for a product with no variant to price' docatalog = create(:catalog, store: store)product = create(:product, store: store, price: 50)- allow(product).to receive(:featured_variant).and_return(nil)+ allow(product).to receive(:variants).and_return(Spree::Variant.none)resolver = Spree::Catalogs::ResolvePrices.new(catalog: catalog, currency: 'USD')hash = described_class.new(@@ -18,9 +18,21 @@ RSpec.describe Spree::Api::V3::Admin::CatalogProductSerializer docatalog_price_resolver: resolver }).to_h- # Present and null, not absent: the expansion was asked for, so a client+ # Present and empty, not absent: the expansion was asked for, so a client# reading the key must find it answered rather than missing.- expect(hash).to have_key('catalog_price')- expect(hash['catalog_price']).to be_nil+ expect(hash).to have_key('catalog_variants')+ expect(hash['catalog_variants']).to eq([])+ end++ # The row carries what the card renders and nothing more — a full product+ # payload per row is what made the assortment page slow+ # (docs/plans/6.0-volume-pricing.md).+ it 'sends only the membership fields when the price is not expanded' do+ catalog = create(:catalog, store: store)+ product = create(:product, store: store, price: 50)++ hash = described_class.new(product, params: { store: store, currency: 'USD' }).to_h++ expect(hash.keys).to match_array(%w[id name thumbnail_url])endend