Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed: don't cache product carousel in page builder mode (#13123)

Damian Legawieca786c88756e8
diff --git a/storefront/app/helpers/spree/theme_helper.rb b/storefront/app/helpers/spree/theme_helper.rb
index a7ad16725d..e1b2f0217a 100644
--- a/storefront/app/helpers/spree/theme_helper.rb
+++ b/storefront/app/helpers/spree/theme_helper.rb
@@ -65,7 +65,7 @@ module Spree
#
# @return [Boolean] whether the page builder is enabled
def page_builder_enabled?
- @page_builder_enabled ||= (current_theme_preview.present? || current_page_preview.present?) && params[:page_builder] == 'true'
+ @page_builder_enabled ||= current_theme_preview.present? || current_page_preview.present?
end
# Returns whether the page cache is enabled
diff --git a/storefront/app/views/spree/shared/_products.html.erb b/storefront/app/views/spree/shared/_products.html.erb
index e2d5e08996..fa0a99bd8e 100644
--- a/storefront/app/views/spree/shared/_products.html.erb
+++ b/storefront/app/views/spree/shared/_products.html.erb
@@ -1 +1,5 @@
-<%= render partial: 'spree/products/product', collection: products, cached: ->(product) { product_cache_key(product) } %>
+<% unless page_builder_enabled? %>
+ <%= render partial: 'spree/products/product', collection: products, cached: ->(product) { product_cache_key(product) } %>
+<% else %>
+ <%= render partial: 'spree/products/product', collection: products %>
+<% end %>
diff --git a/storefront/spec/helpers/spree/theme_helper_spec.rb b/storefront/spec/helpers/spree/theme_helper_spec.rb
index ea32e56a60..f80195254f 100644
--- a/storefront/spec/helpers/spree/theme_helper_spec.rb
+++ b/storefront/spec/helpers/spree/theme_helper_spec.rb
@@ -78,7 +78,7 @@ RSpec.describe Spree::ThemeHelper, type: :helper do
describe '#page_builder_enabled?' do
it 'returns true if page builder is enabled' do
- allow(helper).to receive(:params).and_return(theme_preview_id: theme_preview.id, page_builder: 'true')
+ allow(helper).to receive(:params).and_return(theme_preview_id: theme_preview.id)
expect(helper.page_builder_enabled?).to be_truthy
end