Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fix guessable gift card batch codes (F1)

Damian Legawiecaba75471ca9c
diff --git a/spree/core/app/models/spree/gift_card_batch.rb b/spree/core/app/models/spree/gift_card_batch.rb
index 188d071b12..4ba34d6a9e 100644
--- a/spree/core/app/models/spree/gift_card_batch.rb
+++ b/spree/core/app/models/spree/gift_card_batch.rb
@@ -62,7 +62,7 @@ module Spree
def generate_code
loop do
- code = "#{prefix.downcase}#{SecureRandom.hex(3).downcase}"
+ code = "#{prefix.downcase}#{SecureRandom.hex(8).downcase}"
break code unless Spree::GiftCard.exists?(code: code) || @gift_cards_to_insert.detect { |gc| gc[:code] == code }
end
end