Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed: properly persisting Import preferences when creating in admin

Damian Legawiecb16d485e307f
diff --git a/admin/app/controllers/spree/admin/imports_controller.rb b/admin/app/controllers/spree/admin/imports_controller.rb
index 7f99efdcf4..7477153481 100644
--- a/admin/app/controllers/spree/admin/imports_controller.rb
+++ b/admin/app/controllers/spree/admin/imports_controller.rb
@@ -53,7 +53,7 @@ module Spree
end
def permitted_resource_params
- params.require(:import).permit(permitted_import_attributes)
+ params.require(:import).permit(permitted_import_attributes + @object.preferences.keys.map { |key| "preferred_#{key}" })
end
def choose_layout
diff --git a/admin/spec/controllers/spree/admin/imports_controller_spec.rb b/admin/spec/controllers/spree/admin/imports_controller_spec.rb
index 12b72b6868..6ef1749d8f 100644
--- a/admin/spec/controllers/spree/admin/imports_controller_spec.rb
+++ b/admin/spec/controllers/spree/admin/imports_controller_spec.rb
@@ -48,6 +48,15 @@ RSpec.describe Spree::Admin::ImportsController, type: :controller do
expect(import.attachment.filename.to_s).to eq('products_import.csv')
end
+ context 'with preferences' do
+ let(:import_params) { { type: Spree::Import.available_types.first.to_s, attachment: attachment, preferred_delimiter: ';' } }
+
+ it 'creates a new import with preferences' do
+ post :create, params: { import: import_params }
+ expect(assigns(:import).preferred_delimiter).to eq(';')
+ end
+ end
+
context 'when type parameter is present' do
it 'assigns the type' do
post :create, params: { import: import_params }