Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Potential fix for pull request finding 'CodeQL / Code injection'

Damian Legawiecb173ee219f88
diff --git a/spree/api/app/controllers/spree/api/v3/admin/delivery_methods_controller.rb b/spree/api/app/controllers/spree/api/v3/admin/delivery_methods_controller.rb
index 9e6670bca3..410f2f0b48 100644
--- a/spree/api/app/controllers/spree/api/v3/admin/delivery_methods_controller.rb
+++ b/spree/api/app/controllers/spree/api/v3/admin/delivery_methods_controller.rb
@@ -111,12 +111,13 @@ module Spree
preferences = permitted_params[:calculator_preferences]
if calculator_type.present? && delivery_method.calculator&.type != calculator_type
- unless Spree::DeliveryMethod.calculators.map(&:to_s).include?(calculator_type)
+ selected_calculator_class = Spree::DeliveryMethod.calculators.find { |klass| klass.to_s == calculator_type }
+ unless selected_calculator_class
delivery_method.errors.add(:calculator_type, :invalid)
return
end
- delivery_method.calculator = calculator_type.constantize.new
+ delivery_method.calculator = selected_calculator_class.new
end
return if preferences.blank? || delivery_method.calculator.nil?