Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Let keyboard users reach the term explanations
Damian Legawiecb2afc9b1f696
diff --git a/packages/dashboard/src/components/spree/catalog-terms-card.tsx b/packages/dashboard/src/components/spree/catalog-terms-card.tsxindex 49ff001c8b..f4f6c11ee0 100644--- a/packages/dashboard/src/components/spree/catalog-terms-card.tsx+++ b/packages/dashboard/src/components/spree/catalog-terms-card.tsx@@ -31,18 +31,22 @@ import type {* rules are easy to confuse with one another (an order multiple is a step* size, not a divisor of the total) and a merchant setting one needs the* distinction where they are reading, not in a paragraph below.+ *+ * The icon takes a tab stop deliberately. Skipping it would leave the+ * explanation reachable by pointer only, which is the audience least likely+ * to need it read aloud.*/function TermHelp({ text }: { text: string }) {return (<Tooltip><TooltipTrigger asChild>+ {/* Focusable and named: the tooltip opens on focus as well as hover,+ so keyboard and screen-reader users reach the explanation the+ same way everyone else does. */}<buttontype="button"- // A cursor-help affordance, not an action: it opens nothing and- // must not take a tab stop away from the field it describes.- tabIndex={-1}- className="cursor-help text-muted-foreground"- aria-hidden="true"+ className="cursor-help rounded-sm text-muted-foreground focus-visible:outline-2 focus-visible:outline-ring focus-visible:outline-offset-2"+ aria-label={text}><InfoIcon className="size-3.5" /></button>