Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Document what belongs in a tax identifier kind, and drop an unused helper
Łukasz Adamczykb445c3b3b685
diff --git a/spree/core/app/models/spree/tax_identifier.rb b/spree/core/app/models/spree/tax_identifier.rbindex 51c34bfcb1..776cba4055 100644--- a/spree/core/app/models/spree/tax_identifier.rb+++ b/spree/core/app/models/spree/tax_identifier.rb@@ -8,6 +8,25 @@ module Spree# taken at completion). Orders keep a copy rather than a reference because a# registration can be changed or withdrawn later, and an invoice must still# show what was true when it was issued.+ #+ # == The +kind+ column+ #+ # Which registration this is — an EU VAT number, a UK one, an Australian+ # business number. Any string is accepted, and nothing here narrows it: the+ # kinds that exist are the ones somebody has a validator or a provider for,+ # and core ships neither.+ #+ # It does have to match the key that validator is registered under in+ # {Spree.tax_id_validators}, because that lookup is by exact string. A kind+ # nothing is registered for is stored and used as entered — never+ # format-checked, never sent to a registry — and {#validatable?} reports as+ # much. So a misspelled kind fails silently rather than loudly.+ #+ # The kinds in circulation read as a region or country prefix plus the tax's+ # name: +eu_vat+, +gb_vat+, +ch_vat+, +au_abn+. Matching that spares a+ # validator gem and a storefront from having to agree with each other+ # directly. It is a habit of the gems that use it, not a rule this model+ # applies.class TaxIdentifier < Spree.base_classhas_prefix_id :txi@@ -57,14 +76,6 @@ module Spreevalidation_status == 'verified'end- # The provider-facing shape: a provider reads the kind and the number, never- # the ownership or the verdict.- #- # @return [Hash]- def to_provider_params- { kind: kind, value: value }- end-# Queues the registry check. Public for the same reason# {Spree::Address#async_geocode} is: an admin re-validate action calls it.def async_validatediff --git a/spree/core/spec/models/spree/tax_identifier_spec.rb b/spree/core/spec/models/spree/tax_identifier_spec.rbindex 201f28af47..022caf072d 100644--- a/spree/core/spec/models/spree/tax_identifier_spec.rb+++ b/spree/core/spec/models/spree/tax_identifier_spec.rb@@ -143,10 +143,4 @@ describe Spree::TaxIdentifier, type: :model doSpree.tax_id_validators.delete('eu_vat')endend-- it 'hands a provider the kind and number only' do- identifier = create(:tax_identifier, :verified, customer: customer, kind: 'eu_vat', value: 'DE123456789')-- expect(identifier.to_provider_params).to eq(kind: 'eu_vat', value: 'DE123456789')- endend