Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

random spec failures fixed

Damian Legawiecb59efa04f3e4
diff --git a/api/spec/models/spree/api_dependencies_spec.rb b/api/spec/models/spree/api_dependencies_spec.rb
index 42c0c60d94..793bda1c49 100644
--- a/api/spec/models/spree/api_dependencies_spec.rb
+++ b/api/spec/models/spree/api_dependencies_spec.rb
@@ -95,9 +95,10 @@ describe 'Spree.api accessor' do
let(:original_value) { Spree::Api::Dependencies.storefront_coupon_handler }
after do
- # Restore original value
- Spree::Api::Dependencies.instance_variable_set(:@storefront_coupon_handler, original_value)
- Spree::Api::Dependencies.instance_variable_set(:@overrides, {})
+ # Restore original value using setter (which clears memoization)
+ Spree::Api::Dependencies.storefront_coupon_handler = original_value
+ # Clear override tracking for this test
+ Spree::Api::Dependencies.instance_variable_get(:@overrides)&.delete(:storefront_coupon_handler)
end
it 'sets the dependency via Spree.api' do
diff --git a/core/spec/models/spree/app_dependencies_spec.rb b/core/spec/models/spree/app_dependencies_spec.rb
index fe4795c6ce..ea490393e9 100644
--- a/core/spec/models/spree/app_dependencies_spec.rb
+++ b/core/spec/models/spree/app_dependencies_spec.rb
@@ -161,9 +161,10 @@ describe 'Spree module dependency accessors' do
let(:original_value) { Spree::Dependencies.cart_add_item_service }
after do
- # Restore original value
- Spree::Dependencies.instance_variable_set(:@cart_add_item_service, original_value)
- Spree::Dependencies.instance_variable_set(:@overrides, {})
+ # Restore original value using setter (which clears memoization)
+ Spree::Dependencies.cart_add_item_service = original_value
+ # Clear override tracking for this test
+ Spree::Dependencies.instance_variable_get(:@overrides)&.delete(:cart_add_item_service)
end
it 'sets the dependency via Spree module' do