Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

We need to move initializers to after_initialize block

Damian Legawiecb8bcdd71d52b
diff --git a/core/lib/spree/core/engine.rb b/core/lib/spree/core/engine.rb
index 358669fcbd..b85f2cc62a 100644
--- a/core/lib/spree/core/engine.rb
+++ b/core/lib/spree/core/engine.rb
@@ -27,8 +27,38 @@ module Spree
Spree::Dependencies = app.config.spree.dependencies
end
- initializer 'spree.register.calculators' do |app|
- app.config.spree.calculators.shipping_methods = [
+ initializer 'spree.register.calculators', before: :after_initialize do |app|
+ end
+
+ initializer 'spree.register.stock_splitters', before: :load_config_initializers do |app|
+ end
+
+ initializer 'spree.register.line_item_comparison_hooks', before: :load_config_initializers do |app|
+ app.config.spree.line_item_comparison_hooks = Set.new
+ end
+
+ initializer 'spree.register.payment_methods', after: 'acts_as_list.insert_into_active_record' do |app|
+ end
+
+ initializer 'spree.register.adjustable_adjusters' do |app|
+ end
+
+ # We need to define promotions rules here so extensions and existing apps
+ # can add their custom classes on their initializer files
+ initializer 'spree.promo.environment' do |app|
+ app.config.spree.promotions = PromoEnvironment.new
+ app.config.spree.promotions.rules = []
+ end
+
+ initializer 'spree.promo.register.promotion.calculators' do |app|
+ end
+
+ # Promotion rules need to be evaluated on after initialize otherwise
+ # Spree.user_class would be nil and users might experience errors related
+ # to malformed model associations (Spree.user_class is only defined on
+ # the app initializer)
+ config.after_initialize do
+ Rails.application.config.spree.calculators.shipping_methods = [
Spree::Calculator::Shipping::FlatPercentItemTotal,
Spree::Calculator::Shipping::FlatRate,
Spree::Calculator::Shipping::FlexiRate,
@@ -37,48 +67,29 @@ module Spree
Spree::Calculator::Shipping::DigitalDelivery,
]
- app.config.spree.calculators.tax_rates = [
+ Rails.application.config.spree.calculators.tax_rates = [
Spree::Calculator::DefaultTax
]
- end
- initializer 'spree.register.stock_splitters', before: :load_config_initializers do |app|
- app.config.spree.stock_splitters = [
+ Rails.application.config.spree.stock_splitters = [
Spree::Stock::Splitter::ShippingCategory,
Spree::Stock::Splitter::Backordered,
Spree::Stock::Splitter::Digital
]
- end
-
- initializer 'spree.register.line_item_comparison_hooks', before: :load_config_initializers do |app|
- app.config.spree.line_item_comparison_hooks = Set.new
- end
- initializer 'spree.register.payment_methods', after: 'acts_as_list.insert_into_active_record' do |app|
- app.config.spree.payment_methods = [
+ Rails.application.config.spree.payment_methods = [
Spree::Gateway::Bogus,
Spree::Gateway::BogusSimple,
Spree::PaymentMethod::Check,
Spree::PaymentMethod::StoreCredit
]
- end
- initializer 'spree.register.adjustable_adjusters' do |app|
- app.config.spree.adjusters = [
+ Rails.application.config.spree.adjusters = [
Spree::Adjustable::Adjuster::Promotion,
Spree::Adjustable::Adjuster::Tax
]
- end
-
- # We need to define promotions rules here so extensions and existing apps
- # can add their custom classes on their initializer files
- initializer 'spree.promo.environment' do |app|
- app.config.spree.promotions = PromoEnvironment.new
- app.config.spree.promotions.rules = []
- end
- initializer 'spree.promo.register.promotion.calculators' do |app|
- app.config.spree.calculators.promotion_actions_create_adjustments = [
+ Rails.application.config.spree.calculators.promotion_actions_create_adjustments = [
Spree::Calculator::FlatPercentItemTotal,
Spree::Calculator::FlatRate,
Spree::Calculator::FlexiRate,
@@ -86,18 +97,12 @@ module Spree
Spree::Calculator::TieredFlatRate
]
- app.config.spree.calculators.promotion_actions_create_item_adjustments = [
+ Rails.application.config.spree.calculators.promotion_actions_create_item_adjustments = [
Spree::Calculator::PercentOnLineItem,
Spree::Calculator::FlatRate,
Spree::Calculator::FlexiRate
]
- end
- # Promotion rules need to be evaluated on after initialize otherwise
- # Spree.user_class would be nil and users might experience errors related
- # to malformed model associations (Spree.user_class is only defined on
- # the app initializer)
- config.after_initialize do
Rails.application.config.spree.promotions.rules.concat [
Spree::Promotion::Rules::ItemTotal,
Spree::Promotion::Rules::Product,
@@ -109,10 +114,8 @@ module Spree
Spree::Promotion::Rules::OptionValue,
Spree::Promotion::Rules::Country
]
- end
- initializer 'spree.promo.register.promotions.actions' do |app|
- app.config.spree.promotions.actions = [
+ Rails.application.config.spree.promotions.actions = [
Promotion::Actions::CreateAdjustment,
Promotion::Actions::CreateItemAdjustments,
Promotion::Actions::CreateLineItems,
@@ -120,6 +123,9 @@ module Spree
]
end
+ initializer 'spree.promo.register.promotions.actions' do |app|
+ end
+
# filter sensitive information during logging
initializer 'spree.params.filter' do |app|
app.config.filter_parameters += [