Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Refactor Data Feeds (#13684)

Damian Legawiecb9e530a9a00d
diff --git a/spree/api/app/controllers/spree/api/v3/store/data_feeds_controller.rb b/spree/api/app/controllers/spree/api/v3/store/data_feeds_controller.rb
new file mode 100644
index 0000000000..16edcc16f7
--- /dev/null
+++ b/spree/api/app/controllers/spree/api/v3/store/data_feeds_controller.rb
@@ -0,0 +1,20 @@
+module Spree
+ module Api
+ module V3
+ module Store
+ class DataFeedsController < Store::BaseController
+ skip_before_action :authenticate_api_key!
+ skip_before_action :authenticate_user
+
+ # GET /api/v3/store/feeds/:slug.xml
+ def show
+ data_feed = current_store.data_feeds.active.find_by!(slug: params[:slug])
+ presenter = data_feed.class.presenter_class.new(data_feed)
+
+ render xml: presenter.call
+ end
+ end
+ end
+ end
+ end
+end
diff --git a/spree/api/config/routes.rb b/spree/api/config/routes.rb
index 632bac3f34..fd15ff08d3 100644
--- a/spree/api/config/routes.rb
+++ b/spree/api/config/routes.rb
@@ -82,6 +82,9 @@ Spree::Core::Engine.add_routes do
# Digital Downloads
# Access via token in URL
get 'digitals/:token', to: 'digitals#show', as: :digital_download
+
+ # Data Feeds (public, no auth required)
+ resources :feeds, only: [:show], controller: 'data_feeds', param: :slug
end
end
end
diff --git a/spree/api/lib/spree/api/dependencies.rb b/spree/api/lib/spree/api/dependencies.rb
index 1d62f99131..514c002f3b 100644
--- a/spree/api/lib/spree/api/dependencies.rb
+++ b/spree/api/lib/spree/api/dependencies.rb
@@ -196,7 +196,6 @@ module Spree
platform_country_serializer: 'Spree::Api::V2::Platform::CountrySerializer',
platform_credit_card_serializer: 'Spree::Api::V2::Platform::CreditCardSerializer',
platform_customer_return_serializer: 'Spree::Api::V2::Platform::CustomerReturnSerializer',
- platform_data_feed_serializer: 'Spree::Api::V2::Platform::DataFeedSerializer',
platform_digital_link_serializer: 'Spree::Api::V2::Platform::DigitalLinkSerializer',
platform_digital_serializer: 'Spree::Api::V2::Platform::DigitalSerializer',
platform_gift_card_serializer: 'Spree::Api::V2::Platform::GiftCardSerializer',
diff --git a/spree/api/spec/controllers/spree/api/v3/store/data_feeds_controller_spec.rb b/spree/api/spec/controllers/spree/api/v3/store/data_feeds_controller_spec.rb
new file mode 100644
index 0000000000..4d5b782b76
--- /dev/null
+++ b/spree/api/spec/controllers/spree/api/v3/store/data_feeds_controller_spec.rb
@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+RSpec.describe Spree::Api::V3::Store::DataFeedsController, type: :controller do
+ render_views
+
+ include_context 'API v3 Store'
+
+ let!(:data_feed) { create(:google_data_feed, store: store, slug: 'test-feed') }
+
+ describe 'GET #show' do
+ it 'returns the feed XML without authentication' do
+ get :show, params: { slug: 'test-feed' }
+
+ expect(response).to have_http_status(:ok)
+ expect(response.content_type).to include('application/xml')
+ expect(response.body).to include('<rss')
+ expect(response.body).to include(store.name)
+ end
+
+ context 'when data feed is inactive' do
+ let!(:data_feed) { create(:google_data_feed, store: store, slug: 'inactive-feed', active: false) }
+
+ it 'returns 404' do
+ get :show, params: { slug: 'inactive-feed' }
+
+ expect(response).to have_http_status(:not_found)
+ end
+ end
+
+ context 'when data feed does not exist' do
+ it 'returns 404' do
+ get :show, params: { slug: 'nonexistent' }
+
+ expect(response).to have_http_status(:not_found)
+ end
+ end
+ end
+end
diff --git a/spree/core/app/models/spree/data_feed.rb b/spree/core/app/models/spree/data_feed.rb
index db1a7c2ab1..2f76e73079 100644
--- a/spree/core/app/models/spree/data_feed.rb
+++ b/spree/core/app/models/spree/data_feed.rb
@@ -5,6 +5,7 @@ module Spree
belongs_to :store, class_name: 'Spree::Store', foreign_key: 'store_id'
scope :for_store, ->(store) { where(store: store) }
+ scope :active, -> { where(active: true) }
before_validation :generate_slug
@@ -15,7 +16,7 @@ module Spree
end
def formatted_url
- "#{store.formatted_url}/api/v2/data_feeds/#{self.class.provider_name}/#{slug}.rss"
+ "#{store.formatted_url}/api/v3/store/feeds/#{slug}.xml"
end
private
@@ -34,6 +35,10 @@ module Spree
raise NotImplementedError
end
+ def presenter_class
+ raise NotImplementedError
+ end
+
def available_types
Spree.data_feed_types
end
diff --git a/spree/core/app/models/spree/data_feed/google.rb b/spree/core/app/models/spree/data_feed/google.rb
index 8e979abc05..85b596b937 100644
--- a/spree/core/app/models/spree/data_feed/google.rb
+++ b/spree/core/app/models/spree/data_feed/google.rb
@@ -10,6 +10,10 @@ module Spree
def provider_name
'google'
end
+
+ def presenter_class
+ Spree::DataFeeds::GooglePresenter
+ end
end
end
end
diff --git a/spree/core/app/presenters/spree/data_feeds/base_presenter.rb b/spree/core/app/presenters/spree/data_feeds/base_presenter.rb
new file mode 100644
index 0000000000..764d8aefa4
--- /dev/null
+++ b/spree/core/app/presenters/spree/data_feeds/base_presenter.rb
@@ -0,0 +1,23 @@
+module Spree
+ module DataFeeds
+ class BasePresenter
+ def initialize(data_feed)
+ @data_feed = data_feed
+ @store = data_feed.store
+ end
+
+ attr_reader :data_feed, :store
+
+ # @return [String] the feed content (XML, CSV, etc.)
+ def call
+ raise NotImplementedError
+ end
+
+ private
+
+ def products
+ store.products.active
+ end
+ end
+ end
+end
diff --git a/spree/core/app/presenters/spree/data_feeds/google_presenter.rb b/spree/core/app/presenters/spree/data_feeds/google_presenter.rb
new file mode 100644
index 0000000000..08bdbdfd21
--- /dev/null
+++ b/spree/core/app/presenters/spree/data_feeds/google_presenter.rb
@@ -0,0 +1,94 @@
+require 'nokogiri'
+
+module Spree
+ module DataFeeds
+ class GooglePresenter < BasePresenter
+ # @return [String] RSS XML feed for Google Merchant Center
+ def call
+ builder = Nokogiri::XML::Builder.new do |xml|
+ xml.rss('xmlns:g' => 'http://base.google.com/ns/1.0', 'version' => '2.0') do
+ xml.channel do
+ build_store_info(xml)
+ build_items(xml)
+ end
+ end
+ end
+
+ builder.to_xml
+ end
+
+ private
+
+ def build_store_info(xml)
+ xml.title store.name
+ xml.link store.url
+ xml.description store.meta_description
+ end
+
+ def build_items(xml)
+ products.includes(:variants_including_master, :properties, :product_properties).find_each do |product|
+ product.variants_including_master.active.each do |variant|
+ next if variant.is_master? && product.has_variants?
+
+ build_item(xml, product, variant)
+ end
+ end
+ end
+
+ def build_item(xml, product, variant)
+ image_url = image_link(variant, product)
+ return if image_url.nil?
+
+ xml.item do
+ build_required_attributes(xml, product, variant, image_url)
+ build_optional_attributes(xml, product)
+ end
+ end
+
+ def build_required_attributes(xml, product, variant, image_url)
+ xml['g'].id variant.id
+ xml['g'].item_group_id product.id
+ xml['g'].title format_title(product, variant)
+ xml['g'].description product.description || format_title(product, variant)
+ xml['g'].link "#{store.url}/products/#{product.slug}"
+ xml['g'].image_link image_url
+ xml['g'].price "#{variant.price} #{variant.cost_currency}"
+ xml['g'].availability availability(product)
+ xml['g'].availability_date product.available_on.xmlschema if product.available_on.present?
+ end
+
+ def build_optional_attributes(xml, product)
+ product.product_properties.includes(:property).each do |product_property|
+ name = product_property.property&.name
+ value = product_property.value
+
+ next if name.blank? || value.blank?
+
+ xml['g'].send(name, value)
+ end
+ end
+
+ def format_title(product, variant)
+ parts = [product.name]
+ variant.option_values.each do |option_value|
+ parts << option_value.name
+ end
+ parts.join(' - ')
+ end
+
+ def image_link(variant, product)
+ image = variant.thumbnail || product.thumbnail
+ return if image.nil?
+
+ Rails.application.routes.url_helpers.cdn_image_url(image.attachment.variant(:xlarge))
+ end
+
+ def availability(product)
+ return 'in stock' if product.available? && (product.available_on.nil? || product.available_on.past?)
+ return 'backorder' if product.backorderable? && product.backordered? && product.available_on&.future?
+
+ 'out of stock'
+ end
+ end
+ end
+end
diff --git a/spree/core/app/services/spree/data_feeds/google/optional_attributes.rb b/spree/core/app/services/spree/data_feeds/google/optional_attributes.rb
deleted file mode 100644
index 0959235352..0000000000
--- a/spree/core/app/services/spree/data_feeds/google/optional_attributes.rb
+++ /dev/null
@@ -1,23 +0,0 @@
-module Spree
- module DataFeeds
- module Google
- class OptionalAttributes
- prepend Spree::ServiceModule::Base
-
- def call(input)
- information = {}
-
- input[:product].property_ids.each do |key|
- name = Spree::Property.find(key)&.name
- value = input[:product].property(name)
- unless value.nil?
- information[name] = value
- end
- end
-
- success(information: information)
- end
- end
- end
- end
-end
diff --git a/spree/core/app/services/spree/data_feeds/google/optional_sub_attributes.rb b/spree/core/app/services/spree/data_feeds/google/optional_sub_attributes.rb
deleted file mode 100644
index 0f767a538c..0000000000
--- a/spree/core/app/services/spree/data_feeds/google/optional_sub_attributes.rb
+++ /dev/null
@@ -1,21 +0,0 @@
-module Spree
- module DataFeeds
- module Google
- class OptionalSubAttributes
- prepend Spree::ServiceModule::Base
-
- def call(input)
- information = {}
-
- # This is a place where you can put attributes that have sub-attributes, example for shipping:
- #
- # information['shipping'] = {}
- # information['shipping']['price'] = calculate_shipping(input[:product])
- # information['shipping']['country'] = input[:store].default_country
-
- success(information: information)
- end
- end
- end
- end
-end
diff --git a/spree/core/app/services/spree/data_feeds/google/products_list.rb b/spree/core/app/services/spree/data_feeds/google/products_list.rb
deleted file mode 100644
index 0279c240ce..0000000000
--- a/spree/core/app/services/spree/data_feeds/google/products_list.rb
+++ /dev/null
@@ -1,14 +0,0 @@
-module Spree
- module DataFeeds
- module Google
- class ProductsList
- prepend Spree::ServiceModule::Base
-
- def call(store)
- products = store.products.active
- success(products: products)
- end
- end
- end
- end
-end
diff --git a/spree/core/app/services/spree/data_feeds/google/required_attributes.rb b/spree/core/app/services/spree/data_feeds/google/required_attributes.rb
deleted file mode 100644
index 274354c44c..0000000000
--- a/spree/core/app/services/spree/data_feeds/google/required_attributes.rb
+++ /dev/null
@@ -1,63 +0,0 @@
-module Spree
- module DataFeeds
- module Google
- class RequiredAttributes
- prepend Spree::ServiceModule::Base
-
- def call(input)
- information = {}
-
- return failure(nil, error: 'No image link') if get_image_link(input[:variant], input[:product]).nil?
-
- information['id'] = input[:variant].id
- information['item_group_id'] = input[:product].id
- information['title'] = format_title(input[:product], input[:variant])
- information['description'] = get_description(input[:product], input[:variant])
- information['link'] = "#{input[:store].url}/products/#{input[:product].slug}"
- information['image_link'] = get_image_link(input[:variant], input[:product])
- information['price'] = format_price(input[:variant])
- information['availability'] = get_availability(input[:product])
- information['availability_date'] = input[:product].available_on&.xmlschema unless input[:product].available_on.nil?
-
- success(information: information)
- end
-
- private
-
- def format_title(product, variant)
- # Title of a variant is created by joining title of a product and variant's option_values, as they are
- # what differentiates it from other variants.
- parts = [product.name]
- variant.option_values.find_each do |option_value|
- parts << option_value.name
- end
- parts.join(' - ')
- end
-
- def get_description(product, variant)
- return product.description unless product.description.nil?
-
- format_title(product, variant)
- end
-
- def get_image_link(variant, product)
- image = variant.thumbnail || product.thumbnail
- return if image.nil?
-
- Rails.application.routes.url_helpers.cdn_image_url(image.attachment.variant(:xlarge))
- end
-
- def format_price(variant)
- "#{variant.price} #{variant.cost_currency}"
- end
-
- def get_availability(product)
- return 'in stock' if product.available? && (product.available_on.nil? || product.available_on.past?)
- return 'backorder' if product.backorderable? && product.backordered? && product.available_on&.future?
-
- 'out of stock'
- end
- end
- end
- end
-end
diff --git a/spree/core/app/services/spree/data_feeds/google/rss.rb b/spree/core/app/services/spree/data_feeds/google/rss.rb
deleted file mode 100644
index d7aa2a9c83..0000000000
--- a/spree/core/app/services/spree/data_feeds/google/rss.rb
+++ /dev/null
@@ -1,109 +0,0 @@
-require 'nokogiri'
-
-module Spree
- module DataFeeds
- module Google
- class Rss
- prepend Spree::ServiceModule::Base
-
- def call(settings)
- @settings = settings
-
- return failure(store, error: "Store with id: #{settings.store_id} does not exist.") if store.nil?
-
- builder = Nokogiri::XML::Builder.new do |xml|
- xml.rss('xmlns:g' => 'http://base.google.com/ns/1.0', 'version' => '2.0') do
- xml.channel do
- add_store_information_to_xml(xml)
- result = products_list.call(store)
- if result.success?
- result.value[:products].find_each do |product|
- product.variants_including_master.active.find_each do |variant|
- next if variant.is_master? && product.has_variants?
-
- add_variant_information_to_xml(xml, product, variant)
- end
- end
- end
- end
- end
- end
-
- success(file: builder.to_xml)
- end
-
- private
-
- def store
- return @store if defined? @store
-
- @store ||= Spree::Store.find_by(id: @settings.store_id)
- end
-
- def add_store_information_to_xml(xml)
- xml.title store.name
- xml.link store.url
- xml.description store.meta_description
- end
-
- def add_variant_information_to_xml(xml, product, variant)
- input = { product: product, variant: variant, settings: @settings, store: store }
- result = required_attributes.call(input)
-
- if result.success
- xml.item do
- result.value[:information]&.each do |key, value|
- xml['g'].send(key, value)
- end
-
- add_optional_information(xml, product, variant)
- add_optional_sub_attributes(xml, product, variant)
- end
- end
- end
-
- def add_optional_information(xml, product, variant)
- input = { product: product, variant: variant, settings: @settings, store: store }
- result = optional_attributes.call(input)
- if result.success?
- information = result.value[:information]
- information.each do |key, value|
- xml['g'].send(key, value)
- end
- end
- end
-
- def add_optional_sub_attributes(xml, product, variant)
- input = { product: product, variant: variant, settings: @settings, store: store }
- result = optional_sub_attributes.call(input)
- if result.success?
- information = result.value[:information]
- information.each do |key, value|
- xml['g'].send(key) do
- value.each do |subkey, subvalue|
- xml['g'].send(subkey, subvalue)
- end
- end
- end
- end
- end
-
- def optional_attributes
- Spree.data_feeds_google_optional_attributes_service.new
- end
-
- def required_attributes
- Spree.data_feeds_google_required_attributes_service.new
- end
-
- def optional_sub_attributes
- Spree.data_feeds_google_optional_sub_attributes_service.new
- end
-
- def products_list
- Spree.data_feeds_google_products_list.new
- end
- end
- end
- end
-end
diff --git a/spree/core/lib/spree/core/dependencies.rb b/spree/core/lib/spree/core/dependencies.rb
index 1a41985428..b1491a7d76 100644
--- a/spree/core/lib/spree/core/dependencies.rb
+++ b/spree/core/lib/spree/core/dependencies.rb
@@ -87,13 +87,6 @@ module Spree
payment_create_service: 'Spree::Payments::Create',
- # data feeds
- data_feeds_google_rss_service: 'Spree::DataFeeds::Google::Rss',
- data_feeds_google_optional_attributes_service: 'Spree::DataFeeds::Google::OptionalAttributes',
- data_feeds_google_required_attributes_service: 'Spree::DataFeeds::Google::RequiredAttributes',
- data_feeds_google_optional_sub_attributes_service: 'Spree::DataFeeds::Google::OptionalSubAttributes',
- data_feeds_google_products_list: 'Spree::DataFeeds::Google::ProductsList',
-
# finders
address_finder: 'Spree::Addresses::Find',
country_finder: 'Spree::Countries::Find',
diff --git a/spree/core/spec/models/spree/data_feed/google_spec.rb b/spree/core/spec/models/spree/data_feed/google_spec.rb
index a1d79e957a..feb84efcf5 100644
--- a/spree/core/spec/models/spree/data_feed/google_spec.rb
+++ b/spree/core/spec/models/spree/data_feed/google_spec.rb
@@ -23,7 +23,7 @@ describe Spree::DataFeed::Google, type: :model do
describe '#formatted_url' do
let(:data_feed) { create(:google_data_feed, store: store, slug: 'test-feed') }
- let(:expected_url) { 'http://store.test/api/v2/data_feeds/google/test-feed.rss' }
+ let(:expected_url) { 'http://store.test/api/v3/store/feeds/test-feed.xml' }
before do
allow(Rails.application.routes).to receive(:default_url_options).and_return(protocol: 'http', port: nil)
diff --git a/spree/core/spec/presenters/spree/data_feeds/google_presenter_spec.rb b/spree/core/spec/presenters/spree/data_feeds/google_presenter_spec.rb
new file mode 100644
index 0000000000..7ed1f9353c
--- /dev/null
+++ b/spree/core/spec/presenters/spree/data_feeds/google_presenter_spec.rb
@@ -0,0 +1,130 @@
+require 'spec_helper'
+
+RSpec.describe Spree::DataFeeds::GooglePresenter do
+ let(:store) { @default_store }
+ let(:data_feed) { create(:google_data_feed, store: store) }
+ let(:product) { create(:product, stores: [store]) }
+ let!(:variant) { create(:with_image_variant, product: product) }
+
+ subject { described_class.new(data_feed) }
+
+ describe '#call' do
+ let(:xml) { subject.call }
+
+ context 'store information' do
+ it 'includes store name' do
+ expect(xml).to include("<title>#{store.name}</title>")
+ end
+
+ it 'includes store url' do
+ expect(xml).to include("<link>#{store.url}</link>")
+ end
+
+ it 'includes store description' do
+ expect(xml).to include("<description>#{store.meta_description}</description>")
+ end
+ end
+
+ context 'required attributes' do
+ it 'includes variant id' do
+ expect(xml).to include("<g:id>#{variant.id}</g:id>")
+ end
+
+ it 'includes product id as item_group_id' do
+ expect(xml).to include("<g:item_group_id>#{product.id}</g:item_group_id>")
+ end
+
+ it 'includes title with variant option values' do
+ expect(xml).to include("<g:title>#{product.name} - #{variant.option_values.first.name}</g:title>")
+ end
+
+ it 'includes description' do
+ expect(xml).to include("<g:description>#{product.description}</g:description>")
+ end
+
+ it 'includes link' do
+ expect(xml).to include("<g:link>#{store.url}/products/#{product.slug}</g:link>")
+ end
+
+ it 'includes image link' do
+ image = variant.images.first
+ expected_url = Rails.application.routes.url_helpers.cdn_image_url(image.attachment.variant(:xlarge))
+ expect(xml).to include("<g:image_link>#{expected_url}</g:image_link>")
+ end
+
+ it 'includes price' do
+ expect(xml).to include("<g:price>#{variant.price} #{variant.cost_currency}</g:price>")
+ end
+ end
+
+ context 'availability' do
+ it 'shows in stock for available products' do
+ expect(xml).to include('<g:availability>in stock</g:availability>')
+ end
+
+ it 'includes availability date' do
+ expect(xml).to include("<g:availability_date>#{product.available_on.xmlschema}</g:availability_date>")
+ end
+
+ context 'when product is set to backorderable' do
+ let(:product) { create(:product, stores: [store], available_on: 1.year.from_now) }
+
+ it 'shows backorder' do
+ expect(xml).to include('<g:availability>backorder</g:availability>')
+ end
+ end
+
+ context 'when availability date is nil' do
+ let(:product) { create(:product, stores: [store], available_on: nil) }
+
+ it 'shows in stock' do
+ expect(xml).to include('<g:availability>in stock</g:availability>')
+ end
+
+ it 'does not include availability date' do
+ expect(xml).not_to include('<g:availability_date>')
+ end
+ end
+ end
+
+ context 'product with only master variant' do
+ let(:product) { create(:product, stores: [store]) }
+ let!(:variant) { nil }
+
+ before do
+ product.master.images << create(:image)
+ end
+
+ it 'includes master variant in feed' do
+ expect(xml).to include("<g:id>#{product.master.id}</g:id>")
+ end
+
+ it 'includes product name as title' do
+ expect(xml).to include("<g:title>#{product.name}</g:title>")
+ end
+ end
+
+ context 'optional attributes from product properties' do
+ let(:product) { create(:product_with_properties, stores: [store]) }
+
+ it 'includes product properties' do
+ expect(xml).to include("<g:brand>#{product.property('brand')}</g:brand>")
+ end
+ end
+
+ context 'title generation does not mutate product name' do
+ it 'generates independent titles for multiple variants' do
+ option_type = create(:option_type)
+ option_a = create(:option_value, name: 'option-a', option_type: option_type)
+ option_b = create(:option_value, name: 'option-b', option_type: option_type)
+
+ create(:with_image_variant, product: product, option_values: [option_a])
+ create(:with_image_variant, product: product, option_values: [option_b])
+
+ expect(xml).to include("#{product.name} - option-a</g:title>")
+ expect(xml).to include("#{product.name} - option-b</g:title>")
+ expect(xml).not_to include('option-a - option-b')
+ end
+ end
+ end
+end
diff --git a/spree/core/spec/services/spree/data_feeds/google/required_attributes_spec.rb b/spree/core/spec/services/spree/data_feeds/google/required_attributes_spec.rb
deleted file mode 100644
index 713bc4696d..0000000000
--- a/spree/core/spec/services/spree/data_feeds/google/required_attributes_spec.rb
+++ /dev/null
@@ -1,27 +0,0 @@
-require 'spec_helper'
-
-module Spree
- describe DataFeeds::Google::RequiredAttributes do
- subject { described_class.new }
-
- let(:store) { @default_store }
- let(:product) { create(:product, name: 'Test Product', stores: [store]) }
-
- describe '#call' do
- it 'does not mutate product name when generating titles for multiple variants' do
- option_type = create(:option_type)
- option_a = create(:option_value, name: 'option-a', option_type: option_type)
- option_b = create(:option_value, name: 'option-b', option_type: option_type)
-
- variant_a = create(:with_image_variant, product: product, option_values: [option_a])
- variant_b = create(:with_image_variant, product: product, option_values: [option_b])
-
- result_a = subject.call(product: product, variant: variant_a, store: store)
- result_b = subject.call(product: product, variant: variant_b, store: store)
-
- expect(result_a.value[:information]['title']).not_to include('option-b')
- expect(result_b.value[:information]['title']).not_to include('option-a')
- end
- end
- end
-end
diff --git a/spree/core/spec/services/spree/data_feeds/google/rss_spec.rb b/spree/core/spec/services/spree/data_feeds/google/rss_spec.rb
deleted file mode 100644
index ec51ac2211..0000000000
--- a/spree/core/spec/services/spree/data_feeds/google/rss_spec.rb
+++ /dev/null
@@ -1,127 +0,0 @@
-require 'spec_helper'
-
-module Spree
- describe DataFeeds::Google::Rss do
- subject { described_class.new }
-
- let(:store) { @default_store }
- let(:data_feed) { create(:google_data_feed, store: store) }
- let(:product) { create(:product, stores: [store]) }
- let!(:variant) { create(:with_image_variant, product: product) }
- let(:result) { subject.call(data_feed) }
-
- context 'store header is generated correctly' do
- before do
- allow(subject).to receive(:store).and_return(store)
- end
-
- it 'include store name' do
- expect(result.value[:file]).to include("<title>#{store.name}</title>").once
- end
-
- it 'includes store url' do
- expect(result.value[:file]).to include("<link>#{store.url}</link>").once
- end
-
- it 'includes store description' do
- expect(result.value[:file]).to include("<description>#{store.meta_description}</description>").once
- end
- end
-
- context 'required item attributes are generated correctly' do
- before do
- allow(subject).to receive(:store).and_return(store)
- end
-
- it 'includes id' do
- expect(result.value[:file]).to include("<g:id>#{variant.id}</g:id>").once
- end
-
- it 'includes product id as item_group_id' do
- expect(result.value[:file]).to include("<g:item_group_id>#{product.id}</g:item_group_id>").once
- end
-
- it 'includes title' do
- expect(result.value[:file]).to include("<g:title>#{product.name} - #{variant.option_values.first.name}</g:title>").once
- end
-
- it 'includes description' do
- expect(result.value[:file]).to include("<g:description>#{product.description}</g:description>").once
- end
-
- it 'includes link' do
- expect(result.value[:file]).to include("<g:link>#{store.url}/products/#{product.slug}</g:link>").once
- end
-
- it 'includes image link' do
- image = variant.images.first
- expected_url = Rails.application.routes.url_helpers.cdn_image_url(image.attachment.variant(:xlarge))
- expect(result.value[:file]).to include("<g:image_link>#{expected_url}</g:image_link>").once
- end
-
- it 'includes price' do
- expect(result.value[:file]).to include("<g:price>#{variant.price} #{variant.cost_currency}</g:price>").once
- end
-
- context 'product is set to available' do
- it 'shows that product is in stock' do
- expect(result.value[:file]).to include('<g:availability>in stock</g:availability>')
- end
-
- it 'shows that product availability date is the same' do
- expect(result.value[:file]).to include("<g:availability_date>#{product.available_on.xmlschema}</g:availability_date>")
- end
- end
-
- context 'product is set to backorderable' do
- let(:product) { create(:product, stores: [store], available_on: 1.year.from_now) }
-
- it 'shows that product is on backorder' do
- expect(result.value[:file]).to include('<g:availability>backorder</g:availability>')
- end
- end
-
- context 'availability date is nil' do
- let(:product) { create(:product, stores: [store], available_on: nil) }
-
- it 'shows that product is in stock' do
- expect(result.value[:file]).to include('<g:availability>in stock</g:availability>')
- end
-
- it 'shows that product availability date is nil' do
- expect(result.value[:file]).not_to include('<g:availability_date>')
- end
- end
- end
-
- context 'product with only master variant' do
- let(:product) { create(:product, stores: [store]) }
- let!(:variant) { nil }
-
- before do
- product.master.images << create(:image)
- allow(subject).to receive(:store).and_return(store)
- end
-
- it 'includes master variant in feed' do
- expect(result.value[:file]).to include("<g:id>#{product.master.id}</g:id>")
- end
-
- it 'includes product name as title' do
- expect(result.value[:file]).to include("<g:title>#{product.name}</g:title>")
- end
- end
-
- context 'optional item attributes are generated correctly' do
- let(:product) { create(:product_with_properties, stores: [store]) }
-
- before do
- allow(subject).to receive(:store).and_return(store)
- end
-
- it 'adds brand to item attributes' do
- expect(result.value[:file]).to include("<g:brand>#{product.property('brand')}</g:brand>")
- end
- end
- end
-end