Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
We cannot create Orders without Store associated and use Store currency by default
Damian Legawiecbc7838185c53
diff --git a/core/app/services/spree/cart/create.rb b/core/app/services/spree/cart/create.rbindex 827edc06fb..fed6660a55 100644--- a/core/app/services/spree/cart/create.rb+++ b/core/app/services/spree/cart/create.rb@@ -6,9 +6,12 @@ module Spreedef call(user:, store:, currency:, order_params: nil)order_params ||= {}+ # we cannot create an order without store+ return failure(:store_is_required) if store.nil?+default_params = {user: user,- currency: currency,+ currency: currency || store.default_currency,token: Spree::GenerateToken.new.call(Spree::Order)}diff --git a/core/spec/services/spree/cart/create_spec.rb b/core/spec/services/spree/cart/create_spec.rbindex b3b85e3d07..346a20b5af 100644--- a/core/spec/services/spree/cart/create_spec.rb+++ b/core/spec/services/spree/cart/create_spec.rb@@ -5,7 +5,7 @@ module Spreesubject { described_class }let(:user) { create :user }- let(:store) { create :store }+ let(:store) { create :store, default_currency: 'EUR' }let(:currency) { 'USD' }let(:expected) { Order.first }@@ -24,7 +24,7 @@ module Spreecontext 'create an order with store in params' dolet(:store_2) { create :store }let(:order_params) { { store: store_2, currency: 'XVII' } }- let(:execute) { subject.call user: user, store: store, currency: currency, order_params: order_params }+ let(:execute) { subject.call user: user, store: store_2, currency: currency, order_params: order_params }let(:value) { execute.value }it do@@ -38,19 +38,31 @@ module Spreeendend- context 'create an order when no store and currency pass in params' do- let!(:default_store) { create :store, default: true }- let(:execute) { subject.call user: user, store: nil, currency: nil }+ context 'create an order with store currency' do+ let(:order_params) { { store: store, currency: nil } }+ let(:execute) { subject.call user: user, store: store, currency: currency, order_params: order_params }let(:value) { execute.value }it doexpect { execute }.to change(Order, :count)expect(execute).to be_successexpect(value).to eq expected- expect(expected.currency).to eq Spree::Config[:currency]- expect(expected.store).to eq Spree::Store.default+ expect(expected.user).to eq user+ expect(expected.store).to eq store+ expect(expected.currency).to eq 'EUR'expect(expected.number).to be_presentendend++ context 'returns failure when no store is passed' do+ let!(:default_store) { create :store, default: true }+ let(:execute) { subject.call user: user, store: nil, currency: nil }+ let(:value) { execute.value }++ it do+ expect { execute }.not_to change(Order, :count)+ expect(execute).to be_failure+ end+ endendend