Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

We cannot create Orders without Store associated and use Store currency by default

Damian Legawiecbc7838185c53
diff --git a/core/app/services/spree/cart/create.rb b/core/app/services/spree/cart/create.rb
index 827edc06fb..fed6660a55 100644
--- a/core/app/services/spree/cart/create.rb
+++ b/core/app/services/spree/cart/create.rb
@@ -6,9 +6,12 @@ module Spree
def call(user:, store:, currency:, order_params: nil)
order_params ||= {}
+ # we cannot create an order without store
+ return failure(:store_is_required) if store.nil?
+
default_params = {
user: user,
- currency: currency,
+ currency: currency || store.default_currency,
token: Spree::GenerateToken.new.call(Spree::Order)
}
diff --git a/core/spec/services/spree/cart/create_spec.rb b/core/spec/services/spree/cart/create_spec.rb
index b3b85e3d07..346a20b5af 100644
--- a/core/spec/services/spree/cart/create_spec.rb
+++ b/core/spec/services/spree/cart/create_spec.rb
@@ -5,7 +5,7 @@ module Spree
subject { described_class }
let(:user) { create :user }
- let(:store) { create :store }
+ let(:store) { create :store, default_currency: 'EUR' }
let(:currency) { 'USD' }
let(:expected) { Order.first }
@@ -24,7 +24,7 @@ module Spree
context 'create an order with store in params' do
let(:store_2) { create :store }
let(:order_params) { { store: store_2, currency: 'XVII' } }
- let(:execute) { subject.call user: user, store: store, currency: currency, order_params: order_params }
+ let(:execute) { subject.call user: user, store: store_2, currency: currency, order_params: order_params }
let(:value) { execute.value }
it do
@@ -38,19 +38,31 @@ module Spree
end
end
- context 'create an order when no store and currency pass in params' do
- let!(:default_store) { create :store, default: true }
- let(:execute) { subject.call user: user, store: nil, currency: nil }
+ context 'create an order with store currency' do
+ let(:order_params) { { store: store, currency: nil } }
+ let(:execute) { subject.call user: user, store: store, currency: currency, order_params: order_params }
let(:value) { execute.value }
it do
expect { execute }.to change(Order, :count)
expect(execute).to be_success
expect(value).to eq expected
- expect(expected.currency).to eq Spree::Config[:currency]
- expect(expected.store).to eq Spree::Store.default
+ expect(expected.user).to eq user
+ expect(expected.store).to eq store
+ expect(expected.currency).to eq 'EUR'
expect(expected.number).to be_present
end
end
+
+ context 'returns failure when no store is passed' do
+ let!(:default_store) { create :store, default: true }
+ let(:execute) { subject.call user: user, store: nil, currency: nil }
+ let(:value) { execute.value }
+
+ it do
+ expect { execute }.not_to change(Order, :count)
+ expect(execute).to be_failure
+ end
+ end
end
end