Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Stop eager-loading the associations the certificate no longer has

Łukasz Adamczykbef1dcdf959e
diff --git a/spree/api/app/controllers/spree/api/v3/admin/companies/tax_exemption_certificates_controller.rb b/spree/api/app/controllers/spree/api/v3/admin/companies/tax_exemption_certificates_controller.rb
index 7ad0366d64..b53e42ea19 100644
--- a/spree/api/app/controllers/spree/api/v3/admin/companies/tax_exemption_certificates_controller.rb
+++ b/spree/api/app/controllers/spree/api/v3/admin/companies/tax_exemption_certificates_controller.rb
@@ -93,7 +93,7 @@ module Spree
end
def collection_includes
- [:country, :state, { document_attachment: :blob }]
+ [{ document_attachment: :blob }]
end
# `document` is an ActiveStorage signed blob id from
diff --git a/spree/api/spec/controllers/spree/api/v3/admin/companies/tax_exemption_certificates_controller_spec.rb b/spree/api/spec/controllers/spree/api/v3/admin/companies/tax_exemption_certificates_controller_spec.rb
index bf785419e3..118a5cf27e 100644
--- a/spree/api/spec/controllers/spree/api/v3/admin/companies/tax_exemption_certificates_controller_spec.rb
+++ b/spree/api/spec/controllers/spree/api/v3/admin/companies/tax_exemption_certificates_controller_spec.rb
@@ -69,7 +69,7 @@ RSpec.describe Spree::Api::V3::Admin::Companies::TaxExemptionCertificatesControl
expect(response).to have_http_status(:created)
expect(json_response['status']).to eq('pending')
expect(json_response['country_iso']).to eq('DE')
- expect(company.tax_exemption_certificates.sole.country).to eq(germany)
+ expect(company.tax_exemption_certificates.sole.country_iso).to eq(germany.iso)
end
it 'attaches a document from a direct upload' do