Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fix code injection warning in AssetsController

Damian Legawiecc124bbd8d62d
diff --git a/spree/api/app/controllers/spree/api/v3/admin/products/assets_controller.rb b/spree/api/app/controllers/spree/api/v3/admin/products/assets_controller.rb
index 3498251218..4dd4f29940 100644
--- a/spree/api/app/controllers/spree/api/v3/admin/products/assets_controller.rb
+++ b/spree/api/app/controllers/spree/api/v3/admin/products/assets_controller.rb
@@ -35,16 +35,17 @@ module Spree
:images
end
+ ALLOWED_ASSET_TYPES = -> { [Spree::Asset, *Spree::Asset.descendants].map(&:name).to_set.freeze }
+
def build_resource
asset_type = permitted_params[:type] || 'Spree::Image'
- asset_class = asset_type.safe_constantize
- unless asset_class && asset_class <= Spree::Asset
+ unless ALLOWED_ASSET_TYPES.call.include?(asset_type)
raise ArgumentError, "Invalid asset type: #{asset_type}"
end
asset = @parent.images.build(permitted_params.except(:type, :variant_ids))
- asset.type = asset_class.name
+ asset.type = asset_type
asset
end