Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Added admin product management feature specs (#12776)
Damian Legawiecc16b85f83cda
diff --git a/admin/app/views/spree/admin/products/_list.html.erb b/admin/app/views/spree/admin/products/_list.html.erbindex 619e61ac09..e9277d9c58 100644--- a/admin/app/views/spree/admin/products/_list.html.erb+++ b/admin/app/views/spree/admin/products/_list.html.erb@@ -15,8 +15,11 @@<%= sort_link @search,:name,Spree.t(:name),- { default_order: "desc" },- { title: "admin_products_listing_name_title" } %>+ {+ default_order: "desc",+ title: "admin_products_listing_name_title"+ }+ %></th><th scope="col" class="text-center"><%= Spree.t(:status) %>diff --git a/admin/lib/spree/admin/testing_support/tom_select.rb b/admin/lib/spree/admin/testing_support/tom_select.rbnew file mode 100644index 0000000000..25efa36f81--- /dev/null+++ b/admin/lib/spree/admin/testing_support/tom_select.rb@@ -0,0 +1,17 @@+module Spree+ module Admin+ module TestingSupport+ module TomSelect+ def tom_select(value, from:, create: false)+ fill_in(from, with: value, visible: false)++ if create+ first('.ts-dropdown .ts-dropdown-content .create.active').click+ else+ first('.ts-dropdown .ts-dropdown-content .option', text: /#{Regexp.quote(value)}/i).click+ end+ end+ end+ end+ end+enddiff --git a/admin/spec/features/spree/admin/products/edit/taxons_spec.rb b/admin/spec/features/spree/admin/products/edit/taxons_spec.rbnew file mode 100644index 0000000000..c852d5cd2a--- /dev/null+++ b/admin/spec/features/spree/admin/products/edit/taxons_spec.rb@@ -0,0 +1,32 @@+require 'spec_helper'++describe 'Product Taxons', type: :feature, js: true do+ stub_authorization!++ let(:store) { Spree::Store.default }+ let(:taxonomy) { store.taxonomies.find_or_create_by(name: 'Categories') }++ context 'managing taxons' do+ let!(:taxon_1) { create(:taxon, taxonomy: taxonomy) }+ let!(:taxon_2) { create(:taxon, name: 'Clothing', taxonomy: taxonomy) }+ let(:product) { create(:product, stores: [store]) }++ before do+ product.taxons << taxon_1+ end++ it 'allows an admin to manage taxons' do+ visit spree.edit_admin_product_path(product)++ expect(page).to have_content(taxon_1.pretty_name.to_s)+ expect(page).not_to have_content(taxon_2.pretty_name.to_s)++ tom_select(taxon_2.pretty_name, from: Spree.t(:taxonomies))++ within('#page-header') { click_button 'Update' }++ expect(page).to have_content(taxon_1.pretty_name.to_s)+ expect(page).to have_content(taxon_2.pretty_name.to_s)+ end+ end+enddiff --git a/admin/spec/features/spree/admin/products/option_types_spec.rb b/admin/spec/features/spree/admin/products/option_types_spec.rbnew file mode 100644index 0000000000..0a3de790a6--- /dev/null+++ b/admin/spec/features/spree/admin/products/option_types_spec.rb@@ -0,0 +1,72 @@+require 'spec_helper'++describe 'Option Types', type: :feature do+ stub_authorization!+ describe 'listing option types' do+ before do+ Spree::OptionType.find_or_create_by(presentation: 'Color')+ Spree::OptionType.find_or_create_by(presentation: 'Size')+ end++ it 'lists existing option types' do+ visit spree.admin_option_types_path+ within('#listing_option_types') do+ expect(page).to have_content('Color')+ expect(page).to have_content('color')+ expect(page).to have_content('Size')+ expect(page).to have_content('size')+ end+ end+ end++ describe 'creating and updating a new option type' do+ it 'allows an admin to create a new option type' do+ visit spree.new_admin_option_type_path+ fill_in 'Presentation', with: 'Hat Size'+ click_button 'Create'+ expect(page).to have_content('successfully created!')++ fill_in 'Presentation', with: 'Hat Size Updated'+ within('#page-header') { click_button 'Update' }+ expect(page).to have_content('successfully updated!')+ end+ end++ describe 'manaing option values', js: true do+ let(:option_type) { create(:option_type) }++ it 'allows an admin to manage option values' do+ visit spree.edit_admin_option_type_path(option_type)++ within('#option_values') do+ within_row(1) do+ find('td.presentation').find('input:first-child').set('Small')+ end++ click_button 'add_option_value_button'++ within_row(2) do+ find('td.presentation').find('input:first-child').set('Large')+ end+ end++ within('#page-header') { click_button 'Update' }+ expect(page).to have_content('successfully updated!')++ expect(option_type.option_values.pluck(:presentation)).to include('Small', 'Large')+ expect(option_type.option_values.pluck(:name)).to include('small', 'large')++ within('#option_values') do+ within_row(2) do+ find('.remove_option_value_button').click+ end+ end++ within('#page-header') { click_button 'Update' }+ expect(page).to have_content('successfully updated!')++ expect(option_type.option_values.pluck(:presentation)).to include('Small')+ expect(option_type.option_values.pluck(:name)).to include('small')+ end+ end+enddiff --git a/admin/spec/features/spree/admin/products/products_spec.rb b/admin/spec/features/spree/admin/products/products_spec.rbnew file mode 100644index 0000000000..082fb94d3a--- /dev/null+++ b/admin/spec/features/spree/admin/products/products_spec.rb@@ -0,0 +1,335 @@+require 'spec_helper'++describe 'Products', type: :feature do+ let(:store) { Spree::Store.default }++ context 'as admin user' do+ stub_authorization!++ def build_option_type_with_values(name, values)+ ot = Spree::OptionType.find_by(name: name) || FactoryBot.create(:option_type, name: name)+ values.each do |val|+ ot.option_values.create(name: val.downcase, presentation: val)+ end+ ot+ end++ context 'listing products' do+ context 'sorting' do+ before do+ create(:product, name: 'apache baseball cap', price: 10)+ create(:product, name: 'zomg shirt', price: 5)+ end++ it 'lists existing products with correct sorting by name' do+ visit spree.admin_products_path+ # Name ASC+ within_row(1) { expect(page).to have_content('apache baseball cap') }+ within_row(2) { expect(page).to have_content('zomg shirt') }++ # Name DESC+ click_link 'admin_products_listing_name_title'+ within_row(1) { expect(page).to have_content('zomg shirt') }+ within_row(2) { expect(page).to have_content('apache baseball cap') }+ end+ end++ context 'currency displaying' do+ context 'using Russian Rubles' do+ before do+ Spree::Store.default.update!(default_currency: 'RUB')+ create(:product, name: 'Just a product', price: 19.99)+ end++ # Regression test for #2737+ context 'uses руб as the currency symbol' do+ it 'on the products listing page' do+ visit spree.admin_products_path+ within_row(1) { expect(page).to have_content('19.99 ₽') }+ end+ end+ end+ end++ context 'all products page' do+ let!(:active_product) { create(:product, status: 'active') }+ let!(:archived_product) { create(:product, status: 'archived') }++ it 'lists only non-archived products' do+ visit spree.admin_products_path+ expect(page).to have_content(active_product.name)+ expect(page).not_to have_content(archived_product.name)+ end+ end+ end++ context 'searching products' do+ it 'is able to search products by their properties' do+ create(:product, name: 'apache baseball cap', sku: 'A100')+ create(:product, name: 'zomg shirt')++ visit spree.admin_products_path+ fill_in 'q_multi_search', with: 'cap'+ within('main') { click_on 'Filter Results' }++ expect(page).to have_content('apache baseball cap')+ expect(page).not_to have_content('zomg shirt')+ end++ describe 'Products index tabs' do+ let!(:draft_product) { create(:product, status: 'draft') }+ let!(:pre_order_product) { create(:product, status: 'draft', available_on: 1.week.from_now) }+ let!(:active_product) { create(:product, status: 'active') }+ let!(:archived_product) { create(:product, status: 'archived') }+ let!(:deleted_product) { create(:product, status: 'archived', deleted_at: 1.day.ago) }++ before do+ visit spree.admin_products_path+ end++ context 'all products' do+ before do+ click_link 'All statuses'+ end++ it 'shows all the products without deleted' do+ expect(page).to have_content(draft_product.name)+ expect(page).to have_content(pre_order_product.name)+ expect(page).to have_content(active_product.name)+ expect(page).not_to have_content(archived_product.name)+ expect(page).not_to have_content(deleted_product.name)+ end+ end++ context 'active products' do+ before do+ click_link 'Active'+ end++ it 'shows all the active products without deleted' do+ expect(page).not_to have_content(draft_product.name)+ expect(page).not_to have_content(pre_order_product.name)+ expect(page).to have_content(active_product.name)+ expect(page).not_to have_content(archived_product.name)+ expect(page).not_to have_content(deleted_product.name)+ end+ end++ context 'draft products' do+ before do+ click_link 'Draft'+ end++ it 'shows all the draft products without deleted' do+ expect(page).to have_content(draft_product.name)+ expect(page).to have_content(pre_order_product.name)+ expect(page).not_to have_content(active_product.name)+ expect(page).not_to have_content(archived_product.name)+ expect(page).not_to have_content(deleted_product.name)+ end+ end++ context 'archived products' do+ before do+ click_link 'Archived'+ end++ it 'shows all the archived products without deleted' do+ expect(page).not_to have_content(draft_product.name)+ expect(page).not_to have_content(pre_order_product.name)+ expect(page).not_to have_content(active_product.name)+ expect(page).to have_content(archived_product.name)+ expect(page).not_to have_content(deleted_product.name)+ end+ end+ end+ end++ context 'updating a product' do+ let(:product) { create(:product, stores: Spree::Store.all) }++ let(:prototype) do+ size = build_option_type_with_values('size', %w(Small Medium Large))+ FactoryBot.create(:prototype, name: 'Size', option_types: [size])+ end++ before do+ @option_type_prototype = prototype+ @property_prototype = create(:prototype, name: 'Random')+ end++ it 'parses correctly available_on' do+ visit spree.edit_admin_product_path(product)+ fill_in 'product_available_on', with: '2012/12/25'+ within('#page-header') { click_button 'Update' }+ expect(page).to have_content('successfully updated!')+ expect(Spree::Product.last.available_on.to_date).to eq('2012-12-25'.to_date)+ end++ context 'using a locale with a different decimal format' do+ before do+ # change English locale's separator and delimiter to match 19,99 format+ I18n.backend.store_translations(+ :en,+ number: {+ currency: {+ format: {+ separator: ',',+ delimiter: '.'+ }+ },+ format: {+ separator: ',',+ delimiter: '.'+ }+ }+ )+ end++ after do+ # revert changes to English locale+ I18n.backend.store_translations(+ :en,+ number: {+ currency: {+ format: {+ separator: '.',+ delimiter: ','+ }+ },+ format: {+ separator: '.',+ delimiter: ','+ }+ }+ )+ end++ it 'parses correctly decimal values like weight' do+ visit spree.edit_admin_product_path(product)+ fill_in 'product_weight', with: '1'+ within('#page-header') { click_button 'Update' }+ weight_prev = find('#product_weight').value+ within('#page-header') { click_button 'Update' }+ expect(page).to have_field(id: 'product_weight', with: weight_prev)+ end+ end++ context 'changing the status' do+ context 'from draft' do+ before { product.update_column(:status, 'draft') }++ it 'to active' do+ change_status_and_update_record(to: 'Active')+ end+ end++ context 'from active' do+ it 'to draft' do+ change_status_and_update_record(to: 'Draft')+ end+ end++ context 'from archived' do+ before { product.update_column(:status, 'archived') }++ it 'to draft' do+ change_status_and_update_record(to: 'Draft')+ end++ it 'to active' do+ change_status_and_update_record(to: 'Active')+ end+ end++ def change_status_and_update_record(to:)+ visit spree.edit_admin_product_path(product)+ select to, from: 'product_status'+ within('#page-header') { click_button 'Update' }+ expect(page).to have_content('successfully updated')+ expect(product.reload.status).to eq(to.downcase.split(' ').join('_'))+ end+ end+ end++ describe 'product editing' do+ let(:product) { create(:product) }++ before do+ visit spree.edit_admin_product_path(product)+ end++ it 'correctly edits the product' do+ fill_in 'product_name', with: 'Test Product 123'+ fill_in 'product_description', with: 'This is a test product 123'+ fill_in 'product_master_attributes_prices_attributes_0_amount', with: 100+ fill_in 'product_master_attributes_prices_attributes_0_compare_at_amount', with: 200+ fill_in 'product_width', with: 10+ fill_in 'product_height', with: 10+ fill_in 'product_depth', with: 10+ fill_in 'product_weight', with: 10+ fill_in 'product_sku', with: '123456'+ fill_in 'product_barcode', with: '123456'+ fill_in 'product_master_attributes_stock_items_attributes_0_count_on_hand', with: 10+ within('#page-header') { click_button 'Update' }++ expect(page).to have_content('successfully updated')+ product.reload++ expect(product.name).to eq('Test Product 123')+ expect(product.description).to eq('This is a test product 123')+ expect(product.price_in('USD').amount).to eq(100)+ expect(product.price_in('USD').compare_at_amount).to eq(200)+ expect(product.width).to eq(10)+ expect(product.height).to eq(10)+ expect(product.depth).to eq(10)+ expect(product.weight).to eq(10)+ expect(product.sku).to eq('123456')+ expect(product.barcode).to eq('123456')+ expect(product.master.stock_items.first.count_on_hand).to eq(10)+ end+ end++ context 'filtering products', js: true do+ it 'renders selected filters' do+ visit spree.admin_products_path++ within 'main' do+ click_on 'Filters'+ end++ fill_in 'q_multi_search', with: 'Backpack'++ within('main') { click_on 'Filter Results' }++ within('.filter-badges-container') do+ expect(page).to have_content('Query: Backpack')+ end+ end++ context 'by tag' do+ let(:product_without_tag) { create(:product, stores: [store]) }+ let(:product) { create(:product, stores: [store]) }++ before do+ product.tag_list.add('some tag')+ product.save+ end++ it 'filters products with tag only' do+ visit spree.admin_products_path++ within('main') { click_on 'Filter' }+ fill_in 'Tags', with: 'some tag'++ find('.ts-dropdown').click+ find('#q_tags_name_in-ts-label').click+ click_on 'Filter Results'++ expect(page).to have_content(product.name)+ expect(page).not_to have_content(product_without_tag.name)+ end+ end+ end+ end+enddiff --git a/admin/spec/features/spree/admin/products/properties_spec.rb b/admin/spec/features/spree/admin/products/properties_spec.rbnew file mode 100644index 0000000000..cce8cbbc2b--- /dev/null+++ b/admin/spec/features/spree/admin/products/properties_spec.rb@@ -0,0 +1,56 @@+require 'spec_helper'++describe 'Properties spec', type: :feature do+ stub_authorization!++ describe 'creating property' do+ before do+ visit spree.new_admin_property_path+ end++ it 'allows to create new property' do+ fill_in 'property_presentation', with: 'Country of Origin'+ select('Long text', from: 'Kind')+ click_button 'Create'++ expect(page).to have_content 'successfully created!'++ property = Spree::Property.last+ expect(property.presentation).to eq('Country of Origin')+ expect(property.name).to eq('country-of-origin')+ expect(property.kind).to eq('long_text')+ end+ end++ context 'listing properties', js: true do+ before do+ create(:property, name: 'ingredients', presentation: 'Ingredients', position: 2)+ create(:property, name: 'materials', presentation: 'Materials', position: 1)+ end++ it 'lists existing properties' do+ visit spree.admin_properties_path+ within('table') do+ within_row(1) do+ expect(page).to have_content('materials')+ end+ within_row(2) do+ expect(page).to have_content('ingredients')+ end+ end+ end++ it 'can change property display on from list view' do+ visit spree.admin_properties_path+ within_row(1) do+ expect(page).to have_content('materials')+ select 'Only on admin panel', from: 'property_display_on'+ end++ expect(page).to have_content('successfully updated!')++ property = Spree::Property.find_by(name: 'materials')+ expect(property.display_on).to eq('back_end')+ end+ end+enddiff --git a/admin/spec/spec_helper.rb b/admin/spec/spec_helper.rbindex 4e1a2a76df..c5e69587ba 100644--- a/admin/spec/spec_helper.rb+++ b/admin/spec/spec_helper.rb@@ -45,6 +45,7 @@ require 'spree/testing_support/controller_requests'require 'spree/testing_support/url_helpers'require 'spree/testing_support/order_walkthrough'require 'spree/admin/testing_support/capybara_utils'+require 'spree/admin/testing_support/tom_select'require 'spree/testing_support/capybara_config'require 'spree/testing_support/rspec_retry_config'require 'spree/testing_support/image_helpers'@@ -88,6 +89,7 @@ RSpec.configure do |config|config.include FactoryBot::Syntax::Methodsconfig.include Spree::Admin::TestingSupport::CapybaraUtils+ config.include Spree::Admin::TestingSupport::TomSelectconfig.include Spree::TestingSupport::Preferencesconfig.include Spree::TestingSupport::UrlHelpersconfig.include Spree::TestingSupport::ControllerRequests, type: :controller