Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

FIX exports strong params (#12785)

brozekc259695c39e8
diff --git a/admin/spec/controllers/spree/admin/exports_controller_spec.rb b/admin/spec/controllers/spree/admin/exports_controller_spec.rb
index 76ade51326..24d9d29e1b 100644
--- a/admin/spec/controllers/spree/admin/exports_controller_spec.rb
+++ b/admin/spec/controllers/spree/admin/exports_controller_spec.rb
@@ -24,7 +24,7 @@ describe Spree::Admin::ExportsController, type: :controller do
end
describe '#new' do
- subject { get :new, params: { export: { type: 'Spree::Exports::Products', search_params: { name_cont: 'Product' }.as_json } } }
+ subject { get :new, params: { export: { type: 'Spree::Exports::Products', search_params: { name_cont: 'Product' }.to_json } } }
it 'renders the new template' do
expect(subject).to render_template(:new)
@@ -33,7 +33,7 @@ describe Spree::Admin::ExportsController, type: :controller do
it 'assigns permitted params' do
subject
expect(assigns(:export).type).to eq('Spree::Exports::Products')
- expect(assigns(:export).search_params).to eq({ 'name_cont' => 'Product' })
+ expect(assigns(:export).search_params).to eq({ 'name_cont' => 'Product' }.to_json)
end
end
@@ -47,7 +47,7 @@ describe Spree::Admin::ExportsController, type: :controller do
format: 'csv',
search_params: {
name_cont: 'Product'
- }.as_json,
+ }.to_json,
record_selection: 'filtered'
}
}
@@ -59,7 +59,7 @@ describe Spree::Admin::ExportsController, type: :controller do
export = Spree::Exports::Products.last
expect(export.user).to eq(controller.try_spree_current_user)
expect(export.format).to eq('csv')
- expect(export.search_params).to eq({ 'name_cont' => 'Product' })
+ expect(export.search_params).to eq({ 'name_cont' => 'Product' }.to_json)
end
it 'sets a flash message' do
diff --git a/core/lib/spree/permitted_attributes.rb b/core/lib/spree/permitted_attributes.rb
index 801770d96c..d35b278ab6 100644
--- a/core/lib/spree/permitted_attributes.rb
+++ b/core/lib/spree/permitted_attributes.rb
@@ -103,7 +103,7 @@ module Spree
@@digital_link_attributes = [:access_counter]
- @@export_attributes = [:type, :format, :record_selection, search_params: {}]
+ @@export_attributes = [:type, :format, :record_selection, :search_params]
@@image_attributes = [:alt, :attachment, :position, :viewable_type, :viewable_id]