Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Tests for DataFeed model and feed generation service.

wjwitekc3a1133bd20b
diff --git a/api/spec/controllers/spree/api/v2/storefront/store_controller_spec.rb b/api/spec/controllers/spree/api/v2/storefront/store_controller_spec.rb
new file mode 100644
index 0000000000..07e8df11f8
--- /dev/null
+++ b/api/spec/controllers/spree/api/v2/storefront/store_controller_spec.rb
@@ -0,0 +1,2 @@
+# frozen_string_literal: true
+
diff --git a/core/app/services/spree/export/google_rss.rb b/core/app/services/spree/export/google_rss.rb
index 74364a37ce..b0886eb7c0 100644
--- a/core/app/services/spree/export/google_rss.rb
+++ b/core/app/services/spree/export/google_rss.rb
@@ -42,7 +42,7 @@ module Spree
xml['g'].image_link get_image_link(variant, product)
xml['g'].price format_price(variant)
xml['g'].availability get_availability(product)
- xml['g'].availability_date product.available_on.xmlschema
+ xml['g'].availability_date product.available_on&.xmlschema unless product.available_on.nil?
add_optional_information(xml, product)
end
@@ -77,11 +77,11 @@ module Spree
end
def format_price(variant)
- "#{variant.cost_price} #{variant.cost_currency}"
+ "#{variant.price} #{variant.cost_currency}"
end
def get_availability(product)
- return 'in stock' if product.available_on.past?
+ return 'in stock' if product.available_on&.past?
return 'backorder' unless product.available_on.nil?
'out of stock'
diff --git a/core/lib/spree/testing_support/factories/google_feed_setting_factory.rb b/core/lib/spree/testing_support/factories/google_feed_setting_factory.rb
new file mode 100644
index 0000000000..e727e567d4
--- /dev/null
+++ b/core/lib/spree/testing_support/factories/google_feed_setting_factory.rb
@@ -0,0 +1,6 @@
+FactoryBot.define do
+ factory :google_feed_setting, class: Spree::GoogleFeedSetting do
+ id { 1 }
+ brand { true }
+ end
+end
diff --git a/core/lib/spree/testing_support/factories/product_factory.rb b/core/lib/spree/testing_support/factories/product_factory.rb
index a88dc4d8ff..a65f6b5dd7 100644
--- a/core/lib/spree/testing_support/factories/product_factory.rb
+++ b/core/lib/spree/testing_support/factories/product_factory.rb
@@ -52,6 +52,12 @@ FactoryBot.define do
factory :product_with_option_types do
after(:create) { |product| create(:product_option_type, product: product) }
end
+ factory :product_with_properties do
+ after(:create) do |product|
+ create(:property, :brand, id: 10)
+ create(:product_property, product: product, property_id: 10, value: 'Epsilon')
+ end
+ end
end
end
end
diff --git a/core/lib/spree/testing_support/factories/store_factory.rb b/core/lib/spree/testing_support/factories/store_factory.rb
index 7358afe026..e19dfb097e 100644
--- a/core/lib/spree/testing_support/factories/store_factory.rb
+++ b/core/lib/spree/testing_support/factories/store_factory.rb
@@ -12,6 +12,7 @@ FactoryBot.define do
facebook { 'spreecommerce' }
twitter { 'spreecommerce' }
instagram { 'spreecommerce' }
+ meta_description { 'Sample store description.' }
trait :with_favicon do
transient do
diff --git a/core/lib/spree/testing_support/factories/variant_factory.rb b/core/lib/spree/testing_support/factories/variant_factory.rb
index 3e8d11d63f..c9aca8a764 100644
--- a/core/lib/spree/testing_support/factories/variant_factory.rb
+++ b/core/lib/spree/testing_support/factories/variant_factory.rb
@@ -25,6 +25,10 @@ FactoryBot.define do
factory :variant do
# on_hand 5
product { |p| p.association(:product, stores: [create(:store)]) }
+
+ factory :with_image_variant do
+ images { create_list(:image, 1) }
+ end
end
factory :master_variant do
diff --git a/core/spec/models/spree/google_feed_setting_spec.rb b/core/spec/models/spree/google_feed_setting_spec.rb
new file mode 100644
index 0000000000..577aad9f55
--- /dev/null
+++ b/core/spec/models/spree/google_feed_setting_spec.rb
@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Spree::GoogleFeedSetting, type: :model do
+ let(:store) { create(:store) }
+ let(:google_feed_setting) { create(:google_feed_setting, store: store) }
+
+ describe '#enabled_keys' do
+ it 'returns enabled key' do
+ expect(google_feed_setting.enabled_keys).to include(:brand)
+ end
+
+ it 'does not return not enabled key' do
+ expect(google_feed_setting.enabled_keys).not_to include(:size)
+ end
+ end
+end
diff --git a/core/spec/services/spree/export/google_rss_spec.rb b/core/spec/services/spree/export/google_rss_spec.rb
new file mode 100644
index 0000000000..0e12f04cde
--- /dev/null
+++ b/core/spec/services/spree/export/google_rss_spec.rb
@@ -0,0 +1,112 @@
+require 'spec_helper'
+require 'pry'
+
+module Spree
+ describe Export::GoogleRss do
+ subject { described_class.new }
+
+ let(:store) { create(:store) }
+ let(:setting) { create(:google_feed_setting, store: store) }
+ let(:product) { create(:product, stores: [store]) }
+ let!(:variant) { create(:with_image_variant, product: product) }
+ let(:result) { subject.call(setting) }
+
+ context 'store header is generated correctly' do
+ before do
+ allow(subject).to receive(:store).and_return(store)
+ end
+
+ it 'store name' do
+ expect(result).to include("<title>#{store.name}</title>").once
+ end
+
+ it 'store url' do
+ expect(result).to include("<link>#{store.url}</link>").once
+ end
+
+ it 'store description' do
+ expect(result).to include("<description>#{store.meta_description}</description>").once
+ end
+ end
+
+ context 'required item attributes are generated correctly' do
+ before do
+ allow(subject).to receive(:store).and_return(store)
+ end
+
+ it 'id' do
+ expect(result).to include("<g:id>#{variant.id}</g:id>").once
+ end
+
+ it 'title' do
+ expect(result).to include("<g:title>#{product.name} - #{variant.option_values.first.name}</g:title>").once
+ end
+
+ it 'description' do
+ expect(result).to include("<g:description>#{product.description}</g:description>").once
+ end
+
+ it 'link' do
+ expect(result).to include("<g:link>#{store.url}/#{product.slug}</g:link>").once
+ end
+
+ it 'image link' do
+ expect(result).to include("<g:image_link>#{variant.images.first.plp_url}</g:image_link>").once
+ end
+
+ it 'price' do
+ expect(result).to include("<g:price>#{variant.price} #{variant.cost_currency}</g:price>").once
+ end
+
+ context 'availability date is in the past' do
+ it 'product is in stock' do
+ expect(result).to include('<g:availability>in stock</g:availability>')
+ end
+
+ it 'product availability date is the same' do
+ expect(result).to include("<g:availability_date>#{product.available_on.xmlschema}</g:availability_date>")
+ end
+ end
+
+ context 'availability date is in the future' do
+ let(:product) { create(:product, stores: [store], available_on: 1.year.from_now) }
+
+ it 'product is on backorder' do
+ expect(result).to include('<g:availability>backorder</g:availability>')
+ end
+ end
+
+ context 'availability date is nil' do
+ let(:product) { create(:product, stores: [store], available_on: nil) }
+
+ it 'product is out of stock' do
+ expect(result).to include('<g:availability>out of stock</g:availability>')
+ end
+
+ it 'product availability date is nil' do
+ expect(result).not_to include('<g:availability_date>')
+ end
+ end
+ end
+
+ context 'optional item attributes are generated correctly' do
+ let(:product) { create(:product_with_properties) }
+
+ before do
+ allow(subject).to receive(:store).and_return(store)
+ end
+
+ it 'adds brand to item attributes' do
+ expect(result).to include("<g:brand>#{product.property('brand')}</g:brand>")
+ end
+
+ context 'brand option is set to false' do
+ let(:setting) { create(:google_feed_setting, store: store, brand: false) }
+
+ it 'does not add brand to item attributes' do
+ expect(result).not_to include('<g:brand>')
+ end
+ end
+ end
+ end
+end