Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Ensure slugs for Product Translations are unique (#12964)
Łukasz Adamczykc6d4f46c8f19
diff --git a/core/app/models/spree/product/slugs.rb b/core/app/models/spree/product/slugs.rbindex b37b487547..f48f357134 100644--- a/core/app/models/spree/product/slugs.rb+++ b/core/app/models/spree/product/slugs.rb@@ -11,11 +11,15 @@ module Spreefriendly_id :slug_candidates, use: [:history, :slugged, :scoped, :mobility], scope: spree_base_uniqueness_scope, slug_limit: 255Product::Translation.class_eval do- before_save :set_slugacts_as_paranoid# deleted translation values also need to be accessible for index views listing deleted resourcesdefault_scope { unscope(where: :deleted_at) }+ before_validation :set_slug+ before_validation :ensure_slug_is_unique++ validates :slug, presence: true, uniqueness: { allow_blank: true, case_sensitive: true, scope: [*::Spree.base_class.spree_base_uniqueness_scope, :locale] }+privatedef set_slug@@ -31,6 +35,11 @@ module Spreeslug.to_urlendend++ def ensure_slug_is_unique+ slug_exists = self.class.where(slug: slug, locale: locale).where.not(id: id).exists?+ self.slug = [slug, SecureRandom.uuid].join('-') if slug_exists+ endendbefore_validation :downcase_slugdiff --git a/core/spec/models/spree/product/slugs_spec.rb b/core/spec/models/spree/product/slugs_spec.rbindex dd0ef3d393..1c6393a0ca 100644--- a/core/spec/models/spree/product/slugs_spec.rb+++ b/core/spec/models/spree/product/slugs_spec.rb@@ -261,4 +261,77 @@ describe Spree::Product::Slugs, type: :model doendendend++ describe 'translated slugs' do+ let(:product) { create(:product, name: 'Red shoes', stores: [store]) }++ describe 'generating slugs' do+ subject(:save_translation) { translation.save! }++ context 'when a translated product has no name and slug' do+ let(:translation) { product.translations.build(locale: 'fr', name: nil, slug: nil) }++ it 'generates slug from the product name' do+ save_translation+ expect(translation.slug).to eq('red-shoes')+ end+ end++ context 'when a translated product has no slug' do+ let(:translation) { product.translations.build(locale: 'fr', name: 'Chaussures rouges', slug: nil) }++ it 'generates slug from the translated product name' do+ save_translation+ expect(translation.slug).to eq('chaussures-rouges')+ end+ end++ context 'when a translated product has a slug' do+ let(:translation) { product.translations.build(locale: 'fr', name: 'Chaussures rouges', slug: 'Custom Slug!') }++ it 'normalizes the existing slug' do+ save_translation+ expect(translation.slug).to eq('custom-slug')+ end+ end+ end++ describe 'ensuring slug uniqueness' do+ subject(:save_translation) { translation.save! }++ let!(:existing_product) { create(:product, stores: [store]) }+ let!(:existing_product_translation) { existing_product.translations.create!(locale: 'fr', slug: existing_slug) }++ context 'when the slug is unique in the same locale' do+ let(:translation) { product.translations.build(locale: 'fr', slug: 'unique-slug') }+ let(:existing_slug) { 'different-slug' }++ it 'keeps the original slug' do+ save_translation+ expect(translation.slug).to eq('unique-slug')+ end+ end++ context 'when the slug is not unique in the same locale' do+ let(:translation) { product.translations.build(locale: 'fr', slug: 'duplicate-slug') }+ let(:existing_slug) { 'duplicate-slug' }++ it 'appends a UUID to make it unique' do+ save_translation+ expect(translation.slug).to match(/duplicate-slug-.+/)+ expect(translation.slug).not_to eq('duplicate-slug')+ end+ end++ context 'when the slug is unique in a different locale' do+ let(:translation) { product.translations.build(locale: 'es', slug: 'same-slug') }+ let(:existing_slug) { 'same-slug' }++ it 'allows the same slug in different locales' do+ save_translation+ expect(translation.slug).to eq('same-slug')+ end+ end+ end+ endend