Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Added a spec for the admin fulfillment stock location permission check
Damian Legawieccb3faea691cf
diff --git a/spree/api/spec/controllers/spree/api/v3/admin/orders/fulfillments_controller_spec.rb b/spree/api/spec/controllers/spree/api/v3/admin/orders/fulfillments_controller_spec.rbindex b1b6009596..63ef621855 100644--- a/spree/api/spec/controllers/spree/api/v3/admin/orders/fulfillments_controller_spec.rb+++ b/spree/api/spec/controllers/spree/api/v3/admin/orders/fulfillments_controller_spec.rb@@ -173,6 +173,43 @@ RSpec.describe Spree::Api::V3::Admin::Orders::FulfillmentsController, type: :conexpect(shipment.reload.stock_location).not_to eq(foreign_stock_location)end+ # Moving a parcel is checked like creating or splitting one: the target+ # location must be one this staff member may see, not just any of the store's.+ context 'as staff who can manage fulfillments but not stock locations' do+ let(:limited_role) do+ create(:role, name: 'fulfillment_only', resource: store,+ permissions: %w[read_orders write_orders read_fulfillments write_fulfillments])+ end+ let(:limited_admin) do+ create(:admin_user, :without_admin_role).tap { |user| user.spree_roles << limited_role }+ end+ let(:headers) do+ { 'Authorization' => "Bearer #{Spree::Api::V3::TestingSupport.generate_jwt(limited_admin, audience: Spree::Api::V3::JwtAuthentication::JWT_AUDIENCE_ADMIN)}" }+ end+ let(:other_location) { create(:stock_location, store: store, name: 'Back office') }++ it 'refuses a stock location it cannot see' do+ patch :update, params: {+ order_id: order.prefixed_id,+ id: shipment.prefixed_id,+ stock_location_id: other_location.prefixed_id+ }, as: :json++ expect(response).to have_http_status(:not_found)+ expect(shipment.reload.stock_location).not_to eq(other_location)+ end++ it 'still updates the rest of the fulfillment' do+ patch :update, params: {+ order_id: order.prefixed_id,+ id: shipment.prefixed_id,+ tracking: '1Z999AA10123456784'+ }, as: :json++ expect(response).to have_http_status(:ok)+ end+ end+it 'updates fulfillment tracking' dopatch :update, params: {order_id: order.prefixed_id,