Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Remove APIs' magic 404 logic (#11345)

Damian Legawieccda22f34902c
diff --git a/api/app/controllers/spree/api/errors_controller.rb b/api/app/controllers/spree/api/errors_controller.rb
deleted file mode 100644
index b513add297..0000000000
--- a/api/app/controllers/spree/api/errors_controller.rb
+++ /dev/null
@@ -1,9 +0,0 @@
-module Spree
- module Api
- class ErrorsController < ActionController::API
- def render_404
- render 'spree/api/errors/not_found', status: 404
- end
- end
- end
-end
diff --git a/api/config/routes.rb b/api/config/routes.rb
index de08b1aa21..d1c03e5b15 100644
--- a/api/config/routes.rb
+++ b/api/config/routes.rb
@@ -279,8 +279,5 @@ Spree::Core::Engine.add_routes do
resources :stores
end
end
-
- get '/404', to: 'errors#render_404'
- match '*path', to: 'errors#render_404', via: [:get, :post, :put, :patch, :delete]
end
end
diff --git a/api/spec/requests/spree/api/errors_spec.rb b/api/spec/requests/spree/api/errors_spec.rb
deleted file mode 100644
index 5d5300de3b..0000000000
--- a/api/spec/requests/spree/api/errors_spec.rb
+++ /dev/null
@@ -1,11 +0,0 @@
-require 'spec_helper'
-
-describe 'API Errors Spec', type: :request do
- context 'unexisting API route' do
- it 'returns 404' do
- get '/api/prods'
-
- expect(response).to have_http_status 404
- end
- end
-end
diff --git a/api/spec/requests/version_spec.rb b/api/spec/requests/version_spec.rb
index 3e28417e60..7f6d03b154 100644
--- a/api/spec/requests/version_spec.rb
+++ b/api/spec/requests/version_spec.rb
@@ -3,13 +3,6 @@ require 'spec_helper'
describe 'Version', type: :request do
before { create_list(:country, 2) }
- describe '/api' do
- it 'returns 404' do
- get '/api/countries'
- expect(response).to have_http_status 404
- end
- end
-
describe '/api/v1' do
it 'be successful' do
get '/api/v1/countries'