Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed: saving `Product#meta_title` works in admin

Damian Legawiecce7699ef74d7
diff --git a/admin/spec/controllers/spree/admin/products_controller_spec.rb b/admin/spec/controllers/spree/admin/products_controller_spec.rb
index 9241faf495..36068418e6 100644
--- a/admin/spec/controllers/spree/admin/products_controller_spec.rb
+++ b/admin/spec/controllers/spree/admin/products_controller_spec.rb
@@ -170,7 +170,9 @@ RSpec.describe Spree::Admin::ProductsController, type: :controller do
dimensions_unit: 'cm',
weight_unit: 'kg',
shipping_category_id: shipping_category.id,
- tax_category_id: tax_category.id
+ tax_category_id: tax_category.id,
+ meta_title: 'Amazing Product',
+ meta_description: 'This is an amazing product'
}
end
@@ -190,6 +192,8 @@ RSpec.describe Spree::Admin::ProductsController, type: :controller do
expect(product.shipping_category).to eq shipping_category
expect(product.tax_category).to eq tax_category
+ expect(product.meta_title).to eq 'Amazing Product'
+ expect(product.meta_description).to eq 'This is an amazing product'
end
context 'with multi-currency pricing' do
diff --git a/core/lib/spree/permitted_attributes.rb b/core/lib/spree/permitted_attributes.rb
index c99ace677a..2f5fdfa660 100644
--- a/core/lib/spree/permitted_attributes.rb
+++ b/core/lib/spree/permitted_attributes.rb
@@ -151,7 +151,7 @@ module Spree
@@product_attributes = [
:name, :description, :available_on, :make_active_at, :discontinue_on, :permalink, :meta_description,
- :meta_keywords, :price, :sku, :deleted_at, :prototype_id,
+ :meta_keywords, :meta_title, :price, :sku, :deleted_at, :prototype_id,
:option_values_hash, :weight, :height, :width, :depth,
:shipping_category_id, :tax_category_id,
:cost_currency, :cost_price, :compare_at_price,