Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Tidy up serializer -name serializer for polymorphic associations. (#11235)

Matthew Kennedycf17dd658c58
diff --git a/api/app/serializers/spree/api/v2/platform/menu_item_serializer.rb b/api/app/serializers/spree/api/v2/platform/menu_item_serializer.rb
index dabe213031..62142871c3 100644
--- a/api/app/serializers/spree/api/v2/platform/menu_item_serializer.rb
+++ b/api/app/serializers/spree/api/v2/platform/menu_item_serializer.rb
@@ -13,8 +13,13 @@ module Spree
belongs_to :menu, serializer: :menu
belongs_to :parent, record_type: :menu_item, serializer: :menu_item
- belongs_to :linked_resource, polymorphic: true
- has_many :children, record_type: :menu_item, serializer: :menu_item
+ belongs_to :linked_resource, polymorphic: {
+ Spree::Cms::Pages::StandardPage => :cms_page,
+ Spree::Cms::Pages::FeaturePage => :cms_page,
+ Spree::Cms::Pages::Homepage => :cms_page
+ }
+
+ has_many :children, record_type: :menu_item, serializer: :menu_item
end
end
end
diff --git a/api/app/serializers/spree/v2/storefront/feature_page_serializer.rb b/api/app/serializers/spree/v2/storefront/feature_page_serializer.rb
deleted file mode 100644
index 63c0d2e4da..0000000000
--- a/api/app/serializers/spree/v2/storefront/feature_page_serializer.rb
+++ /dev/null
@@ -1,8 +0,0 @@
-module Spree
- module V2
- module Storefront
- class FeaturePageSerializer < CmsPageSerializer
- end
- end
- end
-end
diff --git a/api/app/serializers/spree/v2/storefront/homepage_serializer.rb b/api/app/serializers/spree/v2/storefront/homepage_serializer.rb
deleted file mode 100644
index b7bbba63b7..0000000000
--- a/api/app/serializers/spree/v2/storefront/homepage_serializer.rb
+++ /dev/null
@@ -1,8 +0,0 @@
-module Spree
- module V2
- module Storefront
- class HomepageSerializer < CmsPageSerializer
- end
- end
- end
-end
diff --git a/api/app/serializers/spree/v2/storefront/menu_item_serializer.rb b/api/app/serializers/spree/v2/storefront/menu_item_serializer.rb
index 914449a6c5..00cf06eb51 100644
--- a/api/app/serializers/spree/v2/storefront/menu_item_serializer.rb
+++ b/api/app/serializers/spree/v2/storefront/menu_item_serializer.rb
@@ -28,9 +28,15 @@ module Spree
record_type: :image,
serializer: :image
+ belongs_to :menu, serializer: :menu
belongs_to :parent, record_type: :menu_item, serializer: :menu_item
- belongs_to :linked_resource, polymorphic: true
- has_many :children, record_type: :menu_item, serializer: :menu_item
+ belongs_to :linked_resource, polymorphic: {
+ Spree::Cms::Pages::StandardPage => :cms_page,
+ Spree::Cms::Pages::FeaturePage => :cms_page,
+ Spree::Cms::Pages::Homepage => :cms_page
+ }
+
+ has_many :children, record_type: :menu_item, serializer: :menu_item
end
end
end
diff --git a/api/app/serializers/spree/v2/storefront/standard_page_serializer.rb b/api/app/serializers/spree/v2/storefront/standard_page_serializer.rb
deleted file mode 100644
index eb46108207..0000000000
--- a/api/app/serializers/spree/v2/storefront/standard_page_serializer.rb
+++ /dev/null
@@ -1,8 +0,0 @@
-module Spree
- module V2
- module Storefront
- class StandardPageSerializer < CmsPageSerializer
- end
- end
- end
-end